From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2883470AE for ; Sun, 21 Dec 2025 16:00:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BC6DE402EE; Sun, 21 Dec 2025 16:00:47 +0100 (CET) Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010029.outbound.protection.outlook.com [52.101.193.29]) by mails.dpdk.org (Postfix) with ESMTP id 375454025F for ; Sun, 21 Dec 2025 16:00:46 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ow39J2m6/q0XRIjvPmjqMFZhgqAcF6jRH4nR4I2Mm1VKo/6O9OOK7MuS3khidj2VGgPgjA1faogLQalDVR5YRAek6gmXOxmHHhwRdD43vO0RbZV3lYsppIuGYYQy+1Jm71G0fa9pJSX1jiPw1yn63dgxdJuvLbsk+VBs1OuyDlOBejO45MFBwkTtiD0+RuEW5fDq/TxfwAZqOfToZT/RCx0Dkkb/k6URsk7zNZiY3kp0H34eE3M6NqsKOhC4/OkdDqJOwbNzP7iRuDPJBZTCz8gyb1nyXfg6StkP0iJ/PLImdsuJoWXvVtK9Q2UHKuQZtl+L9DvZsaKATTyU+hgc3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tKNA0/eTvx7diDHgSefeU/rTT8qyvgLQa2+Zvq9PSDA=; b=k2tJfJVDMdV8BB+sxJ5SXX2w5uhTkeyP2ID79bbCKrx8nDVpCZGH1otmkuSUYrwosoUkRjnQeLIDtFsiq/g0R7D/JpH05/sAYGsrjn1lPTWQKu1QRyBk9pC5JqmyR5N9eQlbDJ6f9uFj7f/YAg7sGc3XCJeSmVa1uZ/bLwJxmrhU1SH1NLrmSJFp2IyEDXpb6jGL7No3Lsc1USFgGS9cdwKvPt8n5w6CPnM4brgzzl9QvNSwQf3vftuCakXIusSjVdt/mHTtbTi9WGC/zGxlpX4jtowuzq3OORUqJXK2mgB5MmcIMnYDXf1Fh8tz/DNrBHNp51+/cEkwUYPwvDj6qw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=arknetworks.am smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tKNA0/eTvx7diDHgSefeU/rTT8qyvgLQa2+Zvq9PSDA=; b=l+gFRUwVZvoRPTMzdD00TJ1uscn/5DPfKhCa/9ewC6kwpUExyFuuSFnn0faKz7W+Aq54Pjzrty11GUziaHUrIAJYlPv2GN8REYPbbhj38t9OaFica5keYo/H1lm5EGS8FYJ74T8Hx/gt9lc2aEUBigZEgUkfHshU/QdIvoQYvZVIKc8dgSpQmMh3GcXFZ4To6Git2Fby9Zv0GO4wV+FRa0xK21XyTpG596HEU4Ehry1ynTgFGg7b+xHFGE0o9M8DQVF/nZY9swtqgEhSkP/PgtTYIjrsCIG70o2cCGMtdqXX0DIZpZGbapmOO5aOG3639CJgDexXfwzCtFrNVgBRvQ== Received: from BL1PR13CA0154.namprd13.prod.outlook.com (2603:10b6:208:2bd::9) by PH7PR12MB9125.namprd12.prod.outlook.com (2603:10b6:510:2f4::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.11; Sun, 21 Dec 2025 15:00:40 +0000 Received: from BL6PEPF0002256E.namprd02.prod.outlook.com (2603:10b6:208:2bd:cafe::fd) by BL1PR13CA0154.outlook.office365.com (2603:10b6:208:2bd::9) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:00:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BL6PEPF0002256E.mail.protection.outlook.com (10.167.249.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:00:39 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:00:19 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:00:19 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 07:00:17 -0800 From: Shani Peretz To: Maayan Kashani CC: Dariusz Sosnowski , Ivan Malov , dpdk stable Subject: patch 'net/mlx5: fix unsupported flow rule port action' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:56:12 +0200 Message-ID: <20251221145746.763179-24-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF0002256E:EE_|PH7PR12MB9125:EE_ X-MS-Office365-Filtering-Correlation-Id: 3e6cb88c-e773-4f7e-1f4d-08de40a1b48d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|36860700013|376014|82310400026|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?DIHZI8mKwgiAbCHDbfbQhZES12XpYBhL/0+34v24/R0Eolec9T3yTr7VpKFC?= =?us-ascii?Q?FlYiIU4YHDH40JxLqMin05kDqlx0MEBjcvI38msXuFa1quMvhJUvXUgyf1pV?= =?us-ascii?Q?dh3l8scoW12ObfzZMUvu4X4eqxxXpI7DrIpYnIlRDG5z88RljFN1T35uWiQW?= =?us-ascii?Q?79MOp4NVUTafddbXCP08f38rD5VjZUL0ORtfSlWRSkeoRVeqS2ArM1mc+6SD?= =?us-ascii?Q?al98cAPZ0da5ewL1lb7kWXMOp9XyiCkitBVbglf40sRITvyo2hrwaaLkgEOl?= =?us-ascii?Q?Q2yfh2aDyOrFJ6uTBFrwHGNpA1UJR3waETziFEiRCbHA5eMfAImQmdQSKOoi?= =?us-ascii?Q?V5YA5n7w+2kiV3We6DLo3SjZr1FfP1YQILdeSM6MGNxkK3PLCWtj54Rd5Q9L?= =?us-ascii?Q?lvooHmXSjhPBZkFJg7YVlUqlrl7YKmqKjAQf/9b0LM/dLiPs8YtD9C9iTNR1?= =?us-ascii?Q?oclaIc0UJ9OwkwQZ9uE5f1WLu1iYRMYyppt+dR+M8lbrCihvteiszZ9RJQ+L?= =?us-ascii?Q?iczXM9xH4zMK6ss3YxcJJaknmt7pU6bPz6AOnmWnEAhrNGbXk/urpYy8ys2+?= =?us-ascii?Q?Ezs0GeVwkCv9y4plnKSa/McIEFau+QhdbWcxgBJoeOg8fNYhxs5xm4ZyCQB5?= =?us-ascii?Q?Ru+OTuv8V0T8bcSWJcRi4mCW4UV09Nxk1UiLrX93mt5inPG0Riyp+ftqLZhK?= =?us-ascii?Q?9eItR2G6C+aoezTN5ppOp3AaYfmClfLCbWFHkyrv3iXErLTkkWfcOH5nj06y?= =?us-ascii?Q?Fiyr66XsjonjE71Ruk/gmF7a6kA5zvpOhl8EyIn7Spvw4no8zfwKVy6K57nw?= =?us-ascii?Q?/aJJSNULfbubAexzO1mxrwVnO1ermdU6pe1KMkhtTVqwRxYJDpn0SnDi4Jfx?= =?us-ascii?Q?+cDcnOV7B3a9XwUDLYwx9XIpn5Ci9AdG4vqPTIgndIs8DD2jpGy0DlRJPdW4?= =?us-ascii?Q?e3jxh9AFL3xeKS/ri5dOa3GIsm7dOZu67tgwWwlXxebhp5IrYi+k2UdMGuCl?= =?us-ascii?Q?32qpnDwirkEmIonNT34BIgXR5fk5iDkyuGwjXdAny8yLH4H2GogHGtGHKOUx?= =?us-ascii?Q?hM3vKDMGcEr+Vww0/huSzDiPTTRt1ctlJIuNPPpzTDgiGGEAdtisnXjmT1Tu?= =?us-ascii?Q?+7uTLC2Jqyj6r+1xx6d+lXBVBtMJo6+eNc/c/H5nZdVwJlEr8ZMyO6J+HU7I?= =?us-ascii?Q?C0g9dT1Z+EDwfmg2cNoG3Po1SX0ha2CdEzt6JR1DPl2UROMtyXQqc7JaDPzG?= =?us-ascii?Q?0RrJwRAJpW/xE/NhWlyAChIp+bnKytpOT38AGdmfzYGOzLDso7/arHZt+5AY?= =?us-ascii?Q?lmb914urAWhELjXNvOiDPdVHcbckRlbYRibvz6fvLu8Djd9J5MshCzx1fFgP?= =?us-ascii?Q?mTFRw5PdHGexcJvHPvAHlz39OK6lFytByD5yLoj0byJY6VBon1kNB39kSQbo?= =?us-ascii?Q?1SSYR6W0NW07LT8k7cRztq+qoLGh6w73SDeQ6UwGbn3kN3r++2c0nQKunbpe?= =?us-ascii?Q?7paBulk8oLdJDFgKLBeV9WlMAK6og+EVWkNVRHkac3GPuGuOIheA2SUZRsqX?= =?us-ascii?Q?++Pg6NKV6yYZaRLjBX2qACLINoysVuoS4C2KP3IX?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(36860700013)(376014)(82310400026)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:00:39.4510 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3e6cb88c-e773-4f7e-1f4d-08de40a1b48d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF0002256E.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB9125 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/6dacb61571c8a8df1cd40f3af8d46e821c868715 Thanks. Shani --- >From 6dacb61571c8a8df1cd40f3af8d46e821c868715 Mon Sep 17 00:00:00 2001 From: Maayan Kashani Date: Thu, 7 Aug 2025 12:12:47 +0300 Subject: [PATCH] net/mlx5: fix unsupported flow rule port action [ upstream commit c040e9a85a1fbce46528e9bc15d1ce4bbc911346 ] When dv_flow_en=2, the port ID action is not supported. Although a rule can be created successfully in non-template mode, the specified action will be silently ignored and not applied. To prevent this ambiguous behavior, explicitly return an error when a port ID action is used with dv_flow_en=2, and recommend using a represented port action instead. Fixes: f1fecffa88df ("net/mlx5: support Direct Rules action template API") Signed-off-by: Maayan Kashani Acked-by: Dariusz Sosnowski Acked-by: Ivan Malov --- drivers/net/mlx5/mlx5_flow_hw.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 540828008b..923ced68c8 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -2478,6 +2478,10 @@ __flow_hw_actions_translate(struct rte_eth_dev *dev, case RTE_FLOW_ACTION_TYPE_END: actions_end = true; break; + case RTE_FLOW_ACTION_TYPE_PORT_ID: + DRV_LOG(ERR, "RTE_FLOW_ACTION_TYPE_PORT_ID action is not supported. " + "Use RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT instead."); + goto err; default: break; } @@ -6178,6 +6182,10 @@ flow_hw_dr_actions_template_create(struct rte_eth_dev *dev, at->dr_off[i] = curr_off; action_types[curr_off++] = MLX5DR_ACTION_TYP_MISS; break; + case RTE_FLOW_ACTION_TYPE_PORT_ID: + DRV_LOG(ERR, "RTE_FLOW_ACTION_TYPE_PORT_ID action is not supported. " + "Use RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT instead."); + return NULL; default: type = mlx5_hw_dr_action_types[at->actions[i].type]; at->dr_off[i] = curr_off; -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:18.561727702 +0200 +++ 0024-net-mlx5-fix-unsupported-flow-rule-port-action.patch 2025-12-21 16:54:16.825029000 +0200 @@ -1 +1 @@ -From c040e9a85a1fbce46528e9bc15d1ce4bbc911346 Mon Sep 17 00:00:00 2001 +From 6dacb61571c8a8df1cd40f3af8d46e821c868715 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c040e9a85a1fbce46528e9bc15d1ce4bbc911346 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -21,2 +22,2 @@ - drivers/net/mlx5/mlx5_flow_hw.c | 10 +++++++++- - 1 file changed, 9 insertions(+), 1 deletion(-) + drivers/net/mlx5/mlx5_flow_hw.c | 8 ++++++++ + 1 file changed, 8 insertions(+) @@ -25 +26 @@ -index 016370f68b..0c3f554479 100644 +index 540828008b..923ced68c8 100644 @@ -28 +29 @@ -@@ -2913,6 +2913,10 @@ __flow_hw_translate_actions_template(struct rte_eth_dev *dev, +@@ -2478,6 +2478,10 @@ __flow_hw_actions_translate(struct rte_eth_dev *dev, @@ -39,2 +40 @@ -@@ -7648,7 +7652,11 @@ flow_hw_parse_flow_actions_to_dr_actions(struct rte_eth_dev *dev, - case MLX5_RTE_FLOW_ACTION_TYPE_MIRROR: +@@ -6178,6 +6182,10 @@ flow_hw_dr_actions_template_create(struct rte_eth_dev *dev, @@ -42,3 +42,2 @@ - action_types[curr_off++] = MLX5DR_ACTION_TYP_DEST_ARRAY; -- break; -+ break; + action_types[curr_off++] = MLX5DR_ACTION_TYP_MISS; + break; @@ -48 +47 @@ -+ return -EINVAL; ++ return NULL;