From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42458470AE for ; Sun, 21 Dec 2025 16:01:05 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3CB054025F; Sun, 21 Dec 2025 16:01:05 +0100 (CET) Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010035.outbound.protection.outlook.com [52.101.193.35]) by mails.dpdk.org (Postfix) with ESMTP id 202D74025F for ; Sun, 21 Dec 2025 16:01:04 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=hH9vturGQm6fTkFWOvcwH1VfTvzEluv8Boc6Dtn1zePeSRAJNOZQKrXILr4QWPk7D+7pP4irFTyOjJFw+P+EzdD2ZxWQSEyg3ixixZ7NnRNOzz6DDllaGSDDEpMK4w/b4pl9L1hDcHIciPpv8WquStlO77M3aeCn0qZHrPe1uAnRlDljQ7J3pDNlK6sRHI1kK6Jpoad4lYjeD2ndBtWPa3pZWgAjAU1bmPVfjSm58wkszWSSToy163QdMHdQXf7TzxsI2M4ou/KY83PjU5KyWcrzl1NP4twsLfpEMSRWJLWSmnpggH8TspZPwAbsNi4aPRwSWYcRDn4sLgTrxwAl7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=K9K/w/kLfubP2ub7XpfR8xJ01eHhCOy5ZeVsd6bgrLk=; b=MUtvYNjwwiXrYaKsj3UA5cVBmtU8yQeV5VNEyU0DNM9qZYqkcO/hV3yYx9P3eYetc5FEDy4UgXROpQFi/YJAv9fR+Y0qbO+fm3aUG6kCWsywBIan5z/63xWtmKFQy7PtMQlJMjDutkcg/hABk7jYBYAYIpePS7/d+khtlB2jlEKbCKuMGKou3ViPNXIHECkI/kV/WUdKDxKMEV8tiZo1ODaOU9LHAoh8hBoUPD7nWweHs/OgLskuHxsH6sUx6H7XL/QkyvnreA+xP0a/msat70D6qk2WvcT7s0vcYHoRxMv6WnrxKKEspxnB5atzE43/+9C7GY27F0zM6C7mSIk7uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=K9K/w/kLfubP2ub7XpfR8xJ01eHhCOy5ZeVsd6bgrLk=; b=uNIZoWhpusHGH7fPYkC7C9BsagQkh7LNR0zlpOJ5a5O/Ap51/4UlDqJ/i4cFf/JJrDFG8zPTBlTsxs9kQ233htj9rlmJCAfziNuMzxq3wpe+jlz31/tK8HvGZuUPyvU4K9BpK4/NOv/AGymkYIJYr9iwSY7U2qlFxfcacUzwH18uPOdy7tKB9VqPb9zoXDr/LkIh3LpZdVKgY6Z+YBZUX+P+IlMYyPwVzS+kFtMeFMMYfyyFiqsu6+jddExrhnMSRbGqS7p1bKEHWe7CPdVE/ZhjC8hhDCthQ9bLt7+pql/BKOGMUzC88s+2GUFAC4tdM9FOSl4f7t1TYF7bSl8Spw== Received: from MN2PR06CA0023.namprd06.prod.outlook.com (2603:10b6:208:23d::28) by PH7PR12MB6953.namprd12.prod.outlook.com (2603:10b6:510:1ac::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9320.15; Sun, 21 Dec 2025 15:00:58 +0000 Received: from BN3PEPF0000B370.namprd21.prod.outlook.com (2603:10b6:208:23d:cafe::f8) by MN2PR06CA0023.outlook.office365.com (2603:10b6:208:23d::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.11 via Frontend Transport; Sun, 21 Dec 2025 15:00:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BN3PEPF0000B370.mail.protection.outlook.com (10.167.243.167) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9478.0 via Frontend Transport; Sun, 21 Dec 2025 15:00:58 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:00:41 -0800 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:00:41 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 07:00:40 -0800 From: Shani Peretz To: Gregory Etelson CC: Dariusz Sosnowski , dpdk stable Subject: patch 'net/mlx5: fix interface name parameter definition' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:56:18 +0200 Message-ID: <20251221145746.763179-30-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN3PEPF0000B370:EE_|PH7PR12MB6953:EE_ X-MS-Office365-Filtering-Correlation-Id: 85bb01dc-5c19-4746-f418-08de40a1bfeb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|376014|36860700013|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?GwKcDYnEga1mWkSjJ6F4Lc1RcAvXYPK4E76HQr+Nt8VYONaxCTbnTp3TPtlt?= =?us-ascii?Q?PcSZ7EYSvi3kJbvoidvDHzkhGI/P0hje34fvuFCyYstO/xGnphZhwJTnRvq6?= =?us-ascii?Q?hKI2L+2l3Szn6IamzMXuHrfqfa5u0tLotK1HJ0Osyc9Lb/96ZbEtqGDJ9LPt?= =?us-ascii?Q?mWTWcZzxFHRZHA7qKpmKUjemfxvngEtxrfcbdHQvmc3j5xYk0HgIxKGgtBw5?= =?us-ascii?Q?UXrKMGPnqtJWdg9nLoo3/HWJWYfruXvfSt5KmCgDKb5yhPKK/cv2Y/yGZqvX?= =?us-ascii?Q?axK3J2BXUaYPT+74tPr8eq0m8zRJkvYHzHR3qCT+GU/NNWIT7xZDdtW0EKWc?= =?us-ascii?Q?I4ZPFvjUP6FMdzin9LLpbjh20HnrbP2z1pqTONczTOQ6Ea+y1+anKVM6BlHP?= =?us-ascii?Q?2/tEPQ9aGWTmoUx0QJORrfhPDXTpolgXwUv79ZyG3n3o5unohOQi9l/lZXTq?= =?us-ascii?Q?MyhrAy52vRqcSkBxjSVaT66gNqsFhsYgMhVOOuoZD6v7LTUnd50Hii7y0tsC?= =?us-ascii?Q?mTvLBkgCpxtVc64ZSIPU3/thV6mAEVNzJbcf3bnBL5ylqr0O89fOc6Ar3j41?= =?us-ascii?Q?+p8yxt1RtgXxDyWRjN4sgxTlmXlFLoZwKJALlCysSj3hhjpAcOIky1+eSTaw?= =?us-ascii?Q?FWAlMpm3yzDnU3hgVe87N0Lkobux46tGccB2c66WY6zx7jltQPMWk6fTjB2E?= =?us-ascii?Q?8zXgTGmxmHPA563uL0nUXFhRu+ZtZNAZB+Yu4sKnoqHXLrkgSsY4C2RmzQt2?= =?us-ascii?Q?0LMH7hpwfQuSYZTR81dc2Q3GmwWltl7p+LPFxnI6/nzWgC06c2h2ohCe+1CZ?= =?us-ascii?Q?d9KlAtySClIqxZ9p6Oi4+c3z0qGjxn5ktbvSv+taChbnYmNRsVX2SietsR3L?= =?us-ascii?Q?Vk3ixAfl5NPSM9g174gfnxk9lY2JA6Q7Hl4Z09wRDt1coGxpeJoe1QAV/HAe?= =?us-ascii?Q?dlYXkxdBfRd7J1Z19dXbSW9f2wNWspspGWvvpYi7HpbK1t4HkwlydaH799fP?= =?us-ascii?Q?cuY8mTtQWKZ3SL0TQ9KGJMDhJY+bGKpS4ce1FI//tiC564fQKNPTA0/T5STR?= =?us-ascii?Q?sf5HIPHEBPOzdoDaWwIE1kr+urtHTtfV2U/CgRRlw6at4ADFfZsYIN0rxr9l?= =?us-ascii?Q?BaEjBjmCGt1MIyN13R1SA8zHvq0BBGUtA7amEjOqX6g0jbz+Abl4uYkoaKsP?= =?us-ascii?Q?jSOzXeC3n/xsoHmZS0zJ1571eZxiDZdMEceMUdvbR17VHYIl6opocgzPouLO?= =?us-ascii?Q?pWYAYHNuhpQRZ+nssEn4IJyGMFG/r25J9Ik4vMt0iZKDMrBUHltfAPxbiqxX?= =?us-ascii?Q?vE5yj4tQrAg63dChUElmogVls4PqzdXCGF9iMDy/nR6CjDh3OUvSGQbdty6f?= =?us-ascii?Q?XZvQ23TZnPVwipwemMNQovgezEzZo+BgVDX1ZtC/liIuZbi6Yw+xsYAdxZ7p?= =?us-ascii?Q?+DP/iXcFfZXwOjuYFXVK6qkRC/ybl0tTLQhBa6+3oO+xCOvP4ZWuL/CR29fv?= =?us-ascii?Q?qUvaNN7SmBLs+v6O35i7uEZZ54O6rz/YKDkM/Y72EJ3brH7npW0LRQzMFc58?= =?us-ascii?Q?/vc8AHBCfkjJWoUp3zqgUcGIZ/l7kyXo0UhmEz6w?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(376014)(36860700013)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:00:58.5105 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 85bb01dc-5c19-4746-f418-08de40a1bfeb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN3PEPF0000B370.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6953 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/bbadc2d263a47ef5903fee94d0ca00682504f345 Thanks. Shani --- >From bbadc2d263a47ef5903fee94d0ca00682504f345 Mon Sep 17 00:00:00 2001 From: Gregory Etelson Date: Sun, 10 Aug 2025 16:22:59 +0300 Subject: [PATCH] net/mlx5: fix interface name parameter definition [ upstream commit 9e58a50c059f3760c51ddee16073496c6e1d510a ] The patch fixes `ifname` parameter as a character buffer. Fixes: 1256805dd54d ("net/mlx5: move Linux-specific functions") Signed-off-by: Gregory Etelson Acked-by: Dariusz Sosnowski --- drivers/net/mlx5/linux/mlx5_ethdev_os.c | 11 +++++------ drivers/net/mlx5/linux/mlx5_os.c | 2 +- drivers/net/mlx5/mlx5.h | 3 +-- drivers/net/mlx5/windows/mlx5_ethdev_os.c | 4 ++-- 4 files changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/net/mlx5/linux/mlx5_ethdev_os.c b/drivers/net/mlx5/linux/mlx5_ethdev_os.c index 4d126751a2..ea89ce8e05 100644 --- a/drivers/net/mlx5/linux/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/linux/mlx5_ethdev_os.c @@ -156,7 +156,7 @@ mlx5_auxiliary_get_ifindex(const char *sf_name) * 0 on success, a negative errno value otherwise and rte_errno is set. */ int -mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) +mlx5_get_ifname(const struct rte_eth_dev *dev, char ifname[MLX5_NAMESIZE]) { struct mlx5_priv *priv = dev->data->dev_private; unsigned int ifindex; @@ -170,12 +170,11 @@ mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) ifindex = mlx5_ifindex(dev); if (!ifindex) { if (!priv->representor) - return mlx5_get_ifname_sysfs(priv->sh->ibdev_path, - *ifname); + return mlx5_get_ifname_sysfs(priv->sh->ibdev_path, ifname); rte_errno = ENXIO; return -rte_errno; } - if (if_indextoname(ifindex, &(*ifname)[0])) + if (if_indextoname(ifindex, ifname)) return 0; rte_errno = errno; return -rte_errno; @@ -233,10 +232,10 @@ error: static int mlx5_ifreq(const struct rte_eth_dev *dev, int req, struct ifreq *ifr) { - char ifname[sizeof(ifr->ifr_name)]; + char ifname[MLX5_NAMESIZE]; int ret; - ret = mlx5_get_ifname(dev, &ifname); + ret = mlx5_get_ifname(dev, ifname); if (ret) return -rte_errno; return mlx5_ifreq_by_ifname(ifname, req, ifr); diff --git a/drivers/net/mlx5/linux/mlx5_os.c b/drivers/net/mlx5/linux/mlx5_os.c index 326b7b7329..3aa500e6a4 100644 --- a/drivers/net/mlx5/linux/mlx5_os.c +++ b/drivers/net/mlx5/linux/mlx5_os.c @@ -1546,7 +1546,7 @@ err_secondary: { char ifname[MLX5_NAMESIZE]; - if (mlx5_get_ifname(eth_dev, &ifname) == 0) + if (mlx5_get_ifname(eth_dev, ifname) == 0) DRV_LOG(DEBUG, "port %u ifname is \"%s\"", eth_dev->data->port_id, ifname); else diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 1b784b109a..a5dde56ed9 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -2148,8 +2148,7 @@ void mlx5_get_mtu_bounds(struct rte_eth_dev *dev, uint16_t *min_mtu, uint16_t *m /* mlx5_ethdev_os.c */ -int mlx5_get_ifname(const struct rte_eth_dev *dev, - char (*ifname)[MLX5_NAMESIZE]); +int mlx5_get_ifname(const struct rte_eth_dev *dev, char ifname[MLX5_NAMESIZE]); unsigned int mlx5_ifindex(const struct rte_eth_dev *dev); int mlx5_get_mac(struct rte_eth_dev *dev, uint8_t (*mac)[RTE_ETHER_ADDR_LEN]); int mlx5_get_mtu(struct rte_eth_dev *dev, uint16_t *mtu); diff --git a/drivers/net/mlx5/windows/mlx5_ethdev_os.c b/drivers/net/mlx5/windows/mlx5_ethdev_os.c index 4f43b95a09..32a9f599b2 100644 --- a/drivers/net/mlx5/windows/mlx5_ethdev_os.c +++ b/drivers/net/mlx5/windows/mlx5_ethdev_os.c @@ -56,7 +56,7 @@ mlx5_get_mac(struct rte_eth_dev *dev, uint8_t (*mac)[RTE_ETHER_ADDR_LEN]) * 0 on success, a negative errno value otherwise and rte_errno is set. */ int -mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) +mlx5_get_ifname(const struct rte_eth_dev *dev, char ifname[MLX5_NAMESIZE]) { struct mlx5_priv *priv; mlx5_context_st *context_obj; @@ -67,7 +67,7 @@ mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) } priv = dev->data->dev_private; context_obj = (mlx5_context_st *)priv->sh->cdev->ctx; - strncpy(*ifname, context_obj->mlx5_dev.name, MLX5_NAMESIZE); + strncpy(ifname, context_obj->mlx5_dev.name, MLX5_NAMESIZE); return 0; } -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:18.884271739 +0200 +++ 0030-net-mlx5-fix-interface-name-parameter-definition.patch 2025-12-21 16:54:16.926091000 +0200 @@ -1 +1 @@ -From 9e58a50c059f3760c51ddee16073496c6e1d510a Mon Sep 17 00:00:00 2001 +From bbadc2d263a47ef5903fee94d0ca00682504f345 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 9e58a50c059f3760c51ddee16073496c6e1d510a ] + @@ -9 +10,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index a371c2c747..4acaaca9ca 100644 +index 4d126751a2..ea89ce8e05 100644 @@ -24 +25 @@ -@@ -73,7 +73,7 @@ mlx5_auxiliary_get_ifindex(const char *sf_name) +@@ -156,7 +156,7 @@ mlx5_auxiliary_get_ifindex(const char *sf_name) @@ -33 +34 @@ -@@ -87,12 +87,11 @@ mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) +@@ -170,12 +170,11 @@ mlx5_get_ifname(const struct rte_eth_dev *dev, char (*ifname)[MLX5_NAMESIZE]) @@ -48 +49 @@ -@@ -150,10 +149,10 @@ error: +@@ -233,10 +232,10 @@ error: @@ -62 +63 @@ -index 85b3fabaf5..3d87aec5bc 100644 +index 326b7b7329..3aa500e6a4 100644 @@ -65 +66 @@ -@@ -1587,7 +1587,7 @@ err_secondary: +@@ -1546,7 +1546,7 @@ err_secondary: @@ -75 +76 @@ -index 53f0a27445..93e298d648 100644 +index 1b784b109a..a5dde56ed9 100644 @@ -78 +79 @@ -@@ -2348,8 +2348,7 @@ void mlx5_get_mtu_bounds(struct rte_eth_dev *dev, uint16_t *min_mtu, uint16_t *m +@@ -2148,8 +2148,7 @@ void mlx5_get_mtu_bounds(struct rte_eth_dev *dev, uint16_t *min_mtu, uint16_t *m