From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18364470AE for ; Sun, 21 Dec 2025 16:01:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 132E0402E9; Sun, 21 Dec 2025 16:01:31 +0100 (CET) Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010028.outbound.protection.outlook.com [52.101.46.28]) by mails.dpdk.org (Postfix) with ESMTP id 328E54025F for ; Sun, 21 Dec 2025 16:01:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=B6uQuceePRAMxKuhZy9rLsy5kCWpYpEP7vd51jcrngkanu3MtO8xxaKyzd0f8mddlropE1Jv3p4BGI7YrirOy4E4UlVQgCSxPx/IYw/jO+hd79otKAPMPP7szq0wqfkjeiNeBnHFwu+hbWAcuPUFGO1wQT6MANIV3uwFgFoVkYXd42c0iYlt4mbacFu1g0u5incWEDIDg5gL/sZRKDjSiYpRrLAXJVpFWh8uQ9pav3EjGtbnU5N89KmetubY8UY6PDLqdUk7X1cMGNY4rCsZR/Q0k3LKgekBK4wsgbTLIkYrsKqbzKOxgHuJ+BeJ+S4raokunmyKkwInCQCEqODEXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=riNZ6LY3VrNduCdTIYQheVGAwayTjFTixx/3+BDlaWg=; b=LOphuHT8u8Eo9DyoXXIT9YtOfusqXIDAAnlkSQrzHzwAdqzHj8a38AhOczPLC4oJDGOnJHAl5XB4l75TvOKrSfkoIHmLse0wDWKVGwlwOyQYqdsAobO2vdvZun+nUyxrS+sZXm3slUySlPL19u6cLzRZA/KZOipL1VeTekjqaYvxB2UoCfaFmVaMdJVgbRoFpqcWdI/Jw6jZiDqjGmSsV+HCVEUA9n0hsp1vQlhGH18WmgDZW6pztMRjs2j8rWwKl/jLCC8RRw5Izf+K3QoiNrRxuN7Ntw5XFFvD0beRWCrBppKaJv8JqyeG8xHdOgp+uSlTMSUliuFmK18e40nLdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=riNZ6LY3VrNduCdTIYQheVGAwayTjFTixx/3+BDlaWg=; b=GXngYcjusAJTb4SScQWvGY2CtY2RwnjS5guZ69ribDa+qC3S7TZwoUSpK0a6I/nM9YNX64C0u/b+iC7bTodX4mb92zi5hL65bqokowJztGgruHBXriovwiOShK54sg6l713xO5pYcY8R0cOADplOBWD4F+F6Sob6RUzfM7YSpYRVaQtsKTd3xf5pZA18UpX5ZPyFpuhzu/gksgh7I6g36bcz3NRw6tRooue9kY0HLEBRXqLlUof7uuhgysOfLnR5uYyqsmByhEylQxlSe+oasWwXje3zocFGLvlkdPk2pzYf5TvgRzejVZ8NMCfSW3Rqfo5EwJsDv6CQFHiZZR4woA== Received: from DM6PR02CA0042.namprd02.prod.outlook.com (2603:10b6:5:177::19) by IA1PR12MB6481.namprd12.prod.outlook.com (2603:10b6:208:3aa::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.6; Sun, 21 Dec 2025 15:01:25 +0000 Received: from CY4PEPF0000E9D6.namprd05.prod.outlook.com (2603:10b6:5:177:cafe::88) by DM6PR02CA0042.outlook.office365.com (2603:10b6:5:177::19) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.10 via Frontend Transport; Sun, 21 Dec 2025 15:01:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CY4PEPF0000E9D6.mail.protection.outlook.com (10.167.241.69) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:01:25 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:01:17 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:01:16 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 07:01:15 -0800 From: Shani Peretz To: Jacob Keller CC: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/ice/base: fix memory leak in HW profile handling' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:56:24 +0200 Message-ID: <20251221145746.763179-36-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9D6:EE_|IA1PR12MB6481:EE_ X-MS-Office365-Filtering-Correlation-Id: d4160790-939a-4d96-2866-08de40a1cfb4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|36860700013|1800799024|376014|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?9JzgbHhH+Jm6t44gPs4ALHvCrqxdjuqrgrhSwaICpO3oh687vVa2827vsD7k?= =?us-ascii?Q?gVGEHhIomXbeKPav1i4DF7LaCvuufHTySK/80UP26EgS4lov6v94xRRbCKBd?= =?us-ascii?Q?nFNWYucMyWk6VX43XzwAjJAS97cqdwjPuT3WanoeJmLy/81vZrB2kxCX1cGx?= =?us-ascii?Q?ru4nk/m7iM2bKncjU4XKKECFlcCk+eJHi9vZ4bXFgNijYK6OT34Dj7oRR/eN?= =?us-ascii?Q?2FWnfVHKeZa4C9SrUx1c+u6DFpcngkBkXyEPlxDwuEvX4E7gQdO/MkXclF3W?= =?us-ascii?Q?NCeA+KWv/bhTYAZuuZoLHQvLbvk6QpMmcQRH5bBKFZ1fGgm/T/Me0J/VES/T?= =?us-ascii?Q?1jac6vFp0OQxcyqtiXvQc6GxjsUI61cfXVD+rMGe4PDmRG7QYkctCk/mVF9G?= =?us-ascii?Q?hbUQYGMoIWw9U47Gjb3pGVSvm+gCo3JA9BQJVkMO96o2iGGyCRaZYbXOMeHb?= =?us-ascii?Q?WYhv2ibbI5D3NUQ1dj3NX8+FG7IhFmrdIdb+QusJ+gOOamaMSqgPll7K1dRi?= =?us-ascii?Q?6a0zcWq9FNVa+owckBlImoo/W2hz/tZutGnvJYQ1kCuKGj3YyabzeUTJBFFs?= =?us-ascii?Q?5kB39nJTEUtO6cXdUCGKj7tovG+dyaqF2r9Cfbujc6BZDd1H9oNW7lc50jdV?= =?us-ascii?Q?T1D66Q7KDDtWyHPNNkBtgQyQVzttdYv7i9Itnl/Lob4d5iORe+CslnUIX5gZ?= =?us-ascii?Q?7ievC2uaE7BHg7k0YNrNhcHv0tUtq/UakQ2faXax87fp4ElV/g0zFbn8keC0?= =?us-ascii?Q?+P4Uv5jzq6nh6xmAOUwqnRNvD/3nE/fRSitZiHH/MFtscpRJE7oHjFlS5tLc?= =?us-ascii?Q?mWd1Qx22Rn8YharIoXK235J45swFzCqCqcio4E0+qViM9vnVROfNYDnvynsZ?= =?us-ascii?Q?/UWP/d8iYWrO8KjAttNOa6VZUpadA64CG0nouzBI8/yIpkp9rQpqEm2xZE+F?= =?us-ascii?Q?7S1r+gDqbq9G9v/CUI50fPgzi544l0Ofwc9HHZTkS4rZop6rLxc4A5WoJu4W?= =?us-ascii?Q?RS9a1Xn0Y7/rximgUVjXm1JpuLEjnqQBJbw3CqfY7ojdKguspXb9BIbLk5Bv?= =?us-ascii?Q?7njbSgcNrJH+PISMTV//9y5v+rlUUHbPnY52BIHjkktr+WQy0IJW2wUx88XU?= =?us-ascii?Q?C9ulC4mLcw7E6+d47TJdpH00DHAxBiQScEFpTPHOIF59mziJ0XJbg9CZJeyD?= =?us-ascii?Q?DlCpGzOPX79MiapMxDDCpCRcs01EwWAbBx/PdU8jWieyUFOM5zyG16f4lCqB?= =?us-ascii?Q?kKtX8ngy8fusyCrivAN1vx5h/IRmfaOY9ihYZ/L4chBqb2Zj9HZ/ZOYLbaSG?= =?us-ascii?Q?ojnO2srjC0mXWWw444JhtWiVYB8zfQWbxhSXHVMg62rv4fb4dX7fFrKYH7Lk?= =?us-ascii?Q?8M7fJfNHezPKrDLV0F0mIPICyloytkTXB0GdF6FHeswKVaQFBaGY3wjq8p73?= =?us-ascii?Q?RIq58NC0a3E+Kk8Jf/qB7Lr/Wne3Hc19qYAG+FsiAuGMiS5lpA3LYbrP5yVz?= =?us-ascii?Q?SnrAWObArz+CWxKA4rPwt6nXqGmoJsFPWryVxeAW4R9aJ/BF0L0aurRLT5+P?= =?us-ascii?Q?UvNBMDiRquTBg9nV9YwzI9nWkJVX4IPLcOSIHsuh?= X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(36860700013)(1800799024)(376014)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:01:25.1282 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4160790-939a-4d96-2866-08de40a1cfb4 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9D6.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6481 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/1c8eb98cc4c9f4b806e43d418c3b152072a22e34 Thanks. Shani --- >From 1c8eb98cc4c9f4b806e43d418c3b152072a22e34 Mon Sep 17 00:00:00 2001 From: Jacob Keller Date: Tue, 2 Sep 2025 18:26:53 +0100 Subject: [PATCH] net/ice/base: fix memory leak in HW profile handling [ upstream commit bce22ae3a0e61134b5fd19498bd849d1693dadb4 ] The ice_flow_set_hw_prof() function allocates a params structure with ice_malloc. It uses this structure to hold some data temporarily while processing the hardware profile to set. Static analysis indicated that this memory is not released. Fix this function to free the memory upon exit. Fixes: 8ebb93942b2c ("net/ice/base: add function to set HW profile for raw flow") Signed-off-by: Jacob Keller Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/ice/base/ice_flow.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c index 7f1490de50..a48c988e99 100644 --- a/drivers/net/ice/base/ice_flow.c +++ b/drivers/net/ice/base/ice_flow.c @@ -2629,10 +2629,6 @@ ice_flow_set_hw_prof(struct ice_hw *hw, u16 dest_vsi_handle, status = ice_flow_assoc_hw_prof(hw, blk, dest_vsi_handle, fdir_vsi_handle, id); - if (status) - goto free_params; - - return ICE_SUCCESS; free_params: ice_free(hw, params); -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:19.194553950 +0200 +++ 0036-net-ice-base-fix-memory-leak-in-HW-profile-handling.patch 2025-12-21 16:54:16.992034000 +0200 @@ -1 +1 @@ -From bce22ae3a0e61134b5fd19498bd849d1693dadb4 Mon Sep 17 00:00:00 2001 +From 1c8eb98cc4c9f4b806e43d418c3b152072a22e34 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit bce22ae3a0e61134b5fd19498bd849d1693dadb4 ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ - drivers/net/intel/ice/base/ice_flow.c | 4 ---- + drivers/net/ice/base/ice_flow.c | 4 ---- @@ -23,5 +24,5 @@ -diff --git a/drivers/net/intel/ice/base/ice_flow.c b/drivers/net/intel/ice/base/ice_flow.c -index cdc9ee26c5..7b0ecd54df 100644 ---- a/drivers/net/intel/ice/base/ice_flow.c -+++ b/drivers/net/intel/ice/base/ice_flow.c -@@ -2632,10 +2632,6 @@ ice_flow_set_hw_prof(struct ice_hw *hw, u16 dest_vsi_handle, +diff --git a/drivers/net/ice/base/ice_flow.c b/drivers/net/ice/base/ice_flow.c +index 7f1490de50..a48c988e99 100644 +--- a/drivers/net/ice/base/ice_flow.c ++++ b/drivers/net/ice/base/ice_flow.c +@@ -2629,10 +2629,6 @@ ice_flow_set_hw_prof(struct ice_hw *hw, u16 dest_vsi_handle, @@ -34 +35 @@ -- return 0; +- return ICE_SUCCESS;