From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37ABD470AE for ; Sun, 21 Dec 2025 16:01:32 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F58B4042C; Sun, 21 Dec 2025 16:01:32 +0100 (CET) Received: from MW6PR02CU001.outbound.protection.outlook.com (mail-westus2azon11012037.outbound.protection.outlook.com [52.101.48.37]) by mails.dpdk.org (Postfix) with ESMTP id F187E4025F for ; Sun, 21 Dec 2025 16:01:30 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=bzcnHt4gGwAkjINajAIQq43tK+Kn3D17ajCM6aX7YYMCQvKgqT+hi7twVNVbLqNvMHG/+mQt7Z8pX6zc6uNi11V8u68x5T7Q5/hT1EPwgjdHac8WG4OcyBSijvA6jX6JNQ5lCpTlpNN5IFGQF8T+bpZ+ZdX4feAq0nfTZlYscOrTpusPOIINckzHgAiO/QM2rb5fenfRMH4HlHrWU/0btmjrJYmp2vqdMpDxcxZF8bKaqtYKLQItsw42eE+tPy652d07bOkMarXL/xB6x4q10/QXqDruNSUzcDPtt51p3kzj2d/m7GJVw9waCkFHetBmQ+FcjmMdJq/sTNlw7PbJTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uYMKeFVhrlCRDAQwDXhVQIEMSOjcQjpu0JO+VbG034Y=; b=uTtuQ21nsvV+dUAd27kqHCMR5d+mGoxq/cO25nzwcBOPv5CUGAOdmgofg0wCVjDDLV8E4y+jq74QAK6OZcS++cmGmFg/X+OWtRdHq9zhssza7aFkV1rZQDZ85JYgRxx4iiTuvBCBG8MBe038zGSvnvtM+A6epr+8IWBFSAA0TjzIIfpg2pcPev9B6n8k6Z5BRhVXaDdEaTXJZpEqPzvOWq1sea8sQ3CoEcCDxZmmBHoTzPrthljU23jEBFie8b6umjKj7VEy2D+ldmq55CXxtSQWjwIEMFmfc3/cmJahJxb8wkRWe5yhocU6p21lxyAs0tOUe6h6k+PEIGjGpQxdxA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uYMKeFVhrlCRDAQwDXhVQIEMSOjcQjpu0JO+VbG034Y=; b=WVDL79p1o7ii2EsyPGJEkdR+7KwWgD843+5Wvh2jxjy8L+Z8WvjS3CtED6GWs2uh0DXG2t1YKnb+fzVSwgXR8YjywwD0hhZvkgAdGuk5ioAWgKNbnBdcCNT7BHgknKe29OzAiCpG19QM5qOtzQ21hW/Jvak8Oft9M6qwE0XT7h6Pl5jDAEDZpJcoDoKJGyQtzjfE+2nPc69h9h8NXJttLCS2iuw2yPabURnO+khJMX62XgW4zCNo1Ul9WqBQlPJTWq2/N76TgbKxnBbW30QgxDQjYBlBtbPTjvy210kNcVMPeTMX962H+cVAod/0MIJWa1skXNGP1MjLcY3IotW3KA== Received: from BYAPR03CA0007.namprd03.prod.outlook.com (2603:10b6:a02:a8::20) by CH2PR12MB4279.namprd12.prod.outlook.com (2603:10b6:610:af::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.6; Sun, 21 Dec 2025 15:01:26 +0000 Received: from SJ1PEPF00001CE0.namprd05.prod.outlook.com (2603:10b6:a02:a8:cafe::38) by BYAPR03CA0007.outlook.office365.com (2603:10b6:a02:a8::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.10 via Frontend Transport; Sun, 21 Dec 2025 15:01:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SJ1PEPF00001CE0.mail.protection.outlook.com (10.167.242.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:01:25 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:01:19 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:01:18 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 07:01:17 -0800 From: Shani Peretz To: Pandi Kumar Maharajan CC: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/ice/base: fix memory leak in recipe handling' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:56:25 +0200 Message-ID: <20251221145746.763179-37-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE0:EE_|CH2PR12MB4279:EE_ X-MS-Office365-Filtering-Correlation-Id: 212008f9-ab79-4c52-ff47-08de40a1d025 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024|7053199007|13003099007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?SN+HuI2pCyMsmhQUDeHhffpxPoMrEr7S/M3ljqa1kGi77iHtrJrSTC9uLc6I?= =?us-ascii?Q?xFBIpTLE3vZdMLcnP+nohAwFafsS3Z47F1M2cMcoAqo2u1ti9Q8MG/gNL+VU?= =?us-ascii?Q?aIlIW/l7Amlhyi8zBuJ39aoryofZbbIK8nIATW1yDw3EaFiv1TOHp1DfhH7Q?= =?us-ascii?Q?SUpQEdFgyoQy/ppjFXd54HDMlT5GwPRbt+vGNocEnFA5JQcKvwATMyWImG27?= =?us-ascii?Q?ciDrZ3YfDZH7ld2oassD0SlyWEVGWRnITKaCAsXnLxfo2o5A5U22oSpOf/G9?= =?us-ascii?Q?aV7QomLcevisNPfEJ4nzI5yQKVLtC+Ao2EK769/SgAbtyM904trzoB+qkBWX?= =?us-ascii?Q?EUdVKPiS0IAaDRPDR3KgMiPx8k1OoUHe/n/myAS63YGfQqn+1a3DKoUx9Jus?= =?us-ascii?Q?qHuZ7bOCpM4COL91yMpa/DTgR+7OkK4O4Zq2q3NpPqk9i/G5ECqhcHXSnlCH?= =?us-ascii?Q?r7XTKwXtXqFih71LtlwkOapuZI5cHDAXvhCCPaq8uzXa9N8qdtrEYRuK9ZBl?= =?us-ascii?Q?zCMQvKzJIIvor8SA9VRzvOk6VUSEY7GZ6jVPg+fVrD7IZKpPmlKy33O844rX?= =?us-ascii?Q?5P9dPbhjNUCvbtrZQ9gjH19bPEgBNR3mNafVbhM0L/FydMag9iWq3gy7rC9U?= =?us-ascii?Q?2iqF+K4HA/YWMFDsMxMcD/42P/8Wop11GwDTcYfTpSQcNLz2PgBqo/KCsZ9B?= =?us-ascii?Q?caKFHxSHXq7GsphAWrdll1DnGa9G2PfEImGHBxHGuX5lFTr2zLJHcO21UXM+?= =?us-ascii?Q?ZEqwJjxSTjhjQqqGxDCo0j97z9qK9zXual90NTKNxbh/lqNLpRaHSHxN627f?= =?us-ascii?Q?P6TURngtCANKc5wm5RaA4Aa12u8NaBOdGvcjLGwLOFslpuKTaK003fgAF88D?= =?us-ascii?Q?UWKQ3iraJDnmQjoW+ouy5EjJaDBmELVIK+hYhTb7whvNfSMmzMGBvXQIY4I5?= =?us-ascii?Q?6mpPzwzH/KkUZhD3cnQHq7iXKQpsECl0i/Nra+QYcGlU4RDn9BRLOtEYEP+u?= =?us-ascii?Q?EvvVSNB/RV7A7Nhov7ZgQLFBML9moK08KZUP6bGGcNiCAnkr37o+/78Ps5aD?= =?us-ascii?Q?ENtXzsY/FUtLQkd/OgXn5t64KRW6E1rdN4XzQ2UU4a5sAq9PbdGR/wGWrtJY?= =?us-ascii?Q?dYnXRgVYrksaROCXJmp7pBOn6IRqaQtxqU+KQOwxkXhq3jFQXcsJG+XDHw9+?= =?us-ascii?Q?T3D4ctgjv0DShD2BVmXz/FAcNtQaxyhGf3fFDHTQiYkQm0EwELRg5BRw4LOX?= =?us-ascii?Q?uXqic5148125kbOoQlI+YEHlxaKePDxd3sBojj5lmqyXLdLCU5Gd+0NJdvmx?= =?us-ascii?Q?udWJVdahPWlaTNWRLPAtlVIFYYciR9mZFATsJn5Z6EToUMgUVUMBjbyWVVe/?= =?us-ascii?Q?eqihcBPyiw2WBXypAaUHhlypAyjfDNoKj7PoGvmP+RXoGR/MeVQIbVJqv/s7?= =?us-ascii?Q?uIIjxD3+fKycJJdiheg1pCu9um5sEHSBEy2ENfIUa0ynxU+HG8L5kBsUjSgf?= =?us-ascii?Q?Kj3eJud/xLm364Zx7g15ZJjgw/mWYYPR7KZZ/iW2JzQFA6Hy3s9578/nHJIS?= =?us-ascii?Q?57h6Nh9k8jN8e66mqkLJaaSKNmGuNS+0vvQHGaAC?= X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024)(7053199007)(13003099007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:01:25.8803 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 212008f9-ab79-4c52-ff47-08de40a1d025 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE0.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4279 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/48c44e36814d0b4ad3a5173ebcc78bdd5a9883d0 Thanks. Shani --- >From 48c44e36814d0b4ad3a5173ebcc78bdd5a9883d0 Mon Sep 17 00:00:00 2001 From: Pandi Kumar Maharajan Date: Tue, 2 Sep 2025 18:26:54 +0100 Subject: [PATCH] net/ice/base: fix memory leak in recipe handling [ upstream commit baf3de23be970346378d5159a81782bfb6eb927b ] Advanced filter operations (apply/remove GENEVE/VXLAN filters) trigger the call chain: ice_add_adv_rule()/ice_rem_adv_rule() -> ice_find_recp() -> ice_get_recp_frm_fw(). Each call to ice_get_recp_frm_fw() creates new linked list entries for SW recipe tracking without cleaning up previous entries for the same recipe ID. The linked list then continuously grows with each filter add/remove operation, leading to excessive heap usage over time. Fix the memory leak by adding logic to remove the duplicate entries before adding new ones for the same recipe ID. Fixes: fed0c5ca5f19 ("net/ice/base: support programming a new switch recipe") Signed-off-by: Pandi Kumar Maharajan Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/ice/base/ice_switch.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c index 6321f8a3fc..15247ca2f6 100644 --- a/drivers/net/ice/base/ice_switch.c +++ b/drivers/net/ice/base/ice_switch.c @@ -2435,6 +2435,7 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid, bool *refresh_required) { ice_declare_bitmap(result_bm, ICE_MAX_FV_WORDS); + struct ice_recp_grp_entry *rg, *tmprg_entry; struct ice_aqc_recipe_data_elem *tmp; u16 num_recps = ICE_MAX_NUM_RECIPES; struct ice_prot_lkup_ext *lkup_exts; @@ -2476,6 +2477,15 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid, */ lkup_exts = &recps[rid].lkup_exts; + /* Remove duplicate entries */ + LIST_FOR_EACH_ENTRY_SAFE(rg, tmprg_entry, &recps[rid].rg_list, + ice_recp_grp_entry, l_entry) { + if (rg->rid == rid) { + LIST_DEL(&rg->l_entry); + ice_free(hw, rg); + } + } + for (sub_recps = 0; sub_recps < num_recps; sub_recps++) { struct ice_aqc_recipe_data_elem root_bufs = tmp[sub_recps]; struct ice_recp_grp_entry *rg_entry; -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:19.240805608 +0200 +++ 0037-net-ice-base-fix-memory-leak-in-recipe-handling.patch 2025-12-21 16:54:17.009115000 +0200 @@ -1 +1 @@ -From baf3de23be970346378d5159a81782bfb6eb927b Mon Sep 17 00:00:00 2001 +From 48c44e36814d0b4ad3a5173ebcc78bdd5a9883d0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit baf3de23be970346378d5159a81782bfb6eb927b ] + @@ -18 +19,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ - drivers/net/intel/ice/base/ice_switch.c | 10 ++++++++++ + drivers/net/ice/base/ice_switch.c | 10 ++++++++++ @@ -27,4 +28,4 @@ -diff --git a/drivers/net/intel/ice/base/ice_switch.c b/drivers/net/intel/ice/base/ice_switch.c -index f16bec044c..628473f100 100644 ---- a/drivers/net/intel/ice/base/ice_switch.c -+++ b/drivers/net/intel/ice/base/ice_switch.c +diff --git a/drivers/net/ice/base/ice_switch.c b/drivers/net/ice/base/ice_switch.c +index 6321f8a3fc..15247ca2f6 100644 +--- a/drivers/net/ice/base/ice_switch.c ++++ b/drivers/net/ice/base/ice_switch.c @@ -39 +40 @@ -@@ -2481,6 +2482,15 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid, +@@ -2476,6 +2477,15 @@ ice_get_recp_frm_fw(struct ice_hw *hw, struct ice_sw_recipe *recps, u8 rid,