From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 890D1470AE for ; Sun, 21 Dec 2025 16:01:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82D304025F; Sun, 21 Dec 2025 16:01:37 +0100 (CET) Received: from SN4PR2101CU001.outbound.protection.outlook.com (mail-southcentralusazon11012071.outbound.protection.outlook.com [40.93.195.71]) by mails.dpdk.org (Postfix) with ESMTP id 8700140430 for ; Sun, 21 Dec 2025 16:01:35 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k2ggZS02YmGD6rwSxsBUTXxLB69YSR8V1F0IOheUxxQ7xBkRAaDayuIM6ue553QqSlMh4LuED23Jeonsn3FUWUyq0neIHNL89f9xC/Pk5Mu3lIYjdfq+/jM8ej5vEpqg6xOCCrjpLvEc2KqXUJp0oev1vIG8wt42Yoq8y0x0bW23Q+MMrk3Ms8/HZLFDVaEKVNwfh+UOi4g4RrAJmShgIhIGOGQ5yVijUODXN1sPTfDD4QvtE8/3HK9AmrrREkIUdrqJC6Zkf7ByKu+f4ayyRybYlsMKDgjaTqLWvnINdxMTSG4kKQL7jmFnNT1fe9Tum4k4P9WQZhQ98GV5hEOeDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Kcm68yiJCUmBNUF1cTK78qRKyiIZnEyQrJEBLZs7Tt8=; b=VF/YItCduoa1sZ/5HLVtSAp174vqaphihb2f3kK7jO/2mXBbCwFVwib8APe+p9lWpik87xwycr/Sv1Jh98nFKxJlxDz+1MxucBq/yXjEPA+Six1ezEp64L9OEu9PhhuYVrb37s/LwmEggIkG9v1gguCZezDXq831pSRA3HayreWuNHWtoYYoc2VdRPtefC7km2h/7oZMOpCdfNA4b+51jOMX0Nv4hXF1oUsF+hV1Kqeln0ofHEseWJjeE+3QD8nEzNzFRxAVGCinSLB01KF9so9DsmgWVk7FanQksGk70EJ0fYmGCmIECdFDlOfzBEMQj/TdLx3suH36J649fOSk4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Kcm68yiJCUmBNUF1cTK78qRKyiIZnEyQrJEBLZs7Tt8=; b=trORofOU6YlWgsjCtTSPEPJWlpXvQnlgNpQggTP1zMefNHI+dxBVCB24MO2oHA4XlXZ5Q5wIHJ2YsI1AzNekbs8Vu5D6a+9iM0G4brrpeRtqKmb0iI54l0DBbNDmiaJWbhw9hcvUn1pT3MXtdgpzqcb6XiKIU//qXqZ3+WryLG/pzjkEFzLwTmtKbfqdK+6qyw88DwC5/uT54W6637IPfSWbeWKzWxQge6x4e1DlTBc6uHg12uc+Df8n4kXMD2ClxEyIzl0hGItrriIpLn2pAttMtp7p574JWrKSBiLr96eOZokc1XoKfW60A+OQX1GC/T1hF9IHSH6vg1t1rgz8zQ== Received: from PH7P220CA0039.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:32b::26) by CH1PPF711010B62.namprd12.prod.outlook.com (2603:10b6:61f:fc00::614) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.10; Sun, 21 Dec 2025 15:01:29 +0000 Received: from CY4PEPF0000E9DB.namprd05.prod.outlook.com (2603:10b6:510:32b:cafe::7e) by PH7P220CA0039.outlook.office365.com (2603:10b6:510:32b::26) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.11 via Frontend Transport; Sun, 21 Dec 2025 15:01:22 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by CY4PEPF0000E9DB.mail.protection.outlook.com (10.167.241.74) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:01:28 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:01:24 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:01:23 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 07:01:22 -0800 From: Shani Peretz To: Yang Ming CC: Anatoly Burakov , dpdk stable Subject: patch 'eal: fix MP socket cleanup' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:56:28 +0200 Message-ID: <20251221145746.763179-40-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY4PEPF0000E9DB:EE_|CH1PPF711010B62:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e536960-f9aa-4693-0232-08de40a1d1f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|82310400026|36860700013|376014|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?hOhp9bdWDI1jqPsdU5Suzg7tSu1KvPHZboVdJyJjzvjTDwjsCxfAUDG4y46e?= =?us-ascii?Q?od50jVpbPj8do9yOY4AJGE03rcqeb3VNSeLcKsmiI9z8m5LW71WgKp65qC/6?= =?us-ascii?Q?Ok7GKfu6k9cFkPqtkA/CJDKPyzVXgnb0Sl9ki6f2R4HwnoDpm7e/1/CpGcF8?= =?us-ascii?Q?9XK1NYU4tNfDC87qoFvuJWNKZfcyZz3ZAwBqp4+9KxSdItUudmnBBuI3ylSP?= =?us-ascii?Q?iw8ifRwtGTtk0VAHMv0PSQ6gjKh8mkfvRpitXA1h2EQhV+0b6iLx0dwsI7xd?= =?us-ascii?Q?oBjWveFpCMYT4CgVlK/cfDGv2BPxVN3Bv5eA8qaCkJGlC+xDTn03UoMKL+pX?= =?us-ascii?Q?HduegM/k1/Xqxb7pdBtCxzL3xJi8g4krx/VDxn64gAG92Zw8lGjafaf3UU6y?= =?us-ascii?Q?/ELsuQPMfCDGx0B6VYayigGunsbtI9Ra2gN5QK/Casxa6l0Nk/wQl0U2gRJf?= =?us-ascii?Q?9lL42CmB2pMhxu1pWeS4Tf/vwFkGOqmGeV03A93mItjjO7WwYya/xgIP81i3?= =?us-ascii?Q?IT0nKPQg5lLg+NmAB2qDn13cYCfXttlbF9S6YTHKz+DwPi/yqSqC7JE9jnJn?= =?us-ascii?Q?STDRfacGM1AgOZsLb/W6oGuN9Sc5mmmJffw6cWDCvZNvcwUQdIi9zrEYc8/G?= =?us-ascii?Q?fi45v7CICnR1DeexdYkKS1cS2JdUvTePuzjk58fsfOsj1+6KOvHLctAZ9ITZ?= =?us-ascii?Q?gJ947r1/XDl+Sw7dMdbbEkRfAhWJiPkja4cqPS7eJaUmrJyg/kGMwOCLNeU2?= =?us-ascii?Q?qOChW85yYZAptxDgiNP5Z1JQqaz9S1IuOUjiDmcdeEQqH9tEnmmDCYX5tMYK?= =?us-ascii?Q?nsNETZg+WzIkigeus0wjx32Yg14i2u3ClXQtsqup/zTmmFafChSbICBLg6Gb?= =?us-ascii?Q?a1ivJNVeWlbSm7zO1/kxB0xwqqGm8aM5JUJgw3aUBRtN6xTOYJTuuml2SUoV?= =?us-ascii?Q?pYlIFjBBDQ+ZFxRgMF9MJy4ChovR3CTBOlvNAh1ne+Pt8a/NfLuySJbBLMFd?= =?us-ascii?Q?SGB4pwUmtJkVpAFzEqERUhyWkgYhhV/mnlTQckxLM3fTevA8kDoSkQnqSuh6?= =?us-ascii?Q?38kLpavg134izEwAFc6zAQj4vdzSuHvQB1h4X69YpAduU051nbeuCWL9KAwH?= =?us-ascii?Q?n+7lOUajt7Qi7jL0G4m62/gk9meS1Md/Pb/1fYPh1i/ESbPbufcx5uIQKWc6?= =?us-ascii?Q?LQsdOlPzPNWy/1xQ8IbzPni0gk8r5ptUfSqHz69JVCMVRvkrSS7DRYrLq4AA?= =?us-ascii?Q?jaoqjxoWK5DQL4x5A26U7p9AVXkYLweSpO9HFEbyZwFtYbzGvin0x/Bj0DRr?= =?us-ascii?Q?pbNme+4A+X0Tu2DpiFrp8Gq9GVvUGqd8o5GEl0hy8ID4+ozAfd9jXhPLLzLV?= =?us-ascii?Q?zHQfxeeAMeWN35E2opljA61YNLJlkDp17ZFekq9x2rUV41nDGOBLltwdmcjr?= =?us-ascii?Q?UozM08P52Bj0XihO24kMxSS3Mbb7AZCt6p/8qJnKbLHBw1AGdVqv5rA+TWp8?= =?us-ascii?Q?MZWyWPkG2k/bp2jZPfhPXXGVa5O9gSrlNJhIEYCw35lBvWJfuXCLOgitp13q?= =?us-ascii?Q?dnELprc7zC+b+sgc4OAnNHfEgRQqz0vvBvIjaKCH?= X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(82310400026)(36860700013)(376014)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:01:28.8707 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1e536960-f9aa-4693-0232-08de40a1d1f6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CY4PEPF0000E9DB.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH1PPF711010B62 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/40de88cf00787ef220b2be188ad9f78be26c55ed Thanks. Shani --- >From 40de88cf00787ef220b2be188ad9f78be26c55ed Mon Sep 17 00:00:00 2001 From: Yang Ming Date: Sat, 19 Jul 2025 23:32:25 +0800 Subject: [PATCH] eal: fix MP socket cleanup [ upstream commit 4bc53f8f0d64ceba6c4077aa31229f1e38e0d30f ] The secondary process should not close socket file for MP channel before performing MP request synchronization. This prevents error logs when the secondary process exits without any operation on the crypto device while the primary process starts the device. Case situation: eal_bus_cleanup has been added in rte_eal_cleanup. But for the secondary process, rte_eal_cleanup firstly performs rte_mp_channel_cleanup, which closes socket file for the MP channel, making mp_fd invalid. Subsequently, eal_bus_cleanup triggers vdev_cleanup, which calls mp_request_sync to send a message via the MP channel. Since mp_fd is invalid, error logs occur. Error logs occur as below when the secondary process exit: EAL: failed to send to (/tmp/dpdk/l2hicu/mp_socket) due to Bad file descriptor EAL: Fail to send request /tmp/dpdk/l2hicu/mp_socket: ipsec_mb_mp_msg USER1: Create MR request to primary process failed. Function call trace: 1. rte_eal_cleanup->rte_mp_channel_cleanup->close_socket_fd 2. rte_eal_cleanup->eal_bus_cleanup->vdev_cleanup-> rte_vdev_driver->ipsec_mb_remove->ipsec_mb_qp_release-> ipsec_mb_secondary_qp_op->rte_mp_request_sync->mp_request_sync-> send_msg->sendmsg(mp_fd, &msgh, 0); Fixes: 1cab1a40ea9b ("bus: cleanup devices on shutdown") Signed-off-by: Yang Ming Acked-by: Anatoly Burakov --- lib/eal/freebsd/eal.c | 2 +- lib/eal/linux/eal.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eal/freebsd/eal.c b/lib/eal/freebsd/eal.c index bf9ff1d5cc..2c9eb3d10e 100644 --- a/lib/eal/freebsd/eal.c +++ b/lib/eal/freebsd/eal.c @@ -929,8 +929,8 @@ rte_eal_cleanup(void) struct internal_config *internal_conf = eal_get_internal_configuration(); rte_service_finalize(); - rte_mp_channel_cleanup(); eal_bus_cleanup(); + rte_mp_channel_cleanup(); rte_eal_alarm_cleanup(); rte_trace_save(); eal_trace_fini(); diff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c index b132ebad51..07a5a93afa 100644 --- a/lib/eal/linux/eal.c +++ b/lib/eal/linux/eal.c @@ -1369,11 +1369,11 @@ rte_eal_cleanup(void) rte_memseg_walk(mark_freeable, NULL); rte_service_finalize(); + eal_bus_cleanup(); #ifdef VFIO_PRESENT vfio_mp_sync_cleanup(); #endif rte_mp_channel_cleanup(); - eal_bus_cleanup(); rte_eal_alarm_cleanup(); rte_trace_save(); eal_trace_fini(); -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:19.370557815 +0200 +++ 0040-eal-fix-MP-socket-cleanup.patch 2025-12-21 16:54:17.039085000 +0200 @@ -1 +1 @@ -From 4bc53f8f0d64ceba6c4077aa31229f1e38e0d30f Mon Sep 17 00:00:00 2001 +From 40de88cf00787ef220b2be188ad9f78be26c55ed Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4bc53f8f0d64ceba6c4077aa31229f1e38e0d30f ] + @@ -36 +37,0 @@ -Cc: stable@dpdk.org @@ -46 +47 @@ -index 0f957919d3..1804b4cfd2 100644 +index bf9ff1d5cc..2c9eb3d10e 100644 @@ -49 +50 @@ -@@ -909,8 +909,8 @@ rte_eal_cleanup(void) +@@ -929,8 +929,8 @@ rte_eal_cleanup(void) @@ -60 +61 @@ -index 3a0c9c9db6..caf22033d0 100644 +index b132ebad51..07a5a93afa 100644 @@ -63 +64 @@ -@@ -1333,11 +1333,11 @@ rte_eal_cleanup(void) +@@ -1369,11 +1369,11 @@ rte_eal_cleanup(void)