From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01AC4470AE for ; Sun, 21 Dec 2025 16:03:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EFDFA4025F; Sun, 21 Dec 2025 16:03:32 +0100 (CET) Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012028.outbound.protection.outlook.com [40.107.200.28]) by mails.dpdk.org (Postfix) with ESMTP id 0DF564025F for ; Sun, 21 Dec 2025 16:03:31 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=FcsyrdcXp41XRcwIUYGFbSzNW2/GTbE89QmoVLnz7tR+dOiVgWC0RkzzwOMItR8YAN269WqphliB9uyc7vbeaOfgcSkqaVSpjtmdudzyHE/9DJP3gPhRTr4bB8uELchZY6CyZrEoO2xnI8BokNE6rek6U2kwgA/hN9m6lXnGbbZvdAon2Jle12VwGmEMOtNhkIdlkKSaaawkZNYsrnLPWQK8EhfW8xpdBZ8EY4GUKb4Uju2zZgVzhM/oZuKi4VQRFAX+fDqpRScmKLNaElvlTaIQAPkWcUO+DsiSonACw4VoTW/hPWIIrlfkujsemTpl5ZPhBPmP/F/miKeK8nv2Xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=eDdx8V44XnZQS0O5rvvovngDzxHstuzCh4fCI1qSOB0=; b=ATSQahjzb2PTsS7iXKhpFUORBLRo0NLu5ok2bvxvglUG0ZS/njRvucOrxzAm1/ZYus4lqFooXSKtD4Yl8Y/ZFOBW0dk6mX6I2tlF2AVBDfe0Ul+KkEofNndKWD8g9hmE/g8mT7bY29x3sVNyhHImqyASUga5g9nGB2p+/P5FdOFMeZNGEnWbc4od5zsaI2/QQDox0fVcaadtgVeV7vWmt2u+fDTnCtLdQKhcn8nEYRO0zOih9jnhqMgN5PnnsJ0i4iu7CRCu9pP7Z9HhKIRGjoAjWGvVhfG3CnvdRqVRJpVpgxJvHwHgDXsX7dm0y5AJxk0mjymtV8AoaK7U/kwCUg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.233) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=eDdx8V44XnZQS0O5rvvovngDzxHstuzCh4fCI1qSOB0=; b=eM3JLnxxigFTV/p+qWqJ/hCmwnER/xEPF8b0Tg8WoMME3sqPSqH0Fa8GlIhRJowHoIcnKu4eFPXjprhV/enGvfLqVw1jipoZC3WCvelKkS+bDwt4wv9rW/3yY/qQAYK1bt5ZZlDNtJsJ3fZScZ/1KIliBdbi29CrP4vZcT+WfacLpEPmKKQshoT3IQj/UaDarnqSopEWGbfYG3mC9ECHCdtrX2cFb1LV5DLPBPySz9nT5qsUdyozCGYBBkIaiVSHvmfal7HYN45el04kmV7z6uBoU+Vp5lLs77C+0qHQFmhU7meCESodhSuxiL9fqhzkUkzyZ1kMHt5ujvLRhixUlQ== Received: from SJ0PR13CA0198.namprd13.prod.outlook.com (2603:10b6:a03:2c3::23) by IA1PR12MB6306.namprd12.prod.outlook.com (2603:10b6:208:3e6::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.10; Sun, 21 Dec 2025 15:03:27 +0000 Received: from SJ1PEPF00001CDF.namprd05.prod.outlook.com (2603:10b6:a03:2c3:cafe::d9) by SJ0PR13CA0198.outlook.office365.com (2603:10b6:a03:2c3::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9456.8 via Frontend Transport; Sun, 21 Dec 2025 15:03:27 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.233) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.233 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.233; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.233) by SJ1PEPF00001CDF.mail.protection.outlook.com (10.167.242.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:03:27 +0000 Received: from drhqmail203.nvidia.com (10.126.190.182) by mail.nvidia.com (10.127.129.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:03:19 -0800 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail203.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:03:19 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 07:03:18 -0800 From: Shani Peretz To: Anurag Mandal CC: Bruce Richardson , dpdk stable Subject: patch 'net/i40e: fix symmetric Toeplitz hashing for SCTP' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:56:54 +0200 Message-ID: <20251221145746.763179-66-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CDF:EE_|IA1PR12MB6306:EE_ X-MS-Office365-Filtering-Correlation-Id: 83e4f9cf-a150-4f33-b977-08de40a21878 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|1800799024|36860700013|376014|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?bSwsl4R4BaNIn6yXnim1aG/I1KBmAj6ulR6EX0wULSsBFtS4odP+UyXkIbvy?= =?us-ascii?Q?uiKn2Cpl+t5IiP4AN1CXPZv+khbl5ZtRRIoe3jzN8SraFUktZHn7SKRtWC3K?= =?us-ascii?Q?5Zxm1QD0gdg6iJ5jjqToonxGFPKarEYBD+NjASK1W0YS/825lS1cHBO8F5dT?= =?us-ascii?Q?98GbYIGoIhW22SbhpQk5Xps+qa1KvJaBvKiQc7zaeth6Y4nCCK2on+yb02er?= =?us-ascii?Q?+WG/oRvdB1kCPsbb4Jmdum4jqCcRpMxmOf7+sqJVMjW1o/k6vb3zvuxf6VyN?= =?us-ascii?Q?WPJ5R1nq2pV9P6b/Lzrr6JZD9kdZ+be2LJ8GkflD7L+EPYPIgkUwsfvSndBx?= =?us-ascii?Q?yKds0qNzTJEKVM6qIwCcLpPAMDHOb+hbg8gQhE+NgpZKyANHWKWDiRp+PYyi?= =?us-ascii?Q?3CrAm95cRmo/AKmKMiHv8WG25PqxxZYLGXPWWipjHgCZb6ZnPGDLe84yidTD?= =?us-ascii?Q?XvFf7qphEqcF2rtZJYeCtfC8/4cJhmyTBFy9JrP4bC1AVL0jfqsR4ztfXB4w?= =?us-ascii?Q?6oNnMr9wFfZoQwupgv/h9U9+kbMm7VQVlGzniBBp0TH9oRR9xKutWlautne3?= =?us-ascii?Q?YZtInI1/BgmQcwF0J5g6R4qOxgAs1uASic2DP4lxSqQupcoBmMQVZXQJ6ana?= =?us-ascii?Q?g/MhSi+RDPl6EtwESX8C+vyugTMUfHEtCxSSPpEUKBdU69Anl/ACrvaGfQ2x?= =?us-ascii?Q?6BXK72uOr4AsGVbCo1QWptykCpL3+MFq/vBiPM7pV15NAwdGpGCkQILYBQTM?= =?us-ascii?Q?bIQSpyy+IeP3rxnbzA0kpNk+dRt8OiOptIDXUf/hjv8cxmQQCsyr+VpJq5oc?= =?us-ascii?Q?Z05e+uSBjv/XCUQ+lrqsh6TKM+lKqjBqq+8HSV8MMjJ9BmA5nIg1c+gng9Tt?= =?us-ascii?Q?RYkJ9kIhYXiZ0LCBfkAo0B07uh1l2+NcO4+adGiNEPLzKUt4Sqc3a47sFglU?= =?us-ascii?Q?56m/ikTAcMIM5l2S9y4jmzKfhTBQze2RC1RY1vdzLtOWTSoFmo5+rc0C0GUC?= =?us-ascii?Q?Pw/axr4qrof+Q1Xlg9UkgAqrI3C75m1447Pq1qJuCg46MaxYcD7tWlc4Z9xQ?= =?us-ascii?Q?/KtWzRq/TPYFXqtm5YNx0iLUUvnoicAdfnuLravU3mbCTqFGJHLKnlUFAwj8?= =?us-ascii?Q?uVVziMO3bromkVmYPjLAQlJB58KxZMcFq/vX8afxazuoAsnOrNFl2b4gfe4L?= =?us-ascii?Q?tfYic+nIgfZNJTjBunO+W6q3DNVtwTdOmLtZR5oewE/iUnb72q4NOxTg2bxX?= =?us-ascii?Q?CS4EFoi5xeFjcrGyBDKT5SoYe1Wdz1U62HIeOLjSnbXEz3+VJdx6iK5Btisr?= =?us-ascii?Q?GU5olHGrbQdATrEwAyNPbDnT07diW193Fl1LJr769U10+5Y3YOF7+i1z/EHA?= =?us-ascii?Q?GNia/Ow1ire25NMRz/GocRRCH9OYL5AN5g2YZJ1a6Pi4aQCZM/YLbDDOiotu?= =?us-ascii?Q?DyeAGASaesZQC4sx2G/ddThs6YLh2xIJpUw/Qb56m9V6KcrgZItDYqpB4A2O?= =?us-ascii?Q?5DIIrUI2vx+rSX0EPOGHq0qtNxFVYyEz0I4SgzvzhhgKx5txQL3ut7FvSOY5?= =?us-ascii?Q?Md7gApkuRfG3QH1hf20BakJuMy3/u+O9jgvCWuog?= X-Forefront-Antispam-Report: CIP:216.228.118.233; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(1800799024)(36860700013)(376014)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:03:27.2487 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 83e4f9cf-a150-4f33-b977-08de40a21878 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.233]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CDF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6306 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/a9367ac8f0ca5875f4c95a4468c2d2cb8a168695 Thanks. Shani --- >From a9367ac8f0ca5875f4c95a4468c2d2cb8a168695 Mon Sep 17 00:00:00 2001 From: Anurag Mandal Date: Wed, 15 Oct 2025 23:41:50 +0530 Subject: [PATCH] net/i40e: fix symmetric Toeplitz hashing for SCTP [ upstream commit 09937a3646f83ffe9d0d27896066c3f3f6e4ee0c ] When symmetric toeplitz is configured for SCTP, packets belonging to the same SCTP session are getting distributed to multiple queues due to improper hash computation. Removed SCTP Verification Tag from hash computation of symmetric toeplitz as it changes for same SCTP session. Tested the following with the fix & enabling symmetric toeplitz for SCTP: 1. Packets belonging to the same SCTP session getting into the same queue. 2. Packets belonging to the different SCTP sessions getting distributed to multiple queues. Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") Signed-off-by: Anurag Mandal Acked-by: Bruce Richardson --- .mailmap | 1 + drivers/net/i40e/i40e_hash.c | 16 ++++++++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index be1dcd0a64..4e0f227d0d 100644 --- a/.mailmap +++ b/.mailmap @@ -126,6 +126,7 @@ Anthony Fee Antonio Fischetti Anup Prabhu Anupam Kapoor +Anurag Mandal Apeksha Gupta Archana Muniganti Archit Pandey diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c index 02e1457d80..3149682197 100644 --- a/drivers/net/i40e/i40e_hash.c +++ b/drivers/net/i40e/i40e_hash.c @@ -561,7 +561,7 @@ i40e_hash_get_pattern_pctypes(const struct rte_eth_dev *dev, } static uint64_t -i40e_hash_get_inset(uint64_t rss_types) +i40e_hash_get_inset(uint64_t rss_types, bool symmetric_enable) { uint64_t mask, inset = 0; int i; @@ -608,6 +608,17 @@ i40e_hash_get_inset(uint64_t rss_types) I40E_INSET_IPV4_SRC | I40E_INSET_IPV6_SRC); } + /* SCTP Verification Tag is not required in hash computation for SYMMETRIC_TOEPLITZ */ + if (symmetric_enable) { + mask = rss_types & RTE_ETH_RSS_NONFRAG_IPV4_SCTP; + if (mask == RTE_ETH_RSS_NONFRAG_IPV4_SCTP) + inset &= ~I40E_INSET_SCTP_VT; + + mask = rss_types & RTE_ETH_RSS_NONFRAG_IPV6_SCTP; + if (mask == RTE_ETH_RSS_NONFRAG_IPV6_SCTP) + inset &= ~I40E_INSET_SCTP_VT; + } + return inset; } @@ -1113,6 +1124,7 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev, RTE_FLOW_ERROR_TYPE_ACTION_CONF, NULL, "RSS Queues not supported when pattern specified"); + rss_conf->symmetric_enable = false; /* by default, symmetric is disabled */ switch (rss_act->func) { case RTE_ETH_HASH_FUNCTION_SYMMETRIC_TOEPLITZ: @@ -1140,7 +1152,7 @@ i40e_hash_parse_pattern_act(const struct rte_eth_dev *dev, rss_conf->conf.func = rss_act->func; rss_conf->conf.types = rss_act->types; - rss_conf->inset = i40e_hash_get_inset(rss_act->types); + rss_conf->inset = i40e_hash_get_inset(rss_act->types, rss_conf->symmetric_enable); return i40e_hash_get_pattern_pctypes(dev, pattern, rss_act, rss_conf, error); -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:20.514754589 +0200 +++ 0066-net-i40e-fix-symmetric-Toeplitz-hashing-for-SCTP.patch 2025-12-21 16:54:17.204124000 +0200 @@ -1 +1 @@ -From 09937a3646f83ffe9d0d27896066c3f3f6e4ee0c Mon Sep 17 00:00:00 2001 +From a9367ac8f0ca5875f4c95a4468c2d2cb8a168695 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 09937a3646f83ffe9d0d27896066c3f3f6e4ee0c ] + @@ -21 +22,0 @@ -Cc: stable@dpdk.org @@ -26,2 +27,2 @@ - .mailmap | 1 + - drivers/net/intel/i40e/i40e_hash.c | 16 ++++++++++++++-- + .mailmap | 1 + + drivers/net/i40e/i40e_hash.c | 16 ++++++++++++++-- @@ -31 +32 @@ -index c14288e1c7..adce7ee286 100644 +index be1dcd0a64..4e0f227d0d 100644 @@ -34 +35 @@ -@@ -136,6 +136,7 @@ Anthony Harivel +@@ -126,6 +126,7 @@ Anthony Fee @@ -42 +43 @@ -diff --git a/drivers/net/intel/i40e/i40e_hash.c b/drivers/net/intel/i40e/i40e_hash.c +diff --git a/drivers/net/i40e/i40e_hash.c b/drivers/net/i40e/i40e_hash.c @@ -44,2 +45,2 @@ ---- a/drivers/net/intel/i40e/i40e_hash.c -+++ b/drivers/net/intel/i40e/i40e_hash.c +--- a/drivers/net/i40e/i40e_hash.c ++++ b/drivers/net/i40e/i40e_hash.c