From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85CE2470AE for ; Sun, 21 Dec 2025 16:04:22 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F18E40616; Sun, 21 Dec 2025 16:04:22 +0100 (CET) Received: from CH5PR02CU005.outbound.protection.outlook.com (mail-northcentralusazon11012055.outbound.protection.outlook.com [40.107.200.55]) by mails.dpdk.org (Postfix) with ESMTP id 66D0B40616 for ; Sun, 21 Dec 2025 16:04:21 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=IKW1cNlDDg/jt7ys721rfWmob4+hUOIUaOOkk6PlwM4yj/P/pR8t2y81RmHwqn6evmKfRZB740U0iNnzhTMgy57qAPLivJ0mAMXAy6n9bv9pcfsDKWRDl8Y+Ai9CelSfnfkHFnDbj+BPWoZuEUoPxngsrqssqP3UwMTJ3jueULhZXvonXFEkeyQgpNb2CJsIlGb1JYZT/NV+Jig1Z0NteTtcyVXjfLm/seDfZjiBN6nJGejV3NluT6v2UdolO4i1E2MqdswM2A4q/VH7jl2Psviyg0kJAQubuhnQgKT4eLIVOdZdK4nLdqnjLfi88CBE1PUceDKM3Nc3OlpHoU29ow== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=o/w6EtP5qwRENB4jsUAIcnrEUFNuRNS6/jsnr1mUl7s=; b=ckYhGiGg/8ApNd2HleZP8f36UKji3ZNbRuZLtv3+qjGR44oTf8elAxb7Ppp6qvrzXsXQ9MjlvA31CHAGXBDg9Rv20KaYX4U/9HE0rse1Q1oAcGxSdSBJ1lUzjwQCERpQShPSgYSBtpbSr4X1e0mloV3ewWE+TE68KeOaS54xevEt9N5IcOYfqUpG+vhTEmhz0ocdNPBzOiJO/Y2GqjmvWnZlJLYMS8ByOfQKVo5yrtGrOWzHZEaX8YvJxsPgsn9Bf2pPYRJM1uSNZVqUQcY9sg6DoNwh9jTnKXvtnOMEsq8QPgaatUsjW5mXnD2dExoz1o+lbp9TbCPMMMghi1OdHg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=i2i-systems.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=o/w6EtP5qwRENB4jsUAIcnrEUFNuRNS6/jsnr1mUl7s=; b=YPHr6bvliFEyxG2qE5v1tp5hll+rQHqOqu1ePbh/e5Qg5QgyE0LBgyuadIDhKMsXUmSp6yI2pWCeYrYXZeRKP4Qfzr2Yhtqy0xuMNGuBPyDx/BKwGeB6d88Upc5t7fEj3P42SMHadAY20qj4g4fT82tgHPGufe96eLk1PWDasR4SDmXMfltsqx2jOsn3mJAl1MfcvmBUPM+rnZdOS12ZgPI4m05X6irBEWc4WBgJ6kPCmo8bTcWjLfwXkG4JKTNkh4C6r8rdUwXfHC9no74IBEpw3HvjCspcKMxrg9VsJGhXV+P0hSQczXGIEGqCZgwe9uNaZcpy8mSMZQ2NOAx1jA== Received: from SJ0PR03CA0173.namprd03.prod.outlook.com (2603:10b6:a03:338::28) by SA0PR12MB7004.namprd12.prod.outlook.com (2603:10b6:806:2c0::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.10; Sun, 21 Dec 2025 15:04:18 +0000 Received: from CO1PEPF000066E6.namprd05.prod.outlook.com (2603:10b6:a03:338:cafe::f9) by SJ0PR03CA0173.outlook.office365.com (2603:10b6:a03:338::28) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.11 via Frontend Transport; Sun, 21 Dec 2025 15:03:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000066E6.mail.protection.outlook.com (10.167.249.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:04:17 +0000 Received: from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:04:00 -0800 Received: from rnnvmail201.nvidia.com (10.129.68.8) by rnnvmail204.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:03:59 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 07:03:59 -0800 From: Shani Peretz To: Kerem Aksu CC: dpdk stable Subject: patch 'net/af_packet: fix crash in secondary process' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:57:04 +0200 Message-ID: <20251221145746.763179-76-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066E6:EE_|SA0PR12MB7004:EE_ X-MS-Office365-Filtering-Correlation-Id: f50c1815-e53f-4edc-6227-08de40a23699 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|36860700013|1800799024|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?U1TEnnl0RQ7ghI8CVoeIicc2ydFiztP/K5QpXVEbOrsX8oVGwPAE8bl+TDl0?= =?us-ascii?Q?UiDAeF3qyaYGd1Y+6efAY+qTEkY08XkTi8LHHlERGRpCKKDWIiXbLPsbVANC?= =?us-ascii?Q?oI3aKe6A0wrG5Qcv+89SaZHJYhBUVNveIk5te96Adjg4lPrIs+C9lYPS5k2t?= =?us-ascii?Q?nOsanlYSxEtnYpo2DYTHfqCZ8IPVjHl+rxWGYIXoFgMgqSbKdkcWGLhEpB1X?= =?us-ascii?Q?wHGYOuNhqZo9909/+KzCppHfvOLXPEOr5RL1+NZzZaUVkq8+0KSlLf9skPdJ?= =?us-ascii?Q?wAmSCC07iMWBP1Uh8qBaYbBmyQlJvYMW5Prv8E1FQ97gISUpOWpHVIa03kOB?= =?us-ascii?Q?CvYxvV+MY8RchsL/z2kfsX2nFn5pEvXYxu4p9iDD/1OLv/jZm7a+GlYc8VJW?= =?us-ascii?Q?+7lHqk82n1CI1g6lq+kMkevWeQ20nMbGbZ7V2I/+DozSPrpu4AJhMw5rkL1l?= =?us-ascii?Q?LPzumByrNgme1r94bSJl+qffZsxNhOoPuvNmf9CvQGfbASfn9XSazQB0ofa3?= =?us-ascii?Q?76iNMoO8QhgtDxRyoa1zY8z6DgfW2so1A+SAkVU/2nweiE4S3ShEmz86LIzG?= =?us-ascii?Q?3Duz9hQAXKRDqROoIevQzwTejdkJpjlLpijTOZ6Z8T+S4/yEzc8YPNOVMi89?= =?us-ascii?Q?efc7plMZVHOlJjyCkKsH1taejK9/kfD+qWigr4vThcsg9BxV9hw2KWrVnNhA?= =?us-ascii?Q?7Vh992SRWQZCCxTKbJN6psHEwdAaZLTLkMJQWlZTdHsXggzzwBWIrmgtjBAi?= =?us-ascii?Q?oc5kyYKmKAkvCr3oYkXMcdeCDdgWfDk5iXDCAQapSyMAIWwceVn0I/2XUFt9?= =?us-ascii?Q?5yi7yGYT5WqrGaclDo3wsAhYXVCMU8MGMe3NUhsIH49YuaNoTN1tMh9F0dA3?= =?us-ascii?Q?TfW9bgjBXZYpB88joMx2aiAPbLzPRlZ2OQXawCpK2Qq6KlHs9jK3FfDmyVa4?= =?us-ascii?Q?FAVefGC6t27snIWmfM2XZcmZNzdVMFRuAMDDHLuHvdiHFofjdNGpyqBI//ID?= =?us-ascii?Q?flT1WCaX3HBcnyixfSu3fAmlUIKffjsqYTD04+a5II+8oi2GmxtOqFeqdsIm?= =?us-ascii?Q?NkMdLlUnLRJoiIgImQhRpAZFLsXGxrTmsNokX/W9k2fRewTNNiOAN2lawxmB?= =?us-ascii?Q?4/I513zAEurFCMbFrFLw4FHwR7QRHahr/bCfnp7sR7SfHQzsqKErJ5G/7rTW?= =?us-ascii?Q?xr54X0cxZfWji6iHLvve7Tm0fi3zOzx9ecwuxdfnKmjV+zmAWQ8nupTiVRTv?= =?us-ascii?Q?AM509ShHxz3TG+mSLNQ6tdTnm35zWuKx/m+6KPdLj2EVKYuYsfYQw9LnuVyB?= =?us-ascii?Q?arfCEMBAio9kzPZ6riClgwpcfPieZY8yvavdQVGW28UJJyaAjUkGMUxrh8yQ?= =?us-ascii?Q?qeWkUc1yLtEkfn7vBfDYhm2+EIalgrXjb4EQSag5KHsjyQejT3/EFly8H3qN?= =?us-ascii?Q?HIpzCcJUTPgs5Sw0d6hVtLHA8b6FB6RTLzYUqfanb8mX0OKrEW1eS4NHSCCC?= =?us-ascii?Q?hTRTbeBNls0mvMKyCeCTFYMOslTTNDxhPeVPvU6/ZbV0ohUY3WpvVyYzY2CZ?= =?us-ascii?Q?mXzfdphTqmfad614MO8zxkgTm6ST/tOP87czCxCG?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(36860700013)(1800799024)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:04:17.7152 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f50c1815-e53f-4edc-6227-08de40a23699 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066E6.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB7004 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/2f6b55f82e4242d6f3232d07cbbb9de0935bd389 Thanks. Shani --- >From 2f6b55f82e4242d6f3232d07cbbb9de0935bd389 Mon Sep 17 00:00:00 2001 From: Kerem Aksu Date: Fri, 12 Sep 2025 14:35:25 +0300 Subject: [PATCH] net/af_packet: fix crash in secondary process [ upstream commit d57124f60ef60b24cd39e895cf6d211b93b897ae ] dumpcap crashes when trying to capture from af_packet devices. This is caused by allocating interface name with strdup (i.e. malloc). Interface name is not accessible from secondary process and causes segmentation fault. Use rte_malloc instead of strdup to fix the issue. Bugzilla ID: 1786 Fixes: 1b93c2aa81b4 ("net/af_packet: add interface name to internals") Signed-off-by: Kerem Aksu --- .mailmap | 1 + drivers/net/af_packet/rte_eth_af_packet.c | 7 ++++--- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/.mailmap b/.mailmap index ce743b9dea..0755666658 100644 --- a/.mailmap +++ b/.mailmap @@ -764,6 +764,7 @@ Kefu Chai Keiichi Watanabe Keith Wiles Kent Wires +Kerem Aksu Keunhong Lee Kevin Laatz Kevin Lampis diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index 0b059bfd0b..6803502c74 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++ b/drivers/net/af_packet/rte_eth_af_packet.c @@ -462,7 +462,7 @@ eth_dev_close(struct rte_eth_dev *dev) rte_free(internals->rx_queue[q].rd); rte_free(internals->tx_queue[q].rd); } - free(internals->if_name); + rte_free(internals->if_name); rte_free(internals->rx_queue); rte_free(internals->tx_queue); @@ -752,9 +752,10 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, PMD_LOG_ERRNO(ERR, "%s: ioctl failed (SIOCGIFINDEX)", name); goto free_internals; } - (*internals)->if_name = strdup(pair->value); + (*internals)->if_name = rte_malloc_socket(name, ifnamelen + 1, 0, numa_node); if ((*internals)->if_name == NULL) goto free_internals; + strlcpy((*internals)->if_name, pair->value, ifnamelen + 1); (*internals)->if_index = ifr.ifr_ifindex; if (ioctl(sockfd, SIOCGIFHWADDR, &ifr) == -1) { @@ -941,7 +942,7 @@ error: free_internals: rte_free((*internals)->rx_queue); rte_free((*internals)->tx_queue); - free((*internals)->if_name); + rte_free((*internals)->if_name); rte_free(*internals); return -1; } -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:20.979849290 +0200 +++ 0076-net-af_packet-fix-crash-in-secondary-process.patch 2025-12-21 16:54:17.321086000 +0200 @@ -1 +1 @@ -From d57124f60ef60b24cd39e895cf6d211b93b897ae Mon Sep 17 00:00:00 2001 +From 2f6b55f82e4242d6f3232d07cbbb9de0935bd389 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d57124f60ef60b24cd39e895cf6d211b93b897ae ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -23 +24 @@ -index ff13bf09fb..ff873856cb 100644 +index ce743b9dea..0755666658 100644 @@ -26 +27 @@ -@@ -830,6 +830,7 @@ Kefu Chai +@@ -764,6 +764,7 @@ Kefu Chai @@ -35 +36 @@ -index 85bc1201b4..de7ff63527 100644 +index 0b059bfd0b..6803502c74 100644 @@ -38 +39 @@ -@@ -525,7 +525,7 @@ eth_dev_close(struct rte_eth_dev *dev) +@@ -462,7 +462,7 @@ eth_dev_close(struct rte_eth_dev *dev) @@ -47 +48 @@ -@@ -875,9 +875,10 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, +@@ -752,9 +752,10 @@ rte_pmd_init_internals(struct rte_vdev_device *dev, @@ -59 +60 @@ -@@ -1063,7 +1064,7 @@ error: +@@ -941,7 +942,7 @@ error: