From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A692470AE for ; Sun, 21 Dec 2025 16:05:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 02C9D402B5; Sun, 21 Dec 2025 16:05:01 +0100 (CET) Received: from DM1PR04CU001.outbound.protection.outlook.com (mail-centralusazon11010028.outbound.protection.outlook.com [52.101.61.28]) by mails.dpdk.org (Postfix) with ESMTP id E91F0402B5 for ; Sun, 21 Dec 2025 16:04:59 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G+uJ+8+xvmw2qIVncsmHVHlCd9VfiWnJN8tgXxyFtHU4QOLskxZWQhLoigKz5i2lyj3Zdu8Vv21CwHl3lMY/cCoJz8kwk6QIA5bueBE5MFqUR1VksaEG1AJs2T/3/8fi0eGxWy4AmrLuV3zn6h4vkbEKr9fHfKRjhGsXiWV8aY/8fElB96ku64CQigVfd5mK5RiNgTigDR3TG1jsIbCjI8NgAW4uoepY+ktBRw62mtj92sCvHIZfxQyPQ/cYCcppCZxgconub4ctTMOEzcvsSfQs7oOYW+fJOWyzDdfMT48l6xjjABk2PHszhREImVU+DA4IxkwdKw/cbqwOFW5LFA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AA5tycYSqNNEeqMnbtz6JKWQBYXIL/sFQmdwtAncmhs=; b=PpHLT8HU3YUV0dXSWxvXq1a7BSUhFbT8CjQflW+UI5xwcpil7UJQqccxeP4zM5VR7e6OeuETZClC+MMGjgWOm1iPP9CP9vU25O65v+0x6k5oOS26hijKbCk5ebUho6buFTDhmnYOW3oq55q9aHopsxJiFJkBxIrfU9ivMSFUwL4ET+Aa6qfbyVLfisMA0EiLWwxt847mE/670BNBtYyfd4Knpovqv9R/JuwjpaN377Z43bC1evH/UXrpzjcYVQ4tHlzwKGvCjwpXfJWT9V9r3ge83mxZ+XlVAk5MlLo+PipMQhUV9bse3Cx4BrDh0iGTmfeEEkoiZZ2ir1xBnZHbpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=nxp.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AA5tycYSqNNEeqMnbtz6JKWQBYXIL/sFQmdwtAncmhs=; b=lZXYTN8bMYdbiYuLe3P8KaySKljTxujSm5NDJ7UbZwtyf5FgIYlaTmc5HfpPaOdowXS4PyAes2IfpVb7xLmP4BDgZegxboR0QIAItwsY1WiD9ADO9Wgv/0lfiuqdkUHkpQTA/rw8lVjpah4umGlz8eFuZ0vHhYegVGlb6uX/UsVMhYn+RHz52IO5w+tT3+NJtoYb0/DoG6u3pAzrrFzSHTyYaKqxDBlrVWUuSURGQZ88gi1GqMjoMPyaEDkHzftNzQrQ/RY3gHfWObO/QWRAVgrGgtzrcPmS8FDjf9+eHBVVLPS1Cha7eHaBo8yrrvCguLXshSPih/YYe76BpEFVgg== Received: from BYAPR11CA0041.namprd11.prod.outlook.com (2603:10b6:a03:80::18) by BY5PR12MB4145.namprd12.prod.outlook.com (2603:10b6:a03:212::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.10; Sun, 21 Dec 2025 15:04:53 +0000 Received: from SJ5PEPF00000203.namprd05.prod.outlook.com (2603:10b6:a03:80:cafe::91) by BYAPR11CA0041.outlook.office365.com (2603:10b6:a03:80::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.11 via Frontend Transport; Sun, 21 Dec 2025 15:04:53 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF00000203.mail.protection.outlook.com (10.167.244.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:04:53 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:04:40 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:04:39 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 07:04:38 -0800 From: Shani Peretz To: Hemant Agrawal CC: Sachin Saxena , dpdk stable Subject: patch 'net/enetfec: fix checksum flag handling and error return' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:57:14 +0200 Message-ID: <20251221145746.763179-86-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000203:EE_|BY5PR12MB4145:EE_ X-MS-Office365-Filtering-Correlation-Id: 8074b915-4d39-4887-41ac-08de40a24c06 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|1800799024|82310400026|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?7hvz+IuFGAj7u/nRiQQbN2/xHSsJyTpEKFokRJWGawDcVQl9KlRbDafNaFoc?= =?us-ascii?Q?nnRwyaxSZKFQetOqIgpuhoU+y83j6Ir3G3FtV7vEwdXrF0ZWaIWpcqT6pzM3?= =?us-ascii?Q?yEmkpk2/MXYHiQDCHL2dAHVcAJSh2FZevMH38JniRdwmKcpbzmqQVMSojqCb?= =?us-ascii?Q?pASDTMdmWdNYsZcGQ4cZ4ypFuLaYBG7XUEUKMGdWiULkEDwKIWSdUbvvLtKX?= =?us-ascii?Q?RCgZscUEzKwrEYZ2xPch3dS8IRZpP+iUgpecTlJygJg87+FMZnjPOhCHgjx0?= =?us-ascii?Q?nq1cHSn8Y8ks+cOuWZwiBhmoEnrv+9Vt1IiV1uWb0rD7aytI5FJpxooAM7Rf?= =?us-ascii?Q?dDtcRia4QwxKWacPnDjfDJdILsXAQev8omkEJ5OzO5G9B43Rf8PiIv9DCZbr?= =?us-ascii?Q?ljo1sVS0A6IT7bwqntp9JK05u1RDMF2+wjzx7A3vaGcblDk8kX9yW2hmPv46?= =?us-ascii?Q?ZHnf0XOdD+31vOOQ9U4KfTCXeIPcrW8TxmWmKfpSVneY0DrqcaSo3Wtyny6w?= =?us-ascii?Q?zLEw21ra534SqLSZIywZDznV9UH4T8BitSKMIT9gDJCckRH1z9mdtiq4shxX?= =?us-ascii?Q?W18ZB1vj3We/lsi5rChfFX/rRugtRgGQ6RRbLOeirV68yYTBr3eXT2eWymGR?= =?us-ascii?Q?X9SULYmojErDZKS328+SioBjgkx2dt9Hxv/lG4I2FPiWf7FHTggQXaxq1OTN?= =?us-ascii?Q?vMcrFfFAvLr7bRZe8G74Cb3yNiaQL+1/jYImOC3+e/I/EtR5tIKqcJ7150cl?= =?us-ascii?Q?ATzebCILRO0vr1tspnWz4API7LXg/xQA1S2nu9FOvvGQjxcUFKFnO+586g3g?= =?us-ascii?Q?TrZSf258IjdthrDdYXuW3pYksX/IbJMbB56aDNq4e70XTuidAMbZm931faZm?= =?us-ascii?Q?2bHGJ0xLH7MEyJFys4l0B8KLcDIZ7adeBrSR/F0WK5TX+F0uB5aPpBHOA+he?= =?us-ascii?Q?adg45ejaoH5uOVEMFK1z8KZnWu5XABEwQ8L5fsdLtY66o6KvioocNs62GB9W?= =?us-ascii?Q?xKLY20czKpQhfUvPYZrrp/DBRuo5GFBIuIcE3MvydIGtdkdPvL9XRxWxG2zQ?= =?us-ascii?Q?qB5njPk9sWwewm1sHQpmeNWaWlZx8jkeZUw3jT7A/iNL0OP68Nz+NhDD9kyI?= =?us-ascii?Q?TMxKfsGeHp6i62a9CiJHqQ4AzEqik/T4nTkIRRIx4LDyZBdynkjVdfAeMxQq?= =?us-ascii?Q?5iyIQyr1GSWlUk8cdP6waAz16Eb/fWEYI6qqgPjQM8yYgLeaOdjbmgde+FKM?= =?us-ascii?Q?J8eIb3Q6z23YBpvPMJb1sHD6basvCsk9KriIFzjgjbfmX1NNN0AxlrO+pUYR?= =?us-ascii?Q?tF2aP6Y1BwimvO6SYY0ACW2ENSN7DGseGUGwCKhEkoZKHc0i0VQW6+QXAIzL?= =?us-ascii?Q?cqwrmKiZD/6jJ6QXPk0EmppgHi1WLVFYniRzdFLTd23rzkHUYbMUcFlAqqgV?= =?us-ascii?Q?cxQBZ6ath+F9aZU8aMQJFt727GBga8CNX9uaDXr5xHlg1XFNp/bOd6Zt4QjD?= =?us-ascii?Q?loqeuZPafb8pxWsepmf1nxYftzu8kbTrOBH7GP98Ekyjuz8n/sAX4dKDinI4?= =?us-ascii?Q?gP2yCOWNPh5xbMl079I=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:04:53.6507 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8074b915-4d39-4887-41ac-08de40a24c06 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000203.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4145 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/071e43f525df7567bfeda3eb15e39d8acec55e6d Thanks. Shani --- >From 071e43f525df7567bfeda3eb15e39d8acec55e6d Mon Sep 17 00:00:00 2001 From: Hemant Agrawal Date: Mon, 6 Oct 2025 13:34:04 +0530 Subject: [PATCH] net/enetfec: fix checksum flag handling and error return [ upstream commit b35089c52802378ed267717f069aa57cb8dce5d2 ] - Corrects the logic for setting RX checksum flags based on error. - Updates TX checksum offload condition to check for TX flags. - Fixes incorrect error return in RX queue setup by replacing `errno` with `-ENOMEM`. Fixes: ecae71571b0d ("net/enetfec: support Rx/Tx") Signed-off-by: Hemant Agrawal Acked-by: Sachin Saxena --- drivers/net/enetfec/enet_rxtx.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/enetfec/enet_rxtx.c b/drivers/net/enetfec/enet_rxtx.c index 0aea8b240d..ea2c28a26b 100644 --- a/drivers/net/enetfec/enet_rxtx.c +++ b/drivers/net/enetfec/enet_rxtx.c @@ -121,10 +121,11 @@ enetfec_recv_pkts(void *rxq1, struct rte_mbuf **rx_pkts, (rxq->fep->flag_csum & RX_FLAG_CSUM_EN)) { if ((rte_read32(&ebdp->bd_esc) & rte_cpu_to_le_32(RX_FLAG_CSUM_ERR)) == 0) { - /* don't check it */ - mbuf->ol_flags = RTE_MBUF_F_RX_IP_CKSUM_BAD; - } else { + /* No checksum error - checksum is good */ mbuf->ol_flags = RTE_MBUF_F_RX_IP_CKSUM_GOOD; + } else { + /* Checksum error detected */ + mbuf->ol_flags = RTE_MBUF_F_RX_IP_CKSUM_BAD; } } @@ -238,7 +239,8 @@ enetfec_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) if (txq->fep->bufdesc_ex) { struct bufdesc_ex *ebdp = (struct bufdesc_ex *)bdp; - if (mbuf->ol_flags == RTE_MBUF_F_RX_IP_CKSUM_GOOD) + if (mbuf->ol_flags & (RTE_MBUF_F_TX_IP_CKSUM | RTE_MBUF_F_TX_TCP_CKSUM | + RTE_MBUF_F_TX_UDP_CKSUM | RTE_MBUF_F_TX_SCTP_CKSUM)) estatus |= TX_BD_PINS | TX_BD_IINS; rte_write32(0, &ebdp->bd_bdu); -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:21.437518910 +0200 +++ 0086-net-enetfec-fix-checksum-flag-handling-and-error-ret.patch 2025-12-21 16:54:17.396079000 +0200 @@ -1 +1 @@ -From b35089c52802378ed267717f069aa57cb8dce5d2 Mon Sep 17 00:00:00 2001 +From 071e43f525df7567bfeda3eb15e39d8acec55e6d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b35089c52802378ed267717f069aa57cb8dce5d2 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org