From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43619470AE for ; Sun, 21 Dec 2025 16:05:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E16B402B5; Sun, 21 Dec 2025 16:05:04 +0100 (CET) Received: from CH1PR05CU001.outbound.protection.outlook.com (mail-northcentralusazon11010047.outbound.protection.outlook.com [52.101.193.47]) by mails.dpdk.org (Postfix) with ESMTP id EA6BD40651 for ; Sun, 21 Dec 2025 16:05:02 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=cKLfV5GlHZ1XyZFuOrpkWPK2TvevOCf7h/0FKEOUcXhirHjdvfVuJAC8CJwYnatvNjb7S21REMSxiq96tL9NGygediBVw/7+g1zoL/BG/05R6GFhhV/j94oyi7+pwZzEOgXlcEn8DV/CEHkrHe66PvSG2GtyIMw7EAQB0eSgThFmeSVzo108wRodpT3a8kyQyvdVqYGAzZEzSROQSWi++XC3zA+gFciXIMQUwcWHwHMzL0llEfHVUI4U5tha6PNfTw/vjHf3EpW0gq5JptvLV2DJpk2PhhnixY4uaa+J3sgNowaHpQR0U2T8SBLlL3XGGFX3b3FjNLpfPv5Gz9PKpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=oe5S2uBw4IgJidl2Hed+wvq/lDxd1h54ZDxbZ1SyHbU=; b=jKsQNWfzCdswBwiB4apyd+w3HCbfeOrmYPu1CGalusaALrl/OuXEDO69rHKAStt7Ja5XIkFxaZxpz6mI4OfIhjNNegF/OW/bjqJnhMVMkwD/68va1IKC5Ut/QwRGCIUYk30gxvVJ7h+oxE/IDziPZCY+0Ldk19rqXk92iscAYSqGwF1VxpJL25HAUiJus0toC9O4bJI41PKdQLlFrlDaCmuoKz6r9BcL5vWUBnwLKyY+qbkiD44N8weC/3WejGSRczWsI75DyViDLV76CSK/r+egtm9YJbWvxUud0fmzKpcg64TjytbZXPf0wLiyqZ2u89pgp6//8YB7xbt/11xReg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=nxp.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oe5S2uBw4IgJidl2Hed+wvq/lDxd1h54ZDxbZ1SyHbU=; b=aogAZadUu0GuUmM/eO/NZZGBfLaWiH1jNXubGnNJBzrEAXuw/OxlrRkf5rwJvnMV30c5FCruKjilQdPtSBdb9ScKPDdW6EYwudfLn/NEeksKBqTiL6jSaVcTS99a5+PkBC2JCSfchxz4a9MstndSSfYWKf1bXPfFUInLbcoBN+jclw0YT2s9sgs3oCGtneWwb0rhcYpSc96v+2dGLWptzuCEWviPfjo6884+r6KjPu9EMDUn2JjJVxQxdPx9NpR0czg6e+VIngplUh7bq/CPIGhpcx0TQbzDDAmwOW89KZExpMwmaN1LudmtLdZVZiAaP+lxuqV8mSROJWiJ7VXRIA== Received: from BYAPR11CA0047.namprd11.prod.outlook.com (2603:10b6:a03:80::24) by IA1PR12MB6233.namprd12.prod.outlook.com (2603:10b6:208:3e7::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.10; Sun, 21 Dec 2025 15:04:56 +0000 Received: from SJ5PEPF00000203.namprd05.prod.outlook.com (2603:10b6:a03:80:cafe::81) by BYAPR11CA0047.outlook.office365.com (2603:10b6:a03:80::24) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.11 via Frontend Transport; Sun, 21 Dec 2025 15:04:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF00000203.mail.protection.outlook.com (10.167.244.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:04:56 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:04:43 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:04:43 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 07:04:42 -0800 From: Shani Peretz To: Hemant Agrawal CC: Sachin Saxena , dpdk stable Subject: patch 'net/enetfec: fix memory leak in Rx buffer cleanup' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:57:16 +0200 Message-ID: <20251221145746.763179-88-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000203:EE_|IA1PR12MB6233:EE_ X-MS-Office365-Filtering-Correlation-Id: 2f42cdc7-9ad4-465e-eff1-08de40a24db1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|82310400026|376014|1800799024|36860700013|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?r5QoJNMVRvL+Ozf/FarszwpR5A81RCPNTYBUMBwsFGhJlV7jLl6Yzn9lEeUL?= =?us-ascii?Q?OzWbdbQ3w4fQ0mbSi5SVofsAXRaaf8dnRyFBwBUIvGTX/DCRrP4uBORaxbKW?= =?us-ascii?Q?j1ZL7zAID74YShQWrcl8/2ffFcQ/qZfSHM2MkcUl3S8IhTO+ilLnpWG1GMeA?= =?us-ascii?Q?Il4SxR/POQy4ieUqsbMlvzjUSs3M+zQoNc8xJdyJ3z38nKh39ojpj2wwEQ31?= =?us-ascii?Q?whG6J8AP7tyOJsD0h31U32pHr+hsaZflosDnUBeuz9BknzTMUCjeOsNsqAL6?= =?us-ascii?Q?wyVw35ExNmkrSCXIeRwJ2sM03AHtm6CiFJC+wdljZ+em0vbYRwyTguIw2UiQ?= =?us-ascii?Q?rXvGJJFsHzU2PLckR+cpL33hn9QdMeZ/ocwlEAkXnD69hWSJsPDNOGOqI9mQ?= =?us-ascii?Q?hJlpoTv89tWHGOUMyOXv+mNvLyXoOlOty9cDS2HjCfFgqCvQZ/JKyp91UJyl?= =?us-ascii?Q?mQIeHUzXx+2nT/789JOs9El23J8urAkW2XDirJlZTYA6nVMC2iBOfbO+c36l?= =?us-ascii?Q?P1WePA7wWVBozKqDyW8BzxLt8AWSFvBhTosOp1/0Yhms+kOUC7RF+SPsmSa7?= =?us-ascii?Q?Juj0LpgyyYm0hF/u1YX1Lzjuc4AkE12/sbSJMC/2TwW/GBHd17MhnWWLVlno?= =?us-ascii?Q?Cz9kQYNLE2FtbtS88bYoLwvJwbrKaGtB7hhX9fcwcgVqPVArJbbqXaX08NDE?= =?us-ascii?Q?lrjlgDGJoCbH6er32nyHLngSwsnuZRlLYLwYbMgMW8oO3+Z2UcsnhvK6m/MY?= =?us-ascii?Q?5INCgUVUt/TYhJBW/qNL5+WOTTPW3RIhTwzNxyZBUFNGvziFKsN8nOIG8BmI?= =?us-ascii?Q?t/qK28uiJX7RDmWtNS1+hwJWHUhFUgmwswHHHrsTt6OXymZQiePOv5WxfJnA?= =?us-ascii?Q?x2Y2fc0Tc7Z0L+rgNtG/UjrIF9DH5t2sY2hnHbqWpB3nW+N06mwBPahmR0wY?= =?us-ascii?Q?uRArjEm7Xo9m6kbZ5NGwS7yY6jQWoZCh6Kv9X1P+8b6K3yJ9QvJtJ70BzYyn?= =?us-ascii?Q?shCigWpEyoqyew/3GZXNn876VF1vUt27DtjHhW/+jntYL9+aW0ZUbQTOQlDr?= =?us-ascii?Q?oVjOZsgvtEc/yFaRiThXhHPKZR9KQLlJrT7pQJ/k875ibpPN+iTyWfPDRt3G?= =?us-ascii?Q?+9myLBBWVDrhna27zGpkI+Pm5AGL+jymkgMiLy5HYXt4IwFwrGN+si7I05W0?= =?us-ascii?Q?/G/PnaKe29mgZs83Mesk863M4W3Ir9l2BX94JqCP2CY1nI+NuS+38a2GyQbk?= =?us-ascii?Q?NgR9rxVyauBz0j82Twonvhk60I3Cs3TQfoSn9gTPoLN8wo24++lJC8FiHlbB?= =?us-ascii?Q?5FiH8Ync6tLo5HEV64XColf7ov9WQyfI/MJ9lC95wzjpE4L8Dge0LZTZ9lyp?= =?us-ascii?Q?pHMvGWTtFxwghD76C/nAsVAFxwSkVPQGghGSzW4FevuXdgf1jbdWzCbqk+4k?= =?us-ascii?Q?GzDN88+865K0Wo9tUdc0NEdo/26S+YOvdpjqr5dgUY40l6Foon5j03CTaZz0?= =?us-ascii?Q?s57wIxNNLjUbopqAIeJwcmIFwWEHH+Tb92hT1CTpgOir9CESIrW/21XwsdXu?= =?us-ascii?Q?FmloHH+gWhXdWVMROA9yquJoiHzauaPQeIEVBLG2?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(82310400026)(376014)(1800799024)(36860700013)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:04:56.4305 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2f42cdc7-9ad4-465e-eff1-08de40a24db1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000203.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6233 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/630bbade65b566d92c2e7d58cfe7288b00d96767 Thanks. Shani --- >From 630bbade65b566d92c2e7d58cfe7288b00d96767 Mon Sep 17 00:00:00 2001 From: Hemant Agrawal Date: Mon, 6 Oct 2025 13:34:06 +0530 Subject: [PATCH] net/enetfec: fix memory leak in Rx buffer cleanup [ upstream commit 979d00728b01a77f8f67f46c7cb06e2628542d29 ] The RX buffer cleanup logic did not check for NULL before freeing mbufs, which could lead to undefined behavior. This patch adds a NULL check before freeing each mbuf. Fixes: ecae71571b0d ("net/enetfec: support Rx/Tx") Signed-off-by: Hemant Agrawal Acked-by: Sachin Saxena --- drivers/net/enetfec/enet_ethdev.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/enetfec/enet_ethdev.c b/drivers/net/enetfec/enet_ethdev.c index dbc3bf0822..43e831cc78 100644 --- a/drivers/net/enetfec/enet_ethdev.c +++ b/drivers/net/enetfec/enet_ethdev.c @@ -1,5 +1,5 @@ /* SPDX-License-Identifier: BSD-3-Clause - * Copyright 2020-2021,2023 NXP + * Copyright 2020-2021,2023-2024 NXP */ #include @@ -171,8 +171,10 @@ enet_free_buffers(struct rte_eth_dev *dev) bdp = rxq->bd.base; for (i = 0; i < rxq->bd.ring_size; i++) { mbuf = rxq->rx_mbuf[i]; - rxq->rx_mbuf[i] = NULL; - rte_pktmbuf_free(mbuf); + if (mbuf) { + rxq->rx_mbuf[i] = NULL; + rte_pktmbuf_free(mbuf); + } bdp = enet_get_nextdesc(bdp, &rxq->bd); } } @@ -558,7 +560,7 @@ err_alloc: } } rte_free(rxq); - return errno; + return -ENOMEM; } static const struct eth_dev_ops enetfec_ops = { -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:21.518244883 +0200 +++ 0088-net-enetfec-fix-memory-leak-in-Rx-buffer-cleanup.patch 2025-12-21 16:54:17.411034000 +0200 @@ -1 +1 @@ -From 979d00728b01a77f8f67f46c7cb06e2628542d29 Mon Sep 17 00:00:00 2001 +From 630bbade65b566d92c2e7d58cfe7288b00d96767 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 979d00728b01a77f8f67f46c7cb06e2628542d29 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index bcecab828e..60bb4f7ebd 100644 +index dbc3bf0822..43e831cc78 100644 @@ -30 +31 @@ -@@ -172,8 +172,10 @@ enet_free_buffers(struct rte_eth_dev *dev) +@@ -171,8 +171,10 @@ enet_free_buffers(struct rte_eth_dev *dev) @@ -43 +44 @@ -@@ -547,7 +549,7 @@ err_alloc: +@@ -558,7 +560,7 @@ err_alloc: