From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A9EA470AE for ; Sun, 21 Dec 2025 16:05:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8514740647; Sun, 21 Dec 2025 16:05:09 +0100 (CET) Received: from SN4PR0501CU005.outbound.protection.outlook.com (mail-southcentralusazon11011065.outbound.protection.outlook.com [40.93.194.65]) by mails.dpdk.org (Postfix) with ESMTP id 6CD27402B5 for ; Sun, 21 Dec 2025 16:05:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iTZQDNix1LwTb0b0DOwtuKiot3UzOhjh0sPOWBdoIgi5wiAa6NA/CnG46XFDzBL+Zx/gQd6P5amh442ObQTX0iewLrhbVjEXDhemKzYl0NKbW4kqtl1wSl6aQYToNiaan4Q54yKqIjFXWiXtP4dRWQupOFi8btve3BT2qyTznFXgn+3hU8tinGsgm/0w3zkooUzHEsA494deLCNh9Hht9ugyhdRJB0noL05fvZyTokPoDdCsEY+XavxuLKXbtcZpcDjCAihZ9wJP7xm26MHCBQ3bntw8M+hzHdWq7pUr7d9geF6AN/VeWqKRcGnkyVU3nRpHRoL2IE4VG6SCnWQM7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tC2FryzX503xnJL5/ABesjFHlpOnavvKVv9c3ups2bg=; b=C/gcsBGxQZfQ1NTA23JxwyfbsRdvmw/i+iGlkHHWsoE+FusHSJGG4dufxxCv/xONMlWklpR+DIT1Zgs+7Tcv2FsXaTPhlVENfRH48/AhLh9lnT58Bc3A+YJAlHYSg2bT/KZ66CMi/2iQn6EJjRKJqyb8PyCwgtWMtnO2Te+zS61j/zMhs+3qns0MF0Tok/Pkm/ieGYtsb7z1VloCKRdyQs4tbX6XsaX4J/pTlGAC07ag/VLgDgVy8pG3RZJvjrfU7Q7yswU+e8exaYATWyOUNNObO57JZIJeTHt12R9VzEeo3nkmCUP5u/TEsIo0Wf6+9u7YBeoAQjs+SgH5AJYrdQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=redhat.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tC2FryzX503xnJL5/ABesjFHlpOnavvKVv9c3ups2bg=; b=QOuqZf5npQRLOIm3WVa1qeQjGQGA2Pj7FajFOca2Rq7bvKaWyA8x7XAv7ighsOG6w5RzOl1t5TVtR86gEpQThV02xYAXahJL3xL3YjuMhtZBdWn1I+b1UU4fTUCiAavgEBZtLF/8wTCwYys0FUXBfh9IJueTxG6MP+bY93TITHnYAGBu02r++7kJa6znx41Xq0k+Sekp8Pvs9xIk+ZkLndDiHpLYyIdW0j6Z98Ue7lyor13wzs/K9y7Jy9+qOYMwWrKM0E0zar96bKgsKDRA1V7/28+LDGTPbom+6FrMAAie6RzG9ych43UZ0Zx9aVLVKUJ2AjsG0EZrZ7PqKXCmlQ== Received: from BYAPR02CA0046.namprd02.prod.outlook.com (2603:10b6:a03:54::23) by CH3PR12MB8260.namprd12.prod.outlook.com (2603:10b6:610:12a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.10; Sun, 21 Dec 2025 15:05:04 +0000 Received: from CO1PEPF000066EC.namprd05.prod.outlook.com (2603:10b6:a03:54:cafe::e3) by BYAPR02CA0046.outlook.office365.com (2603:10b6:a03:54::23) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.11 via Frontend Transport; Sun, 21 Dec 2025 15:05:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000066EC.mail.protection.outlook.com (10.167.249.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:05:03 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:04:47 -0800 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:04:46 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 07:04:45 -0800 From: Shani Peretz To: Robin Jarry CC: dpdk stable Subject: patch 'net/tap: fix interrupt callback crash after failed start' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:57:18 +0200 Message-ID: <20251221145746.763179-90-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000066EC:EE_|CH3PR12MB8260:EE_ X-MS-Office365-Filtering-Correlation-Id: ad36676a-6b31-4b5f-70e5-08de40a25230 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|1800799024|82310400026|376014|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?N3Xs+1wboZJt0kzR2yQgYiy1ACAOVuhzJgZtajF0wohheqVxvjPhxVKAZPEg?= =?us-ascii?Q?NvPGLU+8Qpbu1/oAyPSLqVNIP0MvyICFaERjlHtR+7Ms3LiCEX6KKRMGfs0n?= =?us-ascii?Q?NRcJohj1Y5L2P93Blp7zaWvVGeubdUVqWRPRXUvTqiJjOYEPucS7+DayGcPd?= =?us-ascii?Q?Wzb8PT6PUhHFQsBtvKpCPecpBDTfK3S6gjSFiY3hUSTtKzb47FEqx93yv63S?= =?us-ascii?Q?Y8+tUFgrTKChzWNKdravvln7C/gnD4gpaMawWfW6Kyxyvd63GQJZ97HjS9rN?= =?us-ascii?Q?qO9LXgdpPQDs0L/QSdkZt0uGU/BxQif1VAASkT8hHWJdWB5wIZjR+sTg94da?= =?us-ascii?Q?0bP70e96TIXBehd2wD0EgOEOsHgb3BwZkg+Ps1MtqzTdgPNcOAi7LWmj6Eni?= =?us-ascii?Q?YI/pn2Aprm45o/gB7y24/lXVxqmyrh8bJEHYoj0C03bf0WHx0u8KEcZzxezX?= =?us-ascii?Q?TXes0Oxp6ow8+0DNRxl/6JgcEC4Y1uYTzdJWFLVqWcjIgO0RIaHkxCX54evE?= =?us-ascii?Q?WcvJKqKUO3oqYpa3pMV6+3LENAsEd0o9NVEkZhZ6mFiFdYe64NQuxq6b5WF7?= =?us-ascii?Q?k6MB/vBud4pSBb2d6LfHFBTYNzNYlhvUDxmOrfp3gSw9HiELyRAG2nxrhiiL?= =?us-ascii?Q?yf6zN+T4tZxkXdoHhXQW1y43YrChnnlN/XnW9HeRJ5F5+yEMp2gbqjKROqLJ?= =?us-ascii?Q?5nFQ4WyCn4dyuSGZSBuooyVkxlc0tjmCUwXFEaAeptWOCc5g0dZDwamvDKD5?= =?us-ascii?Q?jp0eAWJB5qktQz6fbhYBXbgiCzLO0PVy6M2Yu/GfgEaXctzuZqY/IddaUbjx?= =?us-ascii?Q?g4qzgxY1jh2bctmCSwTqmAKAbHytl0nfRTMsc2VSfZFKJFovQt8WHgi5OxY5?= =?us-ascii?Q?/3K/3xnye6Cioo0D9cgswldhgcbGppgIzAZDR7sF/FgmoO9Q5tTT2g/RjPGA?= =?us-ascii?Q?l9JAN7fWEXCRotFvTGgYB9cy38v5XWWKY+jwaRHXbyhq0w+AzRUuZ5YBOSRd?= =?us-ascii?Q?CNElsdxwnqeMi+MgM+S41qfPGdCsdZxlVZbLKpm+6UYLa7OhkCVO97hyhTEH?= =?us-ascii?Q?6pt9iN7CfhZGcpUymzl5T2DnFLnYlOePBZ5FZchfwhsI7HXYwFWpn5F7Uzws?= =?us-ascii?Q?2Uqnnz14kqIj9qA9vTQPaG/bcL93EiZg8oCtjnBlx+ZbdkKhgkKoDne6WHRM?= =?us-ascii?Q?qIrCpQji+Qrcg3Q9spMHi77GZ0XNKKtX/J1ErAEutFnyHEbIBthFi9vycH2/?= =?us-ascii?Q?Bl8TS6AZ5M0xBm/06iOuzqGRGIeTSyOWUiDkCjQWv8E6qkgQzYReegcO99Kz?= =?us-ascii?Q?J9rNi2/Jht+prfVNY1EeNxczhv7JP15c0GoALPiTgnPAFVhzuJRZMDPOXLlt?= =?us-ascii?Q?hsX9S0WJ59JaNfagBZY0lh3Nv61ZYRs967NgHaZ7QBjmCG6zbCv7obxIKkTE?= =?us-ascii?Q?opVJHMr1vX0coN23XBarW2D4rciySe3UaOG2SpSb1sFMvbKHfEVyBYP7cZHC?= =?us-ascii?Q?DsYDqG/Oxj9Me1A4X3HkAuMuxZaK0fMryAh/IBr58JgXUCdzrmux0YKvMDlR?= =?us-ascii?Q?skkrkip3Cw6sUvd7cm4WUtlcdLwMmWgyKHnFZ0/t?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(1800799024)(82310400026)(376014)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:05:03.9978 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ad36676a-6b31-4b5f-70e5-08de40a25230 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000066EC.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR12MB8260 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/d9aac4ce84415a42fca9a14bc39b80ca2ff7d0cb Thanks. Shani --- >From d9aac4ce84415a42fca9a14bc39b80ca2ff7d0cb Mon Sep 17 00:00:00 2001 From: Robin Jarry Date: Fri, 17 Oct 2025 14:19:47 +0200 Subject: [PATCH] net/tap: fix interrupt callback crash after failed start [ upstream commit c44ed082917316257dbeb2454414932d39f9c321 ] After moving a tap linux net device to a different namespace, tap_link_set_up fails with an -ENODEV error. Indeed it relies on an ioctl call using the interface name as argument: /* with ifr->ifrn_name = "dtapX" */ ioctl(pmd->ioctl_sock, SIOCGIFFLAGS, ifr) This causes rte_eth_dev_stop() to do nothing since the device is not seen as started. And then, when removing the device, the interrupt callbacks are left there. If they are invoked, they will be so with a "freed" device pointer: Thread 2 "dpdk-intr" hit Breakpoint 1, tap_dev_intr_handler at ../drivers/net/tap/rte_eth_tap.c:1689 1689 struct pmd_internals *pmd = dev->data->dev_private; (gdb) p *dev $2 = { ... data = 0x0, ... state = RTE_ETH_DEV_UNUSED, security_ctx = 0x0 } This causes a crash when dereferencing the data pointer. When tap_link_set_up fails, ensure to unregister the interrupt callbacks that were just reinstalled. Fixes: c0bddd3a057f ("net/tap: add link status notification") Signed-off-by: Robin Jarry --- drivers/net/tap/rte_eth_tap.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c index 93bba3cec1..45970ca0de 100644 --- a/drivers/net/tap/rte_eth_tap.c +++ b/drivers/net/tap/rte_eth_tap.c @@ -893,8 +893,10 @@ tap_dev_start(struct rte_eth_dev *dev) return err; err = tap_link_set_up(dev); - if (err) + if (err) { + tap_intr_handle_set(dev, 0); return err; + } for (i = 0; i < dev->data->nb_tx_queues; i++) dev->data->tx_queue_state[i] = RTE_ETH_QUEUE_STATE_STARTED; -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:21.599860655 +0200 +++ 0090-net-tap-fix-interrupt-callback-crash-after-failed-st.patch 2025-12-21 16:54:17.424060000 +0200 @@ -1 +1 @@ -From c44ed082917316257dbeb2454414932d39f9c321 Mon Sep 17 00:00:00 2001 +From d9aac4ce84415a42fca9a14bc39b80ca2ff7d0cb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit c44ed082917316257dbeb2454414932d39f9c321 ] + @@ -37 +38,0 @@ -Cc: stable@dpdk.org @@ -45 +46 @@ -index 650ddbd706..58d70f7dd6 100644 +index 93bba3cec1..45970ca0de 100644 @@ -48 +49 @@ -@@ -889,8 +889,10 @@ tap_dev_start(struct rte_eth_dev *dev) +@@ -893,8 +893,10 @@ tap_dev_start(struct rte_eth_dev *dev)