From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF073470AE for ; Sun, 21 Dec 2025 16:05:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9234402B5; Sun, 21 Dec 2025 16:05:24 +0100 (CET) Received: from CY7PR03CU001.outbound.protection.outlook.com (mail-westcentralusazon11010061.outbound.protection.outlook.com [40.93.198.61]) by mails.dpdk.org (Postfix) with ESMTP id ED4DE402B5 for ; Sun, 21 Dec 2025 16:05:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mmnoDRm1ZkfpEc/mLgTj8YR57B4Lv3VQLC7lWFuTLx/Mw4Z1gEijiVFwPBjlmMGBGSXu3cpNnNKKdaOSMycXb7/zPSc2pQTbL0LuAnCrUETbb+9tQHNwsmIjZ8wrXpU/diT6LI6DJAqLYtz0hG0QiP59xk11wq1arIpe24zIGsGl4ugt56c8HyjKzP+aFMNyfItrk/rKGIpeKO/AuYlkCBj1i8PXtkxqV4UHTcBTJAnY0cO4pLSPNEJRpLUG8FCJBmSYGndrKSCxFkHJdEwm2sNwXn7JhqHdXMnLF5Yg6O7E027G605WbBYOzUSzjg2Xrh1Y1KF5YJ6JNMOcyrjDYw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HtVyIMlTqfoKw1CzfVWudh5BszOsEjvmAP6C9RRn2QU=; b=HxJVzJaYhZO+n4ip0LR7kuOdROAGjuTx2gdFj22bXfFXoqsy6DdjDOI/W320cDBEOtcr9mhVQuz3xSlpiDhS+9U0kwXRGQyTClF3W5o2QRNURtRwcqCVYu2jaVsLnc3BVtn2s10fRDC3mEP3wywi5W/cPTkYZ1I+i2iheN3QEPL5lsaFnMAtRwwR+WZS0NxNoA7zPiEOsjJQjFw9iHxE6EsVxUSqCm1gm8FF+kh5KV7CeI1N+PFO3inygeb9MFI0taCHdDE0syZ+oXRFLCUULffRPN2krpKrfNKn9L77kXKh9ZUYMBGG4t6hCep4BpGJbiNbFQGD7/necmnLAiuRkg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=amazon.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HtVyIMlTqfoKw1CzfVWudh5BszOsEjvmAP6C9RRn2QU=; b=Ntwu7w2edQ0ugiA4EwIt6ineaxtTqe5yV16Bxddd6okRKVD9nFBhUi1ULHvWCwt3z0+XvQv43n3+lc211zFuFVR84ODaZTiz3tKyoVcs45cMavqHDSLc/XDc5nkhp2LiOEhGNVIiRGgfcMzCyoxEKU3bWR1WUCp+R8gNOJW+ll5Xguw9PQEspK2yKKWMOgA66wJVL31T6CfAGDLujwEwoce6mfLKYMeX92jgAzY8k7Vr2uUFf3dcbDhRccmd8CwydWjU527J/l1pNBXmiPW0uto412kJRgzumQGcd6AiJw0fASM8NaCPfLqRQITvlAoJV5EXUtKw4+mvTb6fvLgREQ== Received: from BY5PR17CA0063.namprd17.prod.outlook.com (2603:10b6:a03:167::40) by DS0PR12MB8478.namprd12.prod.outlook.com (2603:10b6:8:15a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9434.10; Sun, 21 Dec 2025 15:05:17 +0000 Received: from SJ5PEPF00000205.namprd05.prod.outlook.com (2603:10b6:a03:167:cafe::d9) by BY5PR17CA0063.outlook.office365.com (2603:10b6:a03:167::40) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9434.8 via Frontend Transport; Sun, 21 Dec 2025 15:05:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF00000205.mail.protection.outlook.com (10.167.244.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9456.9 via Frontend Transport; Sun, 21 Dec 2025 15:05:16 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:05:03 -0800 Received: from rnnvmail204.nvidia.com (10.129.68.6) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20; Sun, 21 Dec 2025 07:05:02 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.20 via Frontend Transport; Sun, 21 Dec 2025 07:05:01 -0800 From: Shani Peretz To: Shai Brandes CC: Amit Bernstein , Yosef Raisman , dpdk stable Subject: patch 'net/ena/base: fix unsafe memcpy on invalid memory' has been queued to stable release 23.11.6 Date: Sun, 21 Dec 2025 16:57:20 +0200 Message-ID: <20251221145746.763179-92-shperetz@nvidia.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20251221145746.763179-1-shperetz@nvidia.com> References: <20251221145746.763179-1-shperetz@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF00000205:EE_|DS0PR12MB8478:EE_ X-MS-Office365-Filtering-Correlation-Id: ab2dd90f-643c-40da-660c-08de40a259e0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|1800799024|82310400026|13003099007|7053199007; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?jM8WJauNI+qOorJ+XRnSVyzFru7iHAI4pjirFTqFBlJE6ci7qIG7LUD60COL?= =?us-ascii?Q?tmagbxJ115Hxseug1VSvZp7jSQZDhO16ftVd0jHRo6OM5p38ppjOTSng58jA?= =?us-ascii?Q?uqgTCUIkSucW6v2y+PT1uGU7ZbLILJ1wDJF0y+EH3fUevvo5ZFtSr6ZEgltA?= =?us-ascii?Q?24NI8RolTUd2BISJZEPbCLLJSNjzNlOYzMLTVsaN1I3P4LJGOga9mMq2664b?= =?us-ascii?Q?2s+radltx8hmGPGXXMAgNXCZZEU7v3nVLcMGNSdfXugq8bWqTq9X5QHd/EJC?= =?us-ascii?Q?YS2LPEtKmgfwUAK03A+mVYlpJIRDLqp/ToanZpLxl1kCBfqiKLD7jhuIta0s?= =?us-ascii?Q?uiGP88K2XcU/U/3WX8/wy8ioLpIgP8c18jecMpO2roSK7wUn7A943DFDlF/g?= =?us-ascii?Q?PoGUeQD/J845CQxzWORmgYn2ALO2rJ89gA0C4D3Dg+yK7aKr0gVdrrwcOJ32?= =?us-ascii?Q?zNDk6c4QtPl7Q3t9FlBP9teEFv6hf53Wd0mGb7+RLQpkTb1ymTNxnKynMZ4N?= =?us-ascii?Q?GUym5Fi+I7Uw4z5f1mfqlpqdWZajq0BcqpdxwOqZjIWw6DVuW8E5UbJgptcX?= =?us-ascii?Q?DJ1JgERQLdCKl3jjpumxnNQqalA3yuy3rLKRT4hS7Ur3qbKLDSMWyTwwlQ4k?= =?us-ascii?Q?jD8XjEqw3WGvlNJIDFAVc0GVjYPhnqAu1My1WpmYazH2UHHKyB88s+3d3vhz?= =?us-ascii?Q?0G4lV894m8Ialhjdgm9oX9Cd4Cp0FiZqDtZx2UG0tvkM51A8qFlcLj5YMiWX?= =?us-ascii?Q?b54yX2OhFGZ5+/F+n9SfT4qwMNehyBsy/wplkv4rd4O4U9APdA3UtznjA8og?= =?us-ascii?Q?d0ENcWOH7+RizDo89vYWq22z/NV02vuI978TW/P+Nv7WlH1MYm81rb65gsV6?= =?us-ascii?Q?x9IO9t79oBMDjyJP30BnltWkfMkxoXtzdtPN0Rf6FSkgIP1oV+wxUHjhQFyl?= =?us-ascii?Q?1WkHB20mrLfG53APzBK6mKT7Gg/V7QgDQipHnUcthk8mFLaiDq3P4f8X+vFx?= =?us-ascii?Q?CIRsERkErCEShme/OsGFc2JmjHYpKK03TdvKcIvjZ2KrejcxTGaIji+BOE+r?= =?us-ascii?Q?iBJtrGeShpgO9fa3DS42K6X2H/V4YuDfxB+3JwBp2ggsyAhi2DgY5CauLsaF?= =?us-ascii?Q?Vq86YDGHn2yfm4BIWkWy52Te8FYLOfxbfFemhmtdP/2VRF6l1b4ctWePdm+y?= =?us-ascii?Q?RRxxlmEPKZkxwiCcRfkebg4X/cEfrysEatE/waZ1T6c2afWhL0QB+g2JCHE/?= =?us-ascii?Q?SBfxYdot1noITHDIAM2AV89IsVkN8zaNk9eqIdPuAyzK1tGr9QiWXQDTWo0c?= =?us-ascii?Q?usJHnV4c4ikOZyZFbhVXLX5gYXhQJDYlqcIxndse3lt/PkleI+Dryi6fXWA5?= =?us-ascii?Q?uonZaPkfsLHXsMUNsE/XjTJUdvxnCmQR4BMhD9781IPd3QwSR1tKA2ix/hDc?= =?us-ascii?Q?hdtrgF68FHTq33vnKCppcxXO0QSAoKyTMbyz4yTTlTEi3b9bZmkSrNsH3W4S?= =?us-ascii?Q?ibCW/dS+jHpu+fk8JzqulPFlhG+BPpJxESJvpXOknoj1+pticZPlZZIp3Bjd?= =?us-ascii?Q?e/PAyYEbCcSDSDSc/EY=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(1800799024)(82310400026)(13003099007)(7053199007); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Dec 2025 15:05:16.8664 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ab2dd90f-643c-40da-660c-08de40a259e0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF00000205.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB8478 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/26/25. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/shanipr/dpdk-stable This queued commit can be viewed at: https://github.com/shanipr/dpdk-stable/commit/e77a5fb38b627e5041d01e45bb8c1623d5ed6a66 Thanks. Shani --- >From e77a5fb38b627e5041d01e45bb8c1623d5ed6a66 Mon Sep 17 00:00:00 2001 From: Shai Brandes Date: Wed, 15 Oct 2025 15:12:30 +0300 Subject: [PATCH] net/ena/base: fix unsafe memcpy on invalid memory [ upstream commit b70db0912a6a181ecf513a4eef61153d1063c0ae ] The return status check was placed after a memcpy operation, which could result in copying from an invalid memory region if the feature fetch failed. Fixes: b68309be44c0 ("net/ena/base: update communication layer for the ENAv2") Signed-off-by: Shai Brandes Reviewed-by: Amit Bernstein Reviewed-by: Yosef Raisman --- drivers/net/ena/base/ena_com.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ena/base/ena_com.c b/drivers/net/ena/base/ena_com.c index 2f438597e6..5fea17c989 100644 --- a/drivers/net/ena/base/ena_com.c +++ b/drivers/net/ena/base/ena_com.c @@ -2277,13 +2277,13 @@ int ena_com_get_dev_attr_feat(struct ena_com_dev *ena_dev, } else { rc = ena_com_get_feature(ena_dev, &get_resp, ENA_ADMIN_MAX_QUEUES_NUM, 0); + if (rc) + return rc; + memcpy(&get_feat_ctx->max_queues, &get_resp.u.max_queue, sizeof(get_resp.u.max_queue)); ena_dev->tx_max_header_size = get_resp.u.max_queue.max_header_size; - - if (rc) - return rc; } rc = ena_com_get_feature(ena_dev, &get_resp, -- 2.43.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2025-12-21 16:54:21.690090212 +0200 +++ 0092-net-ena-base-fix-unsafe-memcpy-on-invalid-memory.patch 2025-12-21 16:54:17.440027000 +0200 @@ -1 +1 @@ -From b70db0912a6a181ecf513a4eef61153d1063c0ae Mon Sep 17 00:00:00 2001 +From e77a5fb38b627e5041d01e45bb8c1623d5ed6a66 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit b70db0912a6a181ecf513a4eef61153d1063c0ae ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index ede3c06139..f0936a6262 100644 +index 2f438597e6..5fea17c989 100644 @@ -24 +25 @@ -@@ -2453,13 +2453,13 @@ int ena_com_get_dev_attr_feat(struct ena_com_dev *ena_dev, +@@ -2277,13 +2277,13 @@ int ena_com_get_dev_attr_feat(struct ena_com_dev *ena_dev,