From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 058841BCDA for ; Thu, 20 Dec 2018 15:24:50 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id A4BA42223F; Thu, 20 Dec 2018 09:24:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 20 Dec 2018 09:24:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=iDhDKLqf1od+on58CsDz/sjkffTFquzBnB2+s6hT5QM=; b=Khnzd4iIQHho yY65G6PjpkZsGX5uwZNij9uz/Ypm+CNkMC//ZO6p/DyiNITcR73LcYukiVVnbEe8 P4eo0wym2GES6R/V8HM+k/ej+C1QBPjKhuCFj+5P2Ryeluipm3tmL3SA7chuJf5w 0/1CqsnXk7YA0gFfddvcORFY+tPIpoo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=iDhDKLqf1od+on58CsDz/sjkffTFquzBnB2+s6hT5 QM=; b=hcFBpVgQ8wBnfAG5HDUSWBKRSYZxF7CLGZ0EVI13En3qQ9djqXAMZVxg7 Sr+ONmaepcVkhPrYlLyQaXgYeHFL71P3FLa5ew54rC0zlshQ5gp4Yfpzlsk72w/u J5O5nXAwp4bE+VJd3Hfb1q1+y9owbfXk/Gpof6YsmVcgs8l7P+t7/civZgLN2RFG F00PhPk0S27g+gC29DuUtt9kb986UGc7QLGAe8BeDl5IQ30R/uIumCWQT4mZvqx7 WZhtqSJmisieOk0ClWwezLoz0rzMbZ87kKi8dp3tx8V8GsOW8Z+Cw2tnQulJ8j27 N/R4nA8RBa4EngA352XEGbJJ35ilA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedtkedrudejfedgieehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfquhhtnecuuegrihhlohhuthemucef tddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhvffufffkjg hfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghsucfoohhnjhgrlhhonhcu oehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkphepjeejrddufeegrddvtd efrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 69E85100B8; Thu, 20 Dec 2018 09:24:48 -0500 (EST) From: Thomas Monjalon To: "Stojaczyk, Dariusz" , "Howell, Seth" Cc: stable@dpdk.org, Kevin Traynor , "Burakov, Anatoly" Date: Thu, 20 Dec 2018 15:24:47 +0100 Message-ID: <2058595.jvs3v1SPzz@xps> In-Reply-To: References: <20181204170610.250124-1-seth.howell@intel.com> <20181207201042.372870-1-seth.howell@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH v2] malloc: notify primary process about hotplug in secondary X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 14:24:50 -0000 07/12/2018 21:30, Stojaczyk, Dariusz: > Hi Kevin, is the merge window for DPDK 18.08.1 and 18.05.2 still open? This fix is critical for multi-process memory hotplug and you might want to pull it in. First thing to do is to make sure stable@dpdk.org is Cc'ed in the patch, below Fixes:. > > -----Original Message----- > > From: Howell, Seth > > Sent: Friday, December 7, 2018 9:11 PM > > To: Burakov, Anatoly > > Cc: dev@dpdk.org; stable@dpdk.org; Howell, Seth > > ; Stojaczyk, Dariusz > > Subject: [PATCH v2] malloc: notify primary process about hotplug in > > secondary > > > > When secondary process hotplugs memory, it sends a request > > to primary, which then performs the real mmap() and sends > > sync requests to all secondary processes. Upon receiving > > such sync request, each secondary process will notify the > > upper layers of hotplugged memory (and will call all > > locally registered event callbacks). > > > > In the end we'll end up with memory event callbacks fired > > in all the processes except the primary, which is a bug. > > > > This gets critical if memory is hotplugged while a VFIO > > device is attached, as the VFIO memory registration - > > which is done from a memory event callback present in the > > primary process only - is never called. > > > > After this patch, a primary process fires memory event > > callbacks before secondary processes start their > > synchronizations - both for hotplug and hotremove. > > > > Fixes: 07dcbfe0101f ("malloc: support multiprocess memory hotplug") > > > > Signed-off-by: Seth Howell > > Signed-off-by: Darek Stojaczyk > > --- > > lib/librte_eal/common/malloc_mp.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/lib/librte_eal/common/malloc_mp.c > > b/lib/librte_eal/common/malloc_mp.c > > index 5f2d4e0be..f3a13353b 100644 > > --- a/lib/librte_eal/common/malloc_mp.c > > +++ b/lib/librte_eal/common/malloc_mp.c > > @@ -209,6 +209,8 @@ handle_alloc_request(const struct malloc_mp_req > > *m, > > > > map_addr = ms[0]->addr; > > > > + eal_memalloc_mem_event_notify(RTE_MEM_EVENT_ALLOC, > > map_addr, alloc_sz); > > + > > /* we have succeeded in allocating memory, but we still need to sync > > * with other processes. however, since DPDK IPC is single-threaded, > > we > > * send an asynchronous request and exit this callback. > > @@ -258,6 +260,9 @@ handle_request(const struct rte_mp_msg *msg, > > const void *peer __rte_unused) > > if (m->t == REQ_TYPE_ALLOC) { > > ret = handle_alloc_request(m, entry); > > } else if (m->t == REQ_TYPE_FREE) { > > + eal_memalloc_mem_event_notify(RTE_MEM_EVENT_FREE, > > + m->free_req.addr, m->free_req.len); > > + > > ret = malloc_heap_free_pages(m->free_req.addr, > > m->free_req.len); > > } else { > > @@ -436,6 +441,9 @@ handle_sync_response(const struct rte_mp_msg > > *request, > > memset(&rb_msg, 0, sizeof(rb_msg)); > > > > /* we've failed to sync, so do a rollback */ > > + eal_memalloc_mem_event_notify(RTE_MEM_EVENT_FREE, > > + state->map_addr, state->map_len); > > + > > rollback_expand_heap(state->ms, state->ms_len, state- > > >elem, > > state->map_addr, state->map_len); > > > > -- > > 2.17.2 >