patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] raw/ioat: fix memory leak in device configure
@ 2021-06-17 14:17 Kevin Laatz
  2021-06-17 14:20 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Kevin Laatz @ 2021-06-17 14:17 UTC (permalink / raw)
  To: dev; +Cc: stable, bruce.richardson, Kevin Laatz

During device configure, memory is allocated for "hdl_ring_flags". In the
event of another call to the device configure function (reconfigure), a
memory leak would occur. This patch fixes the memory leak by free'ing the
memory before reallocating it.

Fixes: 245efe544d8e ("raw/ioat: report status of completed jobs")

Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
 drivers/raw/ioat/ioat_common.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/raw/ioat/ioat_common.c b/drivers/raw/ioat/ioat_common.c
index d01c1ee367..f4771745cc 100644
--- a/drivers/raw/ioat/ioat_common.c
+++ b/drivers/raw/ioat/ioat_common.c
@@ -147,6 +147,7 @@ idxd_dev_configure(const struct rte_rawdev *dev,
 	/* in case we are reconfiguring a device, free any existing memory */
 	rte_free(rte_idxd->desc_ring);
 	rte_free(rte_idxd->hdl_ring);
+	rte_free(rte_idxd->hdl_ring_flags);
 
 	/* allocate the descriptor ring at 2x size as batches can't wrap */
 	rte_idxd->desc_ring = rte_zmalloc(NULL,
-- 
2.25.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [PATCH] raw/ioat: fix memory leak in device configure
  2021-06-17 14:17 [dpdk-stable] [PATCH] raw/ioat: fix memory leak in device configure Kevin Laatz
@ 2021-06-17 14:20 ` Bruce Richardson
  2021-06-22 20:59   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2021-06-17 14:20 UTC (permalink / raw)
  To: Kevin Laatz; +Cc: dev, stable

On Thu, Jun 17, 2021 at 02:17:52PM +0000, Kevin Laatz wrote:
> During device configure, memory is allocated for "hdl_ring_flags". In the
> event of another call to the device configure function (reconfigure), a
> memory leak would occur. This patch fixes the memory leak by free'ing the
> memory before reallocating it.
> 
> Fixes: 245efe544d8e ("raw/ioat: report status of completed jobs")
> 
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---

Thanks, Kevin.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] raw/ioat: fix memory leak in device configure
  2021-06-17 14:20 ` Bruce Richardson
@ 2021-06-22 20:59   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2021-06-22 20:59 UTC (permalink / raw)
  To: Kevin Laatz; +Cc: dev, stable, Bruce Richardson

17/06/2021 16:20, Bruce Richardson:
> On Thu, Jun 17, 2021 at 02:17:52PM +0000, Kevin Laatz wrote:
> > During device configure, memory is allocated for "hdl_ring_flags". In the
> > event of another call to the device configure function (reconfigure), a
> > memory leak would occur. This patch fixes the memory leak by free'ing the
> > memory before reallocating it.
> > 
> > Fixes: 245efe544d8e ("raw/ioat: report status of completed jobs")
> > 
> > Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> > ---
> 
> Thanks, Kevin.
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Cc: stable@dpdk.org

Applied, thanks



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-06-22 20:59 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-17 14:17 [dpdk-stable] [PATCH] raw/ioat: fix memory leak in device configure Kevin Laatz
2021-06-17 14:20 ` Bruce Richardson
2021-06-22 20:59   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git