patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Harman Kalra <hkalra@marvell.com>
Cc: stephen@networkplumber.org, pbhagavatula@marvell.com,
	stable@dpdk.org, dev@dpdk.org, david.marchand@redhat.com
Subject: Re: [dpdk-stable] [PATCH] eal: fix macros to align value
Date: Wed, 24 Jun 2020 10:13:18 +0200
Message-ID: <2094499.cageA7459N@thomas> (raw)
In-Reply-To: <1591730225-15300-1-git-send-email-hkalra@marvell.com>

09/06/2020 21:17, Harman Kalra:
> Found an issue while using RTE_ALIGN_MUL_NEAR with an
> expression, like as passed in estimate_tsc_freq().
> RTE_ALIGN_MUL_FLOOR resulted in unexpected value in the
> above function as division has more precedence over
> substraction.

The only change I see is adding parenthesis around v.
Am I right?

>  #define RTE_ALIGN_MUL_CEIL(v, mul) \
> -	(((v + (typeof(v))(mul) - 1) / ((typeof(v))(mul))) * (typeof(v))(mul))
> +	((((v) + (typeof(v))(mul) - 1) / ((typeof(v))(mul))) * (typeof(v))(mul))
[...]
>  #define RTE_ALIGN_MUL_FLOOR(v, mul) \
> -	((v / ((typeof(v))(mul))) * (typeof(v))(mul))
> +	(((v) / ((typeof(v))(mul))) * (typeof(v))(mul))
[...]
>  	({							\
>  		typeof(v) ceil = RTE_ALIGN_MUL_CEIL(v, mul);	\
>  		typeof(v) floor = RTE_ALIGN_MUL_FLOOR(v, mul);	\
> -		(ceil - v) > (v - floor) ? floor : ceil;	\
> +		(ceil - (v)) > ((v) - floor) ? floor : ceil;	\
>  	})





  reply	other threads:[~2020-06-24  8:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09 19:17 Harman Kalra
2020-06-24  8:13 ` Thomas Monjalon [this message]
2020-06-24  8:24   ` [dpdk-stable] [EXT] " Harman Kalra
2020-06-24  8:30     ` Thomas Monjalon
2020-06-24 10:02       ` Harman Kalra
2020-06-24 10:20       ` [dpdk-stable] [PATCH v2] " Harman Kalra
2020-07-11  9:44         ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2094499.cageA7459N@thomas \
    --to=thomas@monjalon.net \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=pbhagavatula@marvell.com \
    --cc=stable@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git