From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id F01E65424; Wed, 14 Nov 2018 04:44:22 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 7D2BB22AF3; Tue, 13 Nov 2018 22:44:22 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 13 Nov 2018 22:44:22 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=JJGxEts4eBN+GN4qcQABVmqswqB5d7XqCuNmeBVkRxs=; b=jLoWOw72bdbN hjPohS+qlh3C2vNP5UcBdHHHX+W209CCcz0Omsg1a1UkgDthVd7PG1FgecF1ASr4 ivMLfcmFl6vuG883ccPPMkfAuutPVtpvV1Y2G5LeCO/h51FEjaUaChkB4nvQAD+B HZaCzoEUuIMyh3aiCyFTGRxQ2NfrvUQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=JJGxEts4eBN+GN4qcQABVmqswqB5d7XqCuNmeBVkR xs=; b=Q8H8WS0m93tN6stjdbtOAOGBC5VcGOOMV3lYrakVXxJnnH2jKb5R0hVl+ Y1IeuWg3hF2Wgx4iDcz3r4cqg08tzv8oG2GP1uCHgOm7N3D/4nF2EB1+MQiN9mqy YeVICDJoRTTT/X54ptj4w3bVG9U+48Dasw+HAOLC6irbGlTzNKyJsXwv2lobpA4Z K8ycEs5+MH44AUgR8rOEb4mf35GSj8ppnfm/6cBYypS6DXOacjoEFwrW41ABJxz5 5tAFAy+0qB+xAaz6F4oVU004VYuE6hOrs0lHlT8FE5x3Bdc4oEUAOzr3RXqgeDIO kzsryc/UtII/tHcoje0vgyIXTCWQA== X-ME-Sender: <xms:FZrrW2xtHmkhFSbqeBS4VKFvKQG0_7S6LDbxck_ZdIpFd1Z_MPvfZw> X-ME-Proxy: <xmx:FZrrW62B_z5Nk71lHBe4AbtLfybyMe6kDfaiAscbfyaEmdnqtCuaWw> <xmx:FZrrW0v1Iu0ztaUOmDkckx0VXZU9Nxi80-lChE1ByJmYl7F7yyfYgw> <xmx:FZrrW6ThwttNw69iWgH90T4GIuMDNsntf3dJcBRbWPL_V2xvoEK1AA> <xmx:FZrrW2VYCnQj8OsWqkH4YlZ4OMjkE44wJfT6UqsB-r7LB_uz9fhEBw> <xmx:FZrrW0n28bbuC3OA6d3dwlblefiogPYVq_RFTwEPTwMe7SZ6ybd5IQ> <xmx:FprrWz2Mfvk1SDJATJMx7XudjIWIevt7jrnKf7GuIY2jOqNf6qrnWQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 20072102DD; Tue, 13 Nov 2018 22:44:21 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: "Varghese, Vipin" <vipin.varghese@intel.com> Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>, "dev@dpdk.org" <dev@dpdk.org>, "Richardson, Bruce" <bruce.richardson@intel.com>, "stable@dpdk.org" <stable@dpdk.org>, ferruh.yigit@intel.com Date: Wed, 14 Nov 2018 04:44:20 +0100 Message-ID: <2137402.5xZ7V9L5Yp@xps> In-Reply-To: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2BE984@BGSMSX101.gar.corp.intel.com> References: <88cced4f601c44c6203b9adb09abacdce0b3a260.1542122595.git.anatoly.burakov@intel.com> <821e4582-5594-d291-6047-d6e5ba7b120f@intel.com> <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D2BE984@BGSMSX101.gar.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] eal: clean up unused files on initialization X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches <stable.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/stable>, <mailto:stable-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/stable/> List-Post: <mailto:stable@dpdk.org> List-Help: <mailto:stable-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/stable>, <mailto:stable-request@dpdk.org?subject=subscribe> X-List-Received-Date: Wed, 14 Nov 2018 03:44:23 -0000 14/11/2018 04:24, Varghese, Vipin: > Tested-by: Vipin Varghese <vipin.varghese@intel.com> > > <snipped> > > > >> When creating process data structures, EAL will create many files in > > >> EAL runtime directory. Because we allow multiple secondary processes > > >> to run, each secondary process gets their own unique file. With many > > >> secondary processes running and exiting on the system, runtime > > >> directory will, over time, create enormous amounts of sockets, > > >> fbarray files and other stuff that just sits there unused because the > > >> process that allocated it has died a long time ago. This may lead to > > >> exhaustion of disk (or RAM) space in the runtime directory. > > >> > > >> Fix this by removing every unlocked file at initialization that > > >> matches either socket or fbarray naming convention. We cannot be sure > > >> of any other files, so we'll leave them alone. Also, remove similar > > >> code from mp socket code. > > >> > > >> We do it at the end of init, rather than at the beginning, because > > >> secondary process will use primary process' data structures even if > > >> the primary itself has died, and we don't want to remove those before > > >> we lock them. > > >> > > >> Bugzilla ID: 106 > > >> > > >> Cc: stable@dpdk.org > > >> > > >> Reported-by: Vipin Varghese <vipin.varghese@intel.com> > > >> > > >> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com> > > Thanks Anatoly for the patch which clean-ups the tmpfs. This unblock the client from critical stopper too. > > > > > > > I feel it is too big and too late for 18.11. > > > Can we move it to 19.02? > > > > From maintainer's point of view, i agree that it's too risky to merge into 18.11 > > at this stage. My input should probably stop there, but Vipin (the original bug > > reporter) may have other thoughts on this matter. > > Hi Thomas, without the fix it affects both dpdk and non dpdk application use a host or VM. My suggestion to have the fix in and port to 18.11 LTS too. It is changing a behaviour. I propose to test it on 19.02 and backport it in 18.11.1. Any other opinion?