From: Thomas Monjalon <thomas@monjalon.net>
To: Philip Prindeville <philipp_subx@redfish-solutions.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
stable@dpdk.org
Subject: Re: [PATCH 1/1] vfio: Make buildable with MUSL runtime
Date: Tue, 23 May 2023 18:36:55 +0200 [thread overview]
Message-ID: <2165434.C4sosBPzcN@thomas> (raw)
In-Reply-To: <39530A91-B51D-43D7-8D3B-A8E2ABC403C7@redfish-solutions.com>
23/05/2023 17:46, Philip Prindeville:
>
> > On May 23, 2023, at 5:33 AM, Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 22/05/2023 11:27, Burakov, Anatoly:
> >> On 5/20/2023 7:07 PM, Philip Prindeville wrote:
> >>> From: Philip Prindeville <philipp@redfish-solutions.com>
> >>>
> >>> pread64() and pwrite64() are declared in <unistd.h> in MUSL and
> >>> other (i.e. not glibc) C runtimes.
> >>>
> >>> Signed-off-by: Philip Prindeville <philipp@redfish-solutions.com>
> >> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> >
> > It was "buildable" already, and I don't understand how.
> > In any doubt, I've added Cc: stable@dpdk.org for backports.
> >
> > Applied, thanks.
>
> Yeah, it builds with glibc just fine. MUSL is another story...
It is also building on Alpine/musl.
I would like to understand why.
Do you have failure logs and versions?
next prev parent reply other threads:[~2023-05-23 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230520180730.5789-1-philipp@redfish-solutions.com>
[not found] ` <9ebbc874-a6b0-b2f0-8e3b-e1f7d5bd0e8f@intel.com>
2023-05-23 10:33 ` Thomas Monjalon
2023-05-23 15:46 ` Philip Prindeville
2023-05-23 16:36 ` Thomas Monjalon [this message]
2023-05-23 19:00 ` Philip Prindeville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2165434.C4sosBPzcN@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=philipp_subx@redfish-solutions.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).