patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] lib: fix strcat with equivalent logic
@ 2019-02-14  9:30 Chaitanya Babu Talluri
  2019-02-14 14:00 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
  2019-03-08 12:45 ` [dpdk-stable] [PATCH v2] lib/cfgfile: replace strcat with strlcat Chaitanya Babu Talluri
  0 siblings, 2 replies; 7+ messages in thread
From: Chaitanya Babu Talluri @ 2019-02-14  9:30 UTC (permalink / raw)
  To: dev
  Cc: reshma.pattan, cristian.dumitrescu, jananeex.m.parthasarathy,
	Chaitanya Babu Talluri, stable

Replace strcat with concatenation logic to avoid buffer overflow.

Fixes: a6a47ac9c2 ("cfgfile: rework load function")
Cc: stable@dpdk.org

Signed-off-by: Chaitanya Babu Talluri <tallurix.chaitanya.babu@intel.com>
---
 lib/librte_cfgfile/rte_cfgfile.c | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/lib/librte_cfgfile/rte_cfgfile.c b/lib/librte_cfgfile/rte_cfgfile.c
index 7d8c941ea..7616742f7 100644
--- a/lib/librte_cfgfile/rte_cfgfile.c
+++ b/lib/librte_cfgfile/rte_cfgfile.c
@@ -227,7 +227,15 @@ rte_cfgfile_load_with_params(const char *filename, int flags,
 			while (end != NULL) {
 				if (*(end+1) == params->comment_character) {
 					*end = '\0';
-					strcat(split[1], end+1);
+					int index = strlen(split[1]);
+					char *temp = end+1;
+					while (*temp != '\0') {
+						split[1][index] = *temp;
+						index++;
+						temp++;
+					}
+					split[1][index] = '\0';
+
 				} else
 					end++;
 				end = memchr(end, '\\', strlen(end));
-- 
2.17.2

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2019-04-05 12:53 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14  9:30 [dpdk-stable] [PATCH] lib: fix strcat with equivalent logic Chaitanya Babu Talluri
2019-02-14 14:00 ` [dpdk-stable] [dpdk-dev] " Bruce Richardson
2019-03-08 12:45 ` [dpdk-stable] [PATCH v2] lib/cfgfile: replace strcat with strlcat Chaitanya Babu Talluri
2019-03-08 14:02   ` Bruce Richardson
2019-03-08 17:30     ` Ferruh Yigit
     [not found]       ` <761FB0F2AB727F4FA9CE98D18810B0151B1F18AA@BGSMSX103.gar.corp.intel.com>
2019-03-27 11:37         ` Ferruh Yigit
2019-04-05 12:53           ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).