From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 526FAA0561 for ; Fri, 5 Mar 2021 09:56:54 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2FBBC40147; Fri, 5 Mar 2021 09:56:54 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 5E82840147; Fri, 5 Mar 2021 09:56:51 +0100 (CET) IronPort-SDR: SqMxm3BjarzPX2dNEWacOuoMXLNr3fdm4toIRNvX4nDSUl2RFxps8Ly9mKF8jkd6kI59IAb5Vg YQskAg8KeotA== X-IronPort-AV: E=McAfee;i="6000,8403,9913"; a="187661105" X-IronPort-AV: E=Sophos;i="5.81,224,1610438400"; d="scan'208";a="187661105" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2021 00:56:50 -0800 IronPort-SDR: 34d9205rMovFiUSZs9hcTGt6QSXNA5S/PmIaeLJxF1laZhLlD1x1mrKQdpFXPrn/aKO5XQgvVj t8gL2bFTD0/w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,224,1610438400"; d="scan'208";a="587058076" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 05 Mar 2021 00:56:50 -0800 Received: from shsmsx602.ccr.corp.intel.com (10.109.6.142) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 5 Mar 2021 00:56:49 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX602.ccr.corp.intel.com (10.109.6.142) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Fri, 5 Mar 2021 16:56:47 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.013; Fri, 5 Mar 2021 16:56:47 +0800 From: "Zhang, Qi Z" To: "Xing, Beilei" , "Li, Xiaoyun" , "Guo, Jia" , "Lu, Wenzhuo" CC: "dev@dpdk.org" , "stable@dpdk.org" Thread-Topic: [PATCH v2] net/i40e: fix IPv4 fragment offload issue Thread-Index: AQHXDzQRJe9HYwCw2EKM3XJGqflzmap1HHmA Date: Fri, 5 Mar 2021 08:56:47 +0000 Message-ID: <2226b777faf44258aa264e9e2177a75c@intel.com> References: <20210226081438.1693788-1-xiaoyun.li@intel.com> <20210302070320.1872968-1-xiaoyun.li@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH v2] net/i40e: fix IPv4 fragment offload issue X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: dev On Behalf Of Xing, Beilei > Sent: Tuesday, March 2, 2021 3:17 PM > To: Li, Xiaoyun ; Guo, Jia ; Lu, > Wenzhuo > Cc: dev@dpdk.org; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix IPv4 fragment offload is= sue >=20 >=20 >=20 > > -----Original Message----- > > From: Li, Xiaoyun > > Sent: Tuesday, March 2, 2021 3:03 PM > > To: Xing, Beilei ; Guo, Jia > > ; Lu, Wenzhuo > > Cc: dev@dpdk.org; Li, Xiaoyun ; stable@dpdk.org > > Subject: [PATCH v2] net/i40e: fix IPv4 fragment offload issue > > > > IPv4 fragment_offset mask was required to be 0 no matter what the spec > > value was. But zero mask means not caring about fragment_offset field > > then both non-frag and frag packets should hit the rule. > > > > But the actual fragment rules should be like the following: > > Only non-fragment packets can hit Rule 1: > > Rule 1: mask=3D0x3fff, spec=3D0 > > Only fragment packets can hit rule 2: > > Rule 2: mask=3D0x3fff, spec=3D0x8, last=3D0x2000 > > > > This patch allows the above rules. > > > > Fixes: 42044b69c67d ("net/i40e: support input set selection for FDIR") > > Cc: stable@dpdk.org > > > > Signed-off-by: Xiaoyun Li >=20 > Acked-by: Beilei Xing Applied to dpdk-next-net-intel. Thanks Qi