patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [DPDK] bus/ifpga: fix a brackets unmatch
       [not found] <1547445668-15578-1-git-send-email-andy.pei@intel.com>
@ 2019-01-17  5:32 ` Andy Pei
  2019-01-17  8:36   ` Xu, Rosen
  2019-01-18 11:09   ` [dpdk-stable] [PATCH v2] bus/ifpga: fix build for cpp applications Ferruh Yigit
  0 siblings, 2 replies; 4+ messages in thread
From: Andy Pei @ 2019-01-17  5:32 UTC (permalink / raw)
  To: dev; +Cc: rosen.xu, andy.pei, stable

The code

extern "C" {

miss a related

}

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Cc: rosen.xu@intel.com
Cc: stable@dpdk.org

Signed-off-by: Andy Pei <andy.pei@intel.com>
---
 drivers/bus/ifpga/rte_bus_ifpga.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/ifpga/rte_bus_ifpga.h b/drivers/bus/ifpga/rte_bus_ifpga.h
index d53c0f4..0bf43ba 100644
--- a/drivers/bus/ifpga/rte_bus_ifpga.h
+++ b/drivers/bus/ifpga/rte_bus_ifpga.h
@@ -13,7 +13,7 @@
 
 #ifdef __cplusplus
 extern "C" {
-#endif
+#endif /* __cplusplus */
 
 #include <rte_bus.h>
 #include <rte_pci.h>
@@ -143,4 +143,8 @@ struct rte_afu_driver {
 #define RTE_PMD_REGISTER_AFU_ALIAS(nm, alias)\
 static const char *afudrvinit_ ## nm ## _alias = RTE_STR(alias)
 
+#ifdef __cplusplus
+}
+#endif /* __cplusplus */
+
 #endif /* _RTE_BUS_IFPGA_H_ */
-- 
1.8.3.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [DPDK] bus/ifpga: fix a brackets unmatch
  2019-01-17  5:32 ` [dpdk-stable] [DPDK] bus/ifpga: fix a brackets unmatch Andy Pei
@ 2019-01-17  8:36   ` Xu, Rosen
  2019-01-18 11:09   ` [dpdk-stable] [PATCH v2] bus/ifpga: fix build for cpp applications Ferruh Yigit
  1 sibling, 0 replies; 4+ messages in thread
From: Xu, Rosen @ 2019-01-17  8:36 UTC (permalink / raw)
  To: Pei, Andy, dev; +Cc: stable

Hi,

> -----Original Message-----
> From: Pei, Andy
> Sent: Thursday, January 17, 2019 13:32
> To: dev@dpdk.org
> Cc: Xu, Rosen <rosen.xu@intel.com>; Pei, Andy <andy.pei@intel.com>;
> stable@dpdk.org
> Subject: [DPDK] bus/ifpga: fix a brackets unmatch

I think it's v2 patch, so pls identify it.
For the title, I think this one could be better.

C linkage names declaration brackets mismatch

> The code
> 
> extern "C" {
> 
> miss a related
> 
> }
Pls descript it in detail not in demo code.

> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> Cc: rosen.xu@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> ---
>  drivers/bus/ifpga/rte_bus_ifpga.h | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/bus/ifpga/rte_bus_ifpga.h
> b/drivers/bus/ifpga/rte_bus_ifpga.h
> index d53c0f4..0bf43ba 100644
> --- a/drivers/bus/ifpga/rte_bus_ifpga.h
> +++ b/drivers/bus/ifpga/rte_bus_ifpga.h
> @@ -13,7 +13,7 @@
> 
>  #ifdef __cplusplus
>  extern "C" {
> -#endif
> +#endif /* __cplusplus */
> 
>  #include <rte_bus.h>
>  #include <rte_pci.h>
> @@ -143,4 +143,8 @@ struct rte_afu_driver {  #define
> RTE_PMD_REGISTER_AFU_ALIAS(nm, alias)\  static const char *afudrvinit_ ##
> nm ## _alias = RTE_STR(alias)
> 
> +#ifdef __cplusplus
> +}
> +#endif /* __cplusplus */
> +
>  #endif /* _RTE_BUS_IFPGA_H_ */
> --
> 1.8.3.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-stable] [PATCH v2] bus/ifpga: fix build for cpp applications
  2019-01-17  5:32 ` [dpdk-stable] [DPDK] bus/ifpga: fix a brackets unmatch Andy Pei
  2019-01-17  8:36   ` Xu, Rosen
@ 2019-01-18 11:09   ` Ferruh Yigit
  2019-01-18 18:57     ` Thomas Monjalon
  1 sibling, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2019-01-18 11:09 UTC (permalink / raw)
  To: dev, Rosen Xu; +Cc: Andy Pei, stable

From: Andy Pei <andy.pei@intel.com>

Brackets unmatch when __cplusplus defined.

Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
Cc: stable@dpdk.org

Signed-off-by: Andy Pei <andy.pei@intel.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: rosen.xu@intel.com
---
 drivers/bus/ifpga/rte_bus_ifpga.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/bus/ifpga/rte_bus_ifpga.h b/drivers/bus/ifpga/rte_bus_ifpga.h
index d53c0f483..0bf43ba88 100644
--- a/drivers/bus/ifpga/rte_bus_ifpga.h
+++ b/drivers/bus/ifpga/rte_bus_ifpga.h
@@ -13,7 +13,7 @@
 
 #ifdef __cplusplus
 extern "C" {
-#endif
+#endif /* __cplusplus */
 
 #include <rte_bus.h>
 #include <rte_pci.h>
@@ -143,4 +143,8 @@ RTE_PMD_EXPORT_NAME(nm, __COUNTER__)
 #define RTE_PMD_REGISTER_AFU_ALIAS(nm, alias)\
 static const char *afudrvinit_ ## nm ## _alias = RTE_STR(alias)
 
+#ifdef __cplusplus
+}
+#endif /* __cplusplus */
+
 #endif /* _RTE_BUS_IFPGA_H_ */
-- 
2.17.2

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH v2] bus/ifpga: fix build for cpp applications
  2019-01-18 11:09   ` [dpdk-stable] [PATCH v2] bus/ifpga: fix build for cpp applications Ferruh Yigit
@ 2019-01-18 18:57     ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2019-01-18 18:57 UTC (permalink / raw)
  To: Ferruh Yigit, Andy Pei; +Cc: stable, dev, Rosen Xu

18/01/2019 12:09, Ferruh Yigit:
> From: Andy Pei <andy.pei@intel.com>
> 
> Brackets unmatch when __cplusplus defined.
> 
> Fixes: 05fa3d4a6539 ("bus/ifpga: add Intel FPGA bus library")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Andy Pei <andy.pei@intel.com>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-01-18 18:57 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <1547445668-15578-1-git-send-email-andy.pei@intel.com>
2019-01-17  5:32 ` [dpdk-stable] [DPDK] bus/ifpga: fix a brackets unmatch Andy Pei
2019-01-17  8:36   ` Xu, Rosen
2019-01-18 11:09   ` [dpdk-stable] [PATCH v2] bus/ifpga: fix build for cpp applications Ferruh Yigit
2019-01-18 18:57     ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).