patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Luca Boccassi <bluca@debian.org>
To: Gavin Hu <gavin.hu@arm.com>, stable@dpdk.org
Cc: nd@arm.com
Subject: Re: [dpdk-stable] [PATCH 17.11] net/bnxt: replace memory barrier for doorbell response
Date: Tue, 07 Jan 2020 11:35:11 +0000
Message-ID: <224dc0391e55aecd40428ebb0c1a3bd4afa77a2a.camel@debian.org> (raw)
In-Reply-To: <95e5fbcfa5385fa7a9afb8ef1f5ec65599d4ea94.camel@debian.org>

On Tue, 2020-01-07 at 11:25 +0000, Luca Boccassi wrote:
> On Thu, 2020-01-02 at 15:20 +0800, Gavin Hu wrote:
> > [ upstream commit 21ecbde99b2f0772d36eef8276a686f3135e5de9 ]
> > 
> > To read the doorbell response, which is held in the host CIO
> > memory,
> > rte_cio_rmb is sufficient.
> > 
> > Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init
> > code")
> > 
> > Signed-off-by: Gavin Hu <gavin.hu@arm.com>
> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > ---
> >  drivers/net/bnxt/bnxt_hwrm.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Thanks, applied

Actually, this doesn't compile as rte_cio_rmb is not available in
17.11:

drivers/net/bnxt/bnxt_hwrm.c: In function ‘bnxt_hwrm_send_message’:
drivers/net/bnxt/bnxt_hwrm.c:151:3: error: implicit declaration of
function ‘rte_cio_rmb’; did you mean ‘rte_io_rmb’? [-Werror=implicit-
function-declaration]
   rte_cio_rmb();
   ^~~~~~~~~~~
   rte_io_rmb

It was added by the following commits:

52bd60a5cf0b ("eal/arm64: define coherent I/O memory barriers")
bbc504dfbb5e ("eal/arm32: define coherent I/O memory barriers")
cbb3c4162899 ("eal/ppc64: define coherent I/O memory barriers")
0079e4fb6922 ("eal/x86: define coherent I/O memory barriers")
cd36cc49e59c ("eal: introduce coherent I/O memory barriers")

Should I drop this patch for this release?

-- 
Kind regards,
Luca Boccassi

      reply	other threads:[~2020-01-07 11:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-02  7:20 Gavin Hu
2020-01-07 11:25 ` Luca Boccassi
2020-01-07 11:35   ` Luca Boccassi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=224dc0391e55aecd40428ebb0c1a3bd4afa77a2a.camel@debian.org \
    --to=bluca@debian.org \
    --cc=gavin.hu@arm.com \
    --cc=nd@arm.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git