From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 139D9A04F6 for ; Tue, 7 Jan 2020 12:35:15 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E98021D73A; Tue, 7 Jan 2020 12:35:14 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id E8ED31D73A for ; Tue, 7 Jan 2020 12:35:13 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id m24so18576786wmc.3 for ; Tue, 07 Jan 2020 03:35:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Su0sNpQqkJKi6MU1k1hOCAs3H6ElDuBiFNPSJHnYGHQ=; b=bRZqjF5QlVfpmEMk5d0lhblUbZbN3mFBGpqmsYkoD4VtGu0l3IApM/CN46pd489FSs PcwCuH6w+UWP0EhEbUTnXB5tQG22bHtz6/7IJU1TtncdZbXLQrQpM3Jwve3dM70c903o OTsr/R7ispVPr7NYH1t3nXB2Dpdx2iUKV3eGzEfmYFEpBIb0FMveloYOQNF4hKzHesq8 s7PlpTwMo2S6qb+9yAldQFgPXSDl25gKS0omn2Ltd3ztaGvFr3cdJ8k1h99TyBsIPYQf 1Duqjg/9FrQtCo4S2bA/Vwg9Pg2S/+hIP6jBmekN5KyW1o3wW5OjgotYdWy2cysoD12/ NBIQ== X-Gm-Message-State: APjAAAV6zFcXiMFFWTLN+nxa9W6iUz4RTsiy9E5H6cMvIrJfanVcvMnE xph+ruQoOUcgapW8XU4zYlo= X-Google-Smtp-Source: APXvYqxV4TGQDPVyVJ+Nq9J2AjeIGnpGgCXmU+0ga+1bPwuWL7NVCMrAK4aiMGwCaBKmBEl3UfPLzw== X-Received: by 2002:a05:600c:2148:: with SMTP id v8mr41641752wml.111.1578396912894; Tue, 07 Jan 2020 03:35:12 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id x132sm25886331wmg.0.2020.01.07.03.35.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 Jan 2020 03:35:12 -0800 (PST) Message-ID: <224dc0391e55aecd40428ebb0c1a3bd4afa77a2a.camel@debian.org> From: Luca Boccassi To: Gavin Hu , stable@dpdk.org Cc: nd@arm.com Date: Tue, 07 Jan 2020 11:35:11 +0000 In-Reply-To: <95e5fbcfa5385fa7a9afb8ef1f5ec65599d4ea94.camel@debian.org> References: <1577949613-31889-1-git-send-email-gavin.hu@arm.com> <95e5fbcfa5385fa7a9afb8ef1f5ec65599d4ea94.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-stable] [PATCH 17.11] net/bnxt: replace memory barrier for doorbell response X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" On Tue, 2020-01-07 at 11:25 +0000, Luca Boccassi wrote: > On Thu, 2020-01-02 at 15:20 +0800, Gavin Hu wrote: > > [ upstream commit 21ecbde99b2f0772d36eef8276a686f3135e5de9 ] > >=20 > > To read the doorbell response, which is held in the host CIO > > memory, > > rte_cio_rmb is sufficient. > >=20 > > Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init > > code") > >=20 > > Signed-off-by: Gavin Hu > > Acked-by: Ajit Khaparde > > --- > > drivers/net/bnxt/bnxt_hwrm.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > Thanks, applied Actually, this doesn't compile as rte_cio_rmb is not available in 17.11: drivers/net/bnxt/bnxt_hwrm.c: In function =E2=80=98bnxt_hwrm_send_message= =E2=80=99: drivers/net/bnxt/bnxt_hwrm.c:151:3: error: implicit declaration of function =E2=80=98rte_cio_rmb=E2=80=99; did you mean =E2=80=98rte_io_rmb=E2= =80=99? [-Werror=3Dimplicit- function-declaration] rte_cio_rmb(); ^~~~~~~~~~~ rte_io_rmb It was added by the following commits: 52bd60a5cf0b ("eal/arm64: define coherent I/O memory barriers") bbc504dfbb5e ("eal/arm32: define coherent I/O memory barriers") cbb3c4162899 ("eal/ppc64: define coherent I/O memory barriers") 0079e4fb6922 ("eal/x86: define coherent I/O memory barriers") cd36cc49e59c ("eal: introduce coherent I/O memory barriers") Should I drop this patch for this release? --=20 Kind regards, Luca Boccassi