From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2455D43D14
	for <public@inbox.dpdk.org>; Thu, 21 Mar 2024 12:18:12 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1CA4042830;
	Thu, 21 Mar 2024 12:18:12 +0100 (CET)
Received: from wfout6-smtp.messagingengine.com
 (wfout6-smtp.messagingengine.com [64.147.123.149])
 by mails.dpdk.org (Postfix) with ESMTP id 50F28427E1;
 Thu, 21 Mar 2024 12:18:11 +0100 (CET)
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailfout.west.internal (Postfix) with ESMTP id C4F961C000B3;
 Thu, 21 Mar 2024 07:18:06 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Thu, 21 Mar 2024 07:18:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:cc:content-transfer-encoding:content-type:content-type:date
 :date:from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to; s=fm2; t=1711019886;
 x=1711106286; bh=Obojcrox2e07KyVNkZysjQkAlx93fR4+2TZqio4d/Bs=; b=
 gIHUVrZKXuMoFaNqMUlfL8wvt3OK9J7qVirsLyHMQPfYZkqJwRHbbaV3hA5842nI
 J9Eyksfb3i7ycEnKUr95/uDhlbk9w0n/UrN9lbtD4FCyCTRU3t6/XFWYJrk8G5kP
 4nDgp3QNn4zsheC4o6stFe4qX0RN3uB2BZ3pIMeaqqcjmsAjBhEdJGxwWPjKd00P
 TQJ63A3R2h3PV3JqwUgUGb7ZQdF5JgfwyDZ5xIgeRjXbVAdJjuHH0zeAfYpfCgyb
 9WnJKY4/7zrmAXr5gBy40jcu72I9cgQ7R8audz/jQQiMKbl2DYDkA43/g/lIrqOf
 rue2JX+6/oEjmiiqAo63DQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-transfer-encoding
 :content-type:content-type:date:date:feedback-id:feedback-id
 :from:from:in-reply-to:in-reply-to:message-id:mime-version
 :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1711019886; x=
 1711106286; bh=Obojcrox2e07KyVNkZysjQkAlx93fR4+2TZqio4d/Bs=; b=f
 jGOEf2Cp4gPZ+oZ+WOX/OW/zWUwML4bcXTzX0ussdpM1yAyYYnCPQcL8QciPKiJl
 3/64zOtDT6LoCQRshPzA1GDePOqqCop8+8R//Zk6yM15Ya0KVsm/FwWCa1LUBZGS
 RLHSM7ogEL9Sre4CLZoMRXosY4D3Ecgf9XNRtb0tcfjPOzGgg9vm5K1TeGcQ/hsV
 12ewP6q5CcGmkQRBpY4265FOYZrPJxKOGnZ0CespD0wtU9fvbV7AsPKwOfXZtrvQ
 QuCrdgBElRUq+Z8hBF3ERAmKw2HRu5cDwX4wlUz1io4b9AD/JQr9PzQlh/9G4ypt
 zVKQZygJx5mOjm+n1cDlg==
X-ME-Sender: <xms:bRf8ZaiSGTwgDXz1HLclgyMhsWolYhrsWV-tmToQBoVkzdKYv37LAQ>
 <xme:bRf8ZbB9fLsrc96EFtg_hHiXoalKeO0jIX50AeX-aba1CFp8kUw-zea70G9NqxMxb
 0YL46dn__19e907kA>
X-ME-Received: <xmr:bRf8ZSH8jSKWMysPSofBiivHxP3BqWzpjbcWMxhVBfBsLAYJ3CNpI41zyIQKD1oWLa-A3zEDFTGHbD217CBRmhsVAQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrleeigddviecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvfevufffkfgjfhgggfgtsehtqhertddttdejnecuhfhrohhmpefvhhhomhgr
 shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
 ftrfgrthhtvghrnhepgedttdeljeejgeffkeekkedtjeevtdehvedtkeeivdeuuedviedu
 vdelveejueejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
 homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:bRf8ZTRsSZjKsW59cJ88o76TsU7pQ15LCOhggvpldB8HW7TdB3jXQw>
 <xmx:bRf8ZXyOreLDnSJTMJ0clreRWgY6oCHly9C2laQmyPiyux12gucIkQ>
 <xmx:bRf8ZR6vH9XX9euwQLlLd4omLqcchocCPQI8FNDs_UI7P6yfwwVxXw>
 <xmx:bRf8ZUwVGBzhxoNlg6ubVk-ysz6sbo9-m882kpzTx5R0yY-uKbFDUw>
 <xmx:bhf8ZXDxdLI9KL14mVBnPXYGkdgyQLUblyRBTR-Ih7aZ1Mk7wdude4w8Zmc>
Feedback-ID: i47234305:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu,
 21 Mar 2024 07:18:03 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "Tummala, Sivaprasad" <Sivaprasad.Tummala@amd.com>
Cc: "david.hunt@intel.com" <david.hunt@intel.com>,
 "anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
 "jerinj@marvell.com" <jerinj@marvell.com>,
 "radu.nicolau@intel.com" <radu.nicolau@intel.com>,
 "gakhil@marvell.com" <gakhil@marvell.com>,
 "cristian.dumitrescu@intel.com" <cristian.dumitrescu@intel.com>,
 "Yigit, Ferruh" <Ferruh.Yigit@amd.com>,
 "konstantin.ananyev@huawei.com" <konstantin.ananyev@huawei.com>,
 "stephen@networkplumber.org" <stephen@networkplumber.org>,
 "david.marchand@redhat.com" <david.marchand@redhat.com>,
 "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>,
 Morten =?ISO-8859-1?Q?Br=F8rup?= <mb@smartsharesystems.com>
Subject: Re: [PATCH v5 1/6] examples/l3fwd: fix lcore ID restriction
Date: Thu, 21 Mar 2024 12:18:01 +0100
Message-ID: <2343618.ECZNHGQPT7@thomas>
In-Reply-To: <CH3PR12MB82338AB7AF9C947007CB3A3F86322@CH3PR12MB8233.namprd12.prod.outlook.com>
References: <20240116182332.95537-1-sivaprasad.tummala@amd.com>
 <2714554.uZKlY2gecq@thomas>
 <CH3PR12MB82338AB7AF9C947007CB3A3F86322@CH3PR12MB8233.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="utf-8"
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

21/03/2024 12:05, Tummala, Sivaprasad:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 19/03/2024 08:24, Morten Br=C3=B8rup:
> > > > From: Sivaprasad Tummala [mailto:sivaprasad.tummala@amd.com]
> > > > Sent: Monday, 18 March 2024 18.32
> > > >
> > > > Currently the config option allows lcore IDs up to 255, irrespective
> > > > of RTE_MAX_LCORES and needs to be fixed.
> > > >
> > > > The patch allows config options based on DPDK config.
> > > >
> > > > Fixes: af75078fece3 ("first public release")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: Sivaprasad Tummala <sivaprasad.tummala@amd.com>
> > > > Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
> > > > ---
> > >
> > > I suggest you update the description of the individual patches too, l=
ike you did
> > for patch 0/6.
> > >
> > > E.g. this patch not only fixes the lcore_id, but also the queue_id ty=
pe size.
> > >
> > >
> > > For the series,
> > > Acked-by: Morten Br=C3=B8rup <mb@smartsharesystems.com>
> >
> > I would recommend a separate patch for queue id as it is a separate iss=
ue.
> > However, there is no need to split per directory.
> > You can have patches changing all examples at once.
> >
> There's a functional dependency and queue id change is required to support
> higher lcore IDs and hence it makes sense to add in the same patch.
> I had split the examples to help the maintainers review the patches indiv=
idually.
> Please feel free to squash the git commits while merging.

Then if there is a dependency, please make queue id the first patch.