patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] net: fix Tx VLAN flag for offload emulation
@ 2019-03-25 15:05 Chas Williams
  2019-03-26 16:50 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
  2019-04-04 17:07 ` Ferruh Yigit
  0 siblings, 2 replies; 5+ messages in thread
From: Chas Williams @ 2019-03-25 15:05 UTC (permalink / raw)
  To: dev; +Cc: olivier.matz, Bill Hong, stable, Chas Williams

From: Bill Hong <bhong@brocade.com>

A PMD might use rte_vlan_insert to implement Tx VLAN offload.  Typically
the PMD will insert the VLAN header in the transmit path and then attempt
to send the packets. If this fails, the packets are returned to
the application which may attempt to send these packets again. If the
PKT_TX_VLAN flag is not cleared, the transmit path may attempt to insert
the VLAN header again.

Fixes: 47aa48b969f8 ("net: fix stripped VLAN flag for offload emulation");
Cc: stable@dpdk.org

Signed-off-by: Bill Hong <bhong@brocade.com>
Signed-off-by: Chas Williams <chas3@att.com>
---
 lib/librte_net/rte_ether.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h
index c2c5e249f..e0d831113 100644
--- a/lib/librte_net/rte_ether.h
+++ b/lib/librte_net/rte_ether.h
@@ -408,7 +408,7 @@ static inline int rte_vlan_insert(struct rte_mbuf **m)
 	vh = (struct vlan_hdr *) (nh + 1);
 	vh->vlan_tci = rte_cpu_to_be_16((*m)->vlan_tci);
 
-	(*m)->ol_flags &= ~PKT_RX_VLAN_STRIPPED;
+	(*m)->ol_flags &= ~(PKT_RX_VLAN_STRIPPED | PKT_TX_VLAN);
 
 	return 0;
 }
-- 
2.17.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-04-04 17:07 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-25 15:05 [dpdk-stable] [PATCH] net: fix Tx VLAN flag for offload emulation Chas Williams
2019-03-26 16:50 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
2019-03-26 18:01   ` Chas Williams
2019-04-01 20:17     ` Ferruh Yigit
2019-04-04 17:07 ` Ferruh Yigit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).