Re: [dpdk-stable] [PATCH v2] net/iavf: support multicast configuration

["Zhang, Qi Z" <qi.z.zhang@intel.com>]

> -----Original Message-----
> From: Luca Boccassi <bluca@debian.org>
> Sent: Wednesday, October 28, 2020 7:20 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: stable@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; Zhao1, Wei
> <wei.zhao1@intel.com>
> Subject: Re: [dpdk-stable] [PATCH v2] net/iavf: support multicast configuration
> 
> On Sat, 2020-10-10 at 10:53 +0800, Qi Zhang wrote:
> > [ upstream commit 05e4c3aff35f41d527acfab86df55477fd8dcff2 ]
> >
> > This patch enable add multicast address for iavf.
> >
> > Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> > Acked-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> >
> > To maintainer:
> >
> > I know this is not a fix, but this is requested by an important
> > customer that will use DPDK 19.11 LTS, meanwhile this patch just add a
> > missing eth_dev op in AVF, it has low risk to bring any side effect.
> >
> >  doc/guides/nics/features/iavf.ini |  1 +
> >  drivers/net/iavf/iavf.h           |  7 ++++
> >  drivers/net/iavf/iavf_ethdev.c    | 43 ++++++++++++++++++++++++
> >  drivers/net/iavf/iavf_vchnl.c     | 56
> +++++++++++++++++++++++++++++++
> >  4 files changed, 107 insertions(+)
> 
> Next time please follow the guidelines and use --subject-prefix='PATCH 19.11'
> when sending, otherwise the mail gets filtered out.

Got it, thanks.

> 
> What happens if someone upgrades from 19.11.6 with this patch, to say
> 20.08 which doesn't have it? Are there hard errors, or will the feature simply
> be ignored?

I think the unsupported error should be returned.
but I don't think this will be the real case, usually when a user current stick on 19.11 decide to upgrade, it will move to 20.11 directly.

Thanks
Qi

> 
> --
> Kind regards,
> Luca Boccassi