From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC098431EF for ; Tue, 24 Oct 2023 11:03:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF68F40A87; Tue, 24 Oct 2023 11:03:43 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 54FDE40285; Tue, 24 Oct 2023 11:03:40 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698138220; x=1729674220; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=LmWKkWVxaiB5T4zyNAlaSm7tm/68HmYEGv4t9fRNt1E=; b=F+5yEST+uV4X5l1o/cwK83FANrbmqFJvQPQSgPePi682Lh1Mn6OGOoxL OITAVkrkBO/2z0RQknKDxezgst3uMDovt5YA7hgOfX5CGw4kgrkf56cjo 57qFK5/gOQ8eFjW6CbZ6Jonmlu8LrWNt6VW9priLas5WcCn+Wz43c8dVG FRoVjExqHXYma5ANFG809jRBcGUqp/atyntzA4CjF5pT9R/SR6HIeL1Tn h6zJVg89l6sjAexSsLi6Fs3S/D9tNRX5zcf6tc2SUQqps+1NjLQ3XAoLV PepFCRKutmesjVfdxz572U+QsRzF7pQc5PG+r4vSde+U7wCEP2T24baQg w==; X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="453475869" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="453475869" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 02:03:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10872"; a="828749828" X-IronPort-AV: E=Sophos;i="6.03,247,1694761200"; d="scan'208";a="828749828" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga004.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Oct 2023 02:03:21 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Tue, 24 Oct 2023 02:03:20 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32 via Frontend Transport; Tue, 24 Oct 2023 02:03:20 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.32; Tue, 24 Oct 2023 02:03:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gBMCRhFMX3j/Gwl9lcsqromrkndMA0stO2uGXBMEKV2GE1GQXXe05Pz6L7oU+VWpRlOHFKJy7kUEsVzem/9YfpCji8fDCUPXubJ9AP9u4LL+4u0rS2jHuhlB3iS1NCOrCx69NxKVCDX0TFEWVcRGieSvGwhrcGb3wFz7r/NEgmln6NQqwuefgg3zkC7TMAgeHAPlJxVMnpJMnse3SNRAmfUnRvRuNS2ybs6dtmfq45ymM3Ri1Ar2jKlXu3MQE0iesAVi63AwGZJ+SjUvrp+15S/PFn8hq3tjoIywUlJbcqBWrgb+A5JuPFXnIOuVm4K7l4NaX48HpCSMGYSHFvXAUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZrSCZoY64WfzJ5Zk3ZXQN3VMmOwmebnqGYdqJBWP/dg=; b=BmMFuh9GPeahjFkv7GLS91Vvy62HBe4yuAK76TqldzNkH1+9Sq+7AMgS9eJrmGljAi/WlGIgzWTzvUxa/lzxNgpMbZi8opbgRshOFpHhTPew1Ke0uLzBDaDXJZ2fCesSzXg6GLs7tQyjPT1n1yprd7LMgJqk+bHKg3zenml7E4QD4we1AZFYPOBy10KTid94XG/W3pGlb4D6KPc/x16gs97j8i6mNAPg7UQO9O2qsgGBCvZedz3CqsXiA3/elUeKusyLbpQ5jsW3diVGBHcL9zpKdslZYsr7KT5ZJnrTslRdhVaibRZRSzEmXgPwLdLrB/wfdYaUJSo/lhq/s9V3Hw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) by CH0PR11MB5561.namprd11.prod.outlook.com (2603:10b6:610:d4::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33; Tue, 24 Oct 2023 09:03:19 +0000 Received: from DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::9818:3765:1b10:1c5a]) by DM8PR11MB5653.namprd11.prod.outlook.com ([fe80::9818:3765:1b10:1c5a%7]) with mapi id 15.20.6907.032; Tue, 24 Oct 2023 09:03:19 +0000 Message-ID: <25b95ddc-3cc5-a715-2160-f04a7145a92e@intel.com> Date: Tue, 24 Oct 2023 10:03:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] net/iavf: fix Tx offloading flags check Content-Language: en-US To: David Marchand CC: "Zhang, Qi Z" , "Wu, Jingjing" , "Xing, Beilei" , "dev@dpdk.org" , "stable@dpdk.org" , "Ferruh Yigit" , Thomas Monjalon , "Akhil Goyal" References: <20231023163803.98455-1-radu.nicolau@intel.com> From: Radu Nicolau In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DB7PR02CA0024.eurprd02.prod.outlook.com (2603:10a6:10:52::37) To DM8PR11MB5653.namprd11.prod.outlook.com (2603:10b6:8:25::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM8PR11MB5653:EE_|CH0PR11MB5561:EE_ X-MS-Office365-Filtering-Correlation-Id: 537dfc9e-1cd3-4bfa-1a18-08dbd47010e8 X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hlR/R22qn8MeU4XE0/5sFIFk0A9mA4WmGi96lDj073bTEjmLMDHp40RVkBulUfzzbcS5DUbIwxnfmnMY6KwEP9GD51ZkRrTT8z6kgxlYDTxfox/dl+xc0jySlf5C/0QJChlO46srDJmYsrhLbZXT7ck8O+TkIW2AK4QYgVJyEdLrQXt4BFG/td2Hp3ezaaRmkWW/1H+Uc4OdLX7bifpHvLkp0oifXS3jyp6j+TogjDD/7K69vp9n5iTLbid1FXl5lWxqpwNLCbhI8/VY0E6lds2iHatUlR1ETFCYm7jBZ8ynrs6F8b4ys7d6HFAUlVjD/Eli6b8zVwn6NOcH5oar8RU9zXdsdg7QwBx3N5mX8S4hyzpcuOoKdC06G217bD1ZfKgFLcYjdbSxap9zNrfWZ89Msmr2XhibkIfihDL5H1p7xpXi9KkXO9MXwJXvbFp7fjRn3H03tbe2XDzC/4KAuj5vdjGp+8IkxhDAPTay/euaXdG30k2eHepuYj0xVR4O9nTS/vzpj1FGIu/++RIXnfWaOncDFvC+10YoCv/25VL1J5yl2flzOdwp776fd54SHu2IGlPUnma04M0IcgOgqxuckkoVdImoaQpeCEyiyEfjPcDuF3Xua9Goe9XsB/HwLhcGDRvVErLZq+vad0VYxg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM8PR11MB5653.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(136003)(376002)(396003)(366004)(39860400002)(346002)(230922051799003)(186009)(451199024)(1800799009)(64100799003)(31686004)(316002)(8936002)(8676002)(4326008)(54906003)(44832011)(41300700001)(5660300002)(83380400001)(2616005)(6916009)(2906002)(55236004)(6506007)(53546011)(38100700002)(6512007)(66476007)(66946007)(66556008)(36756003)(26005)(82960400001)(478600001)(86362001)(6666004)(31696002)(6486002)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QzBISlBwWEJ6RVJMaHZhTGQ3ZmlNb200VUNRTXkzQlRKSSt4YUdWV1BEeHNw?= =?utf-8?B?WTVPUDV2elpJa0hjUFFQV0tkTzhCYWM2QWlGRDBXVmRWdWRNSk1XWWNSOVh4?= =?utf-8?B?NkZaektKUk9IdHlUaG9KWVNRcWlXM0dPWWpRVWw4VE5pUkk5VGNreEcyT2JX?= =?utf-8?B?VlphcWVoZ3I5TGdNYTBzbkt6bTNhU3Blc0c2bW4yZWNvVW1SSVkxbVhybjlS?= =?utf-8?B?a0loeitRVkloSVB0NVBva1VudGl6RGxVbHl2Nksyb0h1TEJsV25icytyb20x?= =?utf-8?B?RmxJT2JEb3lpajJFR2ppRlF1RXp0TmxsQnVTRUVxeU1WOUNQeUMzL2hnUlMr?= =?utf-8?B?THZibFRoMFhZVG9KV1IzR0M4UC9MTTFPUEduWUszQkFNeWtoeFhWN3NTTkc3?= =?utf-8?B?WVlQbWdFNzhNYnZDcld6ZVpEODBQc2RHNjBKWFVFMC83YlVab29NSndQU2dK?= =?utf-8?B?azEvNnJiaCtRMGlsUUkwMElDMTBBV1JjK1RSSFl6THUwT0pmWVFCc0V6TW5v?= =?utf-8?B?ME5icWNBbXA2RVI4bThnM1dDK2VEL2w2QlpXNDVTcFJRU09uazdtQXg3L0VN?= =?utf-8?B?YW15OU81TXFLRURJN3dTVS9SemNQdERWVTdhdEtGZ1EvZ20zNXJvWlluOW1K?= =?utf-8?B?UnhRMVgrOXhZb21kb1F3V1UwczRJU2tRMEozdEN4R3ZLZDFlcDFLdXZxWE41?= =?utf-8?B?a3Npa1JVcmljLzJLWDZTenVhM1U4Uy9tbnpjcG5uUFQrRFFINzd3Tm9jejE5?= =?utf-8?B?dDN1bHBtVmR0U0NzZkZCdGZyL2RRb2JhVG83TzNyb3J4YTQ1S3A5VTFNVEZl?= =?utf-8?B?cTZ0UUxkdk5tRE85Nnl2UDk0L2lBTUwrV1JWZnNkSVh5UThTZXMydWpGVU1I?= =?utf-8?B?SlVOcVMvZSs3MDFKekhnYitpOTBSd0poVDA1Sk5XdzFBVkVrcEtKUWtITm5S?= =?utf-8?B?K0JFNUZXeFVzRUE4dmFSc1VZRW54NTdGUW55SGxyOG5Ma1lVVjdzYnlIR29w?= =?utf-8?B?U2ZsZUNjWWR3MWVCQ1BnWTNTQVJma1BoUWFyTDFwdWNRV1NXYXVtYXY3MklL?= =?utf-8?B?K3ZFN0RHeGtQVnVmNnhVNDNyVVlqT0w2MW5zTUNjTWZQWUgxLzNweW1ZUGV6?= =?utf-8?B?SU1BYWs5ZmVVL0VDSzZDQm1WQktyQ29oM2llWStxajN3ZlA0TE5ub2paZ2ZJ?= =?utf-8?B?MkROSTNadTZoaGppNHYzUVpWdFNDanhHTVJ0b21QN1BkZCt4V2xhN0xaOW9X?= =?utf-8?B?ajJVa0xwK0Q3ZlFxeklYU0pobG54dkxreDVRUk9LTHVoTjFDeUovNUt2djQ2?= =?utf-8?B?WmZMK0lXVUc4Zkx6RERFVE04SGprU1VMQmx4QlBFWHdobkpvWHhmaTFHWWFU?= =?utf-8?B?ZHNpZFJENW1aWjlZL200UVAyNElraFpnQnJMNHl4cWhoTDQ2Z0xOV2FvYXFr?= =?utf-8?B?WFVJOUV1SDBNOGNob3RFN1B0ZDJKazF5T0pZNFF3UEh6SkMyM25OMCtUU1JS?= =?utf-8?B?NzFhSS9XTGd2SzJ4eGs1bWNRbUZGbzRtcFhaZE1JNlJhbVVab0ljaXhRU3VF?= =?utf-8?B?NC9OOUxJRnVYQU5hUEUwY0pOaHJXa3R4YWlCbUpLRzhLVExsaHQwYUVha1NP?= =?utf-8?B?OGhJYzdHTE5CZjA0QUpsczRWblZGNFNka2poL3p4c0hHZjhKaTdBK0lZNXhR?= =?utf-8?B?cXhwWVNxNjZvSWEvTTBZa3M0VUQ3RmFzcFNScHJRcjNIbVEwdytCR2RlOTRp?= =?utf-8?B?dFp5emw0TmZldFYrb2Y0UGNaQ1YzcGl2UFZRNWlySzRpRDJmdms3VGRwSkFR?= =?utf-8?B?c0pOMHlBZnV1Y0pNY2puUTFNUjVkTWhNUU1RdEk4WFJSNHVBZjl0M2VJZWVq?= =?utf-8?B?SkpaQlBMbzU3YXNTQXdXV0pUMk5MNFVZRER1SjRjaWZsSEJ3QTVWMFZHbVht?= =?utf-8?B?Y3N5dEgyYXVIQVQwWmgvQWh4c0hpZktqYStzVElXaDZhUmZPMXFsV1ZwNHpZ?= =?utf-8?B?azh0UXI4SjFndHdCQ2FiV2RHcjJTYVF5bWkxNXdBN0JzUXhVSE5pYkNmWnFX?= =?utf-8?B?WVlpOXlteWRuc2JkdjZFMnloZmowZTRwc0YxaGNiMm54VWJDNUNldHBGRFN1?= =?utf-8?B?ZHNHcnl6bnlERmgwMlhSd2o5RUNCcjl5a2FyTGhjT2xHaEFQZy9mUkxaK1c2?= =?utf-8?B?Znc9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 537dfc9e-1cd3-4bfa-1a18-08dbd47010e8 X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5653.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Oct 2023 09:03:19.0552 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: LHHABZlkWHdan9omcD+Ne9AlRyUWPkHhEuiADH2nh8VMTY3P4ojHTgUwXtuzg0le8McImgjlMp2HBVgHoDx2mw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5561 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 24-Oct-23 9:44 AM, David Marchand wrote: > On Tue, Oct 24, 2023 at 10:40 AM Radu Nicolau wrote: >> >> On 24-Oct-23 6:42 AM, Zhang, Qi Z wrote: >>>> -----Original Message----- >>>> From: Radu Nicolau >>>> Sent: Tuesday, October 24, 2023 12:38 AM >>>> To: Wu, Jingjing ; Xing, Beilei >>>> Cc: dev@dpdk.org; Nicolau, Radu ; >>>> stable@dpdk.org; Marchand, David >>>> Subject: [PATCH] net/iavf: fix Tx offloading flags check >>>> >>>> Use IAVF_TX_OFFLOAD_MASK flags instead of >>>> IAVF_TX_CKSUM_OFFLOAD_MASK. >>>> >>>> Fixes: 3c715591ece0 ("net/iavf: fix checksum offloading") >>>> Cc: stable@dpdk.org >>>> Cc: david.marchand@redhat.com >>>> >>>> Signed-off-by: Radu Nicolau >>>> --- >>>> drivers/net/iavf/iavf_rxtx.c | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index >>>> c6ef6af1d8..85f8c141ce 100644 >>>> --- a/drivers/net/iavf/iavf_rxtx.c >>>> +++ b/drivers/net/iavf/iavf_rxtx.c >>>> @@ -2664,7 +2664,7 @@ iavf_build_data_desc_cmd_offset_fields(volatile >>>> uint64_t *qw1, >>>> l2tag1 |= m->vlan_tci; >>>> } >>>> >>>> - if ((m->ol_flags & IAVF_TX_CKSUM_OFFLOAD_MASK) == 0) >>>> + if ((m->ol_flags & IAVF_TX_OFFLOAD_MASK) == 0) >>> Not sure if this will break previous fix. >>> Could you please provide some clarification regarding the specific offload flags that not in IAVF_TX_CKSUM_OFFLOAD_MASK, but you still don't want to skip? >> A specific flag is RTE_ETH_TX_OFFLOAD_SECURITY, and because this is not >> contained in IAVF_TX_OFFLOAD_MASK the previous fix broke the inline >> crypto feature. > RTE_ETH_TX_OFFLOAD_SECURITY is a ethdev level flag. > This is not supposed to be in a mbuf ol_flags, is it? No, it's not, you are right. Actually it's RTE_MBUF_F_TX_SEC_OFFLOAD, and that also means the IAVF_TX_OFFLOAD_MASK definition is not correct. I will send another patch to fix the definition of IAVF_TX_OFFLOAD_MASK. As for this fix, if you prefer a safer approach I can add another check only for RTE_MBUF_F_TX_SEC_OFFLOAD, but one way or the other we need to have this fix. > > >