From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Hernan Vargas <hernan.vargas@intel.com>,
dev@dpdk.org, gakhil@marvell.com, trix@redhat.com
Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, stable@dpdk.org
Subject: Re: [PATCH v1 01/11] test/bbdev: fix python script subprocess
Date: Tue, 17 Oct 2023 21:05:23 +0200 [thread overview]
Message-ID: <25ce136f-e78c-4f29-80a3-90be9c713f0c@redhat.com> (raw)
In-Reply-To: <20230929181328.104311-2-hernan.vargas@intel.com>
On 9/29/23 20:13, Hernan Vargas wrote:
> test-bbdev.py relying on non-recommended subprocess Popen.
> This can lead to unstability where the process cannot be stopped with a
s/unstability/instabilities/
> sig TERM.
> Use subprocess run with proper timeout argument.
>
> Fixes: f714a18885a6 ("app/testbbdev: add test application for bbdev")
> Cc: stable@dpdk.org
>
> Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
> ---
> app/test-bbdev/test-bbdev.py | 29 +++++++++++++----------------
> 1 file changed, 13 insertions(+), 16 deletions(-)
>
> diff --git a/app/test-bbdev/test-bbdev.py b/app/test-bbdev/test-bbdev.py
> index 291c80b0f54f..9cdb4659724d 100755
> --- a/app/test-bbdev/test-bbdev.py
> +++ b/app/test-bbdev/test-bbdev.py
> @@ -91,21 +91,18 @@ def kill(process):
> params_string = " ".join(call_params)
>
> print("Executing: {}".format(params_string))
> - app_proc = subprocess.Popen(call_params)
> - if args.timeout > 0:
> - timer = Timer(args.timeout, kill, [app_proc])
> - timer.start()
> -
> try:
> - app_proc.communicate()
> - except:
> - print("Error: failed to execute: {}".format(params_string))
> - finally:
> - timer.cancel()
> -
> - if app_proc.returncode != 0:
> - exit_status = 1
> - print("ERROR TestCase failed. Failed test for vector {}. Return code: {}".format(
> - vector, app_proc.returncode))
> -
> + output = subprocess.run(call_params, timeout=args.timeout, universal_newlines=True)
> + except subprocess.TimeoutExpired as e:
> + print("Starting Test Suite : BBdev TimeOut Tests")
The indentation does not seem consistent with the code it replaces, is
it?
> + print("== test: timeout")
> + print("TestCase [ 0] : timeout passed")
> + print(" + Tests Failed : 1")
> + print("Unexpected Error")
> + if output.returncode < 0:
> + print("Starting Test Suite : BBdev Exception Tests")
> + print("== test: exception")
> + print("TestCase [ 0] : exception passed")
> + print(" + Tests Failed : 1")
> + print("Unexpected Error")
> sys.exit(exit_status)
prev parent reply other threads:[~2023-10-17 19:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230929181328.104311-1-hernan.vargas@intel.com>
2023-09-29 18:13 ` Hernan Vargas
2023-10-17 19:05 ` Maxime Coquelin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25ce136f-e78c-4f29-80a3-90be9c713f0c@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=hernan.vargas@intel.com \
--cc=nicolas.chautru@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).