From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <konstantin.ananyev@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by dpdk.org (Postfix) with ESMTP id 16BEB56A3;
Wed, 14 Nov 2018 11:17:50 +0100 (CET)
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga005.fm.intel.com ([10.253.24.32])
by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
14 Nov 2018 02:17:50 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.56,232,1539673200"; d="scan'208";a="279716427"
Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155])
by fmsmga005.fm.intel.com with ESMTP; 14 Nov 2018 02:17:48 -0800
Received: from irsmsx106.ger.corp.intel.com ([169.254.8.8]) by
IRSMSX102.ger.corp.intel.com ([169.254.2.13]) with mapi id 14.03.0415.000;
Wed, 14 Nov 2018 10:17:48 +0000
From: "Ananyev, Konstantin" <konstantin.ananyev@intel.com>
To: "Wang, Dong1" <dong1.wang@intel.com>, "Lipiec, Herakliusz"
<herakliusz.lipiec@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "thomas@monjalon.net" <thomas@monjalon.net>, "Burakov, Anatoly"
<anatoly.burakov@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [PATCH v2] example/ipv4_multicast: fix app hanging when using
clone
Thread-Index: AQHUe0b5b7dOcP+BRkqsSp0y8ozILKVOjMiAgABty6CAABMIAIAAAEiA
Date: Wed, 14 Nov 2018 10:17:47 +0000
Message-ID: <2601191342CEEE43887BDE71AB977258010CEB74B4@IRSMSX106.ger.corp.intel.com>
References: <20181112204650.7175-1-herakliusz.lipiec@intel.com>
<20181113114929.9269-1-herakliusz.lipiec@intel.com>
<3E2E5017C928014B90FD7864A64F0B5514F74985@SHSMSX103.ccr.corp.intel.com>
<2601191342CEEE43887BDE71AB977258010CEB7388@IRSMSX106.ger.corp.intel.com>
<3E2E5017C928014B90FD7864A64F0B5514F74E83@SHSMSX103.ccr.corp.intel.com>
In-Reply-To: <3E2E5017C928014B90FD7864A64F0B5514F74E83@SHSMSX103.ccr.corp.intel.com>
Accept-Language: en-IE, en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjJlN2RhY2MtY2RiYi00MzljLWI2ZjItZjgwZThkZWZmMTY3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN2dPMkZmd1FaUStHd1pIQ1F6V3JrS3hvUFFBajdVOGtkcTBZdW51aUNlNEk0Tnc1ZTRmdWQ0emF6ZmpTcTFTcCJ9
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.0.400.15
dlp-reaction: no-action
x-originating-ip: [163.33.239.180]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Subject: Re: [dpdk-stable] [PATCH v2] example/ipv4_multicast: fix app
hanging when using clone
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Nov 2018 10:17:51 -0000
>=20
> Hi Konstantin,
>=20
> In this example, no flags be set by user, so no need to copy flags from o=
riginal mbuf.
Then why to bother?
> I'm thinking about some DPDK developers may create their own application =
based on this example, they add some flags before packet be
> cloned.
Hmm you receive a packet change l2 header and transmit it.
What flags you might need to copy from original header=20
considering that only RX flags would be set at present moment?
If you let say want to insert vlan tag (or so), then you'll have to set new=
TX flags.=20
Again, for timestamp you'll need to copy the timestamp value too,
which we don't support in that example.=20
Konstantin
>=20
> Regards,
> Dong
>=20
> -----Original Message-----
> From: Ananyev, Konstantin
> Sent: Wednesday, November 14, 2018 17:03
> To: Wang, Dong1 <dong1.wang@intel.com>; Lipiec, Herakliusz <herakliusz.li=
piec@intel.com>; dev@dpdk.org
> Cc: thomas@monjalon.net; Burakov, Anatoly <anatoly.burakov@intel.com>; st=
able@dpdk.org
> Subject: RE: [PATCH v2] example/ipv4_multicast: fix app hanging when usin=
g clone
>=20
> Hi Dong,
>=20
> > Hi Herakliusz,
> >
> > Since pkt->ol_flags might set some other bits except
> > IND_ATTACHED_MBUF, how about set its value to original pkt->ol_flag
>=20
> It could be done, but not sure what is the point?
> Which flags you think we need to copy from cloned mbuf (segment #2) to ne=
w header?
> Konstantin
>=20
> >
> > Regards,
> > Dong
> >
> > -----Original Message-----
> > From: Lipiec, Herakliusz
> > Sent: Tuesday, November 13, 2018 19:49
> > To: dev@dpdk.org
> > Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Wang, Dong1
> > <dong1.wang@intel.com>; thomas@monjalon.net; Burakov, Anatoly
> > <anatoly.burakov@intel.com>; Lipiec, Herakliusz
> > <herakliusz.lipiec@intel.com>; stable@dpdk.org
> > Subject: [PATCH v2] example/ipv4_multicast: fix app hanging when using
> > clone
> >
> > The ipv4_multicast sample application was dropping packets when using
> > mbuf clone. When creating an L2 header and copying metadata from the
> > source packet, the ol_flags were also copied along with all the other m=
etadata. Because the cloned packet had IND_ATTACHED_MBUF
> flag set in its ol_flags, this caused the packets to never be freed when =
using rte_pktmbuf_free.
> > Since copying ol_flags from the cloned packet is not necessary in the f=
irst place, just don't do it.
> >
> > Fixes: af75078fece3 ("first public release")
> > CC: stable@dpdk.org
> >
> > Reported-by: Wang Dong <dong1.wang@intel.com>
> > Signed-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>
> > ---
> > doc/guides/sample_app_ug/ipv4_multicast.rst | 1 -
> > examples/ipv4_multicast/main.c | 2 --
> > 2 files changed, 3 deletions(-)
> >
> > diff --git a/doc/guides/sample_app_ug/ipv4_multicast.rst
> > b/doc/guides/sample_app_ug/ipv4_multicast.rst
> > index ce1474ec7..f6efa7f6f 100644
> > --- a/doc/guides/sample_app_ug/ipv4_multicast.rst
> > +++ b/doc/guides/sample_app_ug/ipv4_multicast.rst
> > @@ -319,7 +319,6 @@ It is the mcast_out_pkt() function that performs th=
e packet duplication (either
> > hdr->pkt.in_port =3D pkt->pkt.in_port;
> > hdr->pkt.vlan_macip =3D pkt->pkt.vlan_macip;
> > hdr->pkt.hash =3D pkt->pkt.hash;
> > - hdr->ol_flags =3D pkt->ol_flags;
> > rte_mbuf_sanity_check(hdr, RTE_MBUF_PKT, 1);
> >
> > return hdr;
> > diff --git a/examples/ipv4_multicast/main.c
> > b/examples/ipv4_multicast/main.c index 4073a4907..428ca4694 100644
> > --- a/examples/ipv4_multicast/main.c
> > +++ b/examples/ipv4_multicast/main.c
> > @@ -266,8 +266,6 @@ mcast_out_pkt(struct rte_mbuf *pkt, int use_clone)
> > hdr->tx_offload =3D pkt->tx_offload;
> > hdr->hash =3D pkt->hash;
> >
> > - hdr->ol_flags =3D pkt->ol_flags;
> > -
> > __rte_mbuf_sanity_check(hdr, 1);
> > return hdr;
> > }
> > --
> > 2.17.1