From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D387E42DC2 for ; Mon, 3 Jul 2023 12:31:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C3FE141143; Mon, 3 Jul 2023 12:31:33 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 5B1ED40156; Mon, 3 Jul 2023 12:31:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688380290; x=1719916290; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=2Y8Qq9Oj355Wxdz1TfOJ+pwGAfJUq8P9+5GdtI6N1qM=; b=VN09xRJTuhqeyCqEpr87L7ZqX1DedHks6h4fTeB495Q13Ffzhb8EpcaE RWhf6tX7IvuFGjBoWg30Es6Cj5ml7Ksn/ZmidQPXl1u7Mk8Lk4nq2epgp BwGLh+Uhui2sdoTzD8pobiguQtcegvu3HenrwwyyagsTxlb5DA2VvJQxq ajbXVR/Xfu1zuUz0LBO/+y3yX4jrJ2wTkB0kRczGINYd5hINCRMtIv2MR D9+piVKtvMFXkEsNKo4lizXyYxHg8Goohro6thDgk7kiEKiboShBiHNUs cmqrLEyJzz/NAgBipfvobkJWo4DyFv99TbSBklH1TNr74amD6gskLsojf w==; X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="365416901" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="365416901" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Jul 2023 03:31:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10759"; a="863037721" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="863037721" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 03 Jul 2023 03:31:29 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 3 Jul 2023 03:31:28 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 3 Jul 2023 03:31:28 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Mon, 3 Jul 2023 03:31:28 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Mon, 3 Jul 2023 03:31:28 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gbZSDJNQO8ptGLVdBNULZ40j++l2JE2oJPeP7VJGiruOzDU0gU4swYGXw1TkY9icVpqz/npEQkhwVAhFIQOjB//ztULwTuc+Z7TNGf7oVUMqUl+NpOsRsEq6et+bOrstew2UEpqCuUFSGx+vO0D37/mDTOUIIR0/Tx79wofglI8ablQ+zGMl1sPC8qbGcMKjY5OxWwIUWouNFWmYu/1l7z09whUYpeNnSrRpDQ7m8IVZnxTF7st83JbcFL4APItnmCOcrQCj84nDr94OVTM605Y+G5mnJTAgs8RmlSMEMGgi9i1zcm2uvQ0jEJhxTid8O3tkq4ZeiUqYkR9l+dR47A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kR9NSHnYoxHJ69IyYML+Z9lfbmKeuwLOABFHmiCk6XE=; b=IYZPvXe0QlxxsC2FJpw4BG6Rgq95/50J9n+ER5TkI+1KfiY3jZpRtK9+wlv/SgdRczxp2Kr5jIeejtg0AWQEg+uvUrlQmxIJv/UkHbGsmBS1Fv/MbD9Ff+TCkCS98if5nB90lb2uK9nWy5dN6+ePB9Q9KKN2HWa3nI0fLDvA2nYo7mfV3cBmSPp0OkE7NnB0NCuef2po6CxBkenp8EFSJ47jp9jHhZ9Mar1eXxHFwuBYtCdGcQ8lBrvOG/ydSYjmVMkt3qhqaxZxwKCpEUAwhJgXCQgwm4XC4vYZLRPeh3pp+zUxQrPJKM6IDW5dZQBS+59X7p9QEaJmz6UDp9ZC4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) by PH0PR11MB5657.namprd11.prod.outlook.com (2603:10b6:510:ee::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul 2023 10:31:26 +0000 Received: from DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::3a63:ce12:27cd:911e]) by DM4PR11MB6502.namprd11.prod.outlook.com ([fe80::3a63:ce12:27cd:911e%4]) with mapi id 15.20.6544.024; Mon, 3 Jul 2023 10:31:26 +0000 Message-ID: <26612c12-8230-1481-9018-ceeafa34f993@intel.com> Date: Mon, 3 Jul 2023 11:31:21 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.12.0 Subject: Re: [PATCH] eal: fix file descriptor leakage with unhandled messages Content-Language: en-US To: Viacheslav Ovsiienko , CC: References: <20230628121938.13452-1-viacheslavo@nvidia.com> From: "Burakov, Anatoly" In-Reply-To: <20230628121938.13452-1-viacheslavo@nvidia.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0184.eurprd04.prod.outlook.com (2603:10a6:10:28d::9) To DM4PR11MB6502.namprd11.prod.outlook.com (2603:10b6:8:89::7) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6502:EE_|PH0PR11MB5657:EE_ X-MS-Office365-Filtering-Correlation-Id: 20b8c3de-0a4c-462b-ab9b-08db7bb0a794 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yU41HtAH8TbExGZB0cHgz8kDEqqw119ndC7/se5OGW9HZUkt3JX2c/UcVtKSPMqmgNLEc08Wiq8K7Jell8jShkhyrVgHyb+aN1PKaczK7mlo5YJLXdXFasxn0XDx0PwQiQdbSyFagIEBvt9rnaaXJxk0Kj02xiIRLwKiGWFn1mnhfnaXWFgiat0mY8xx1tK+49Bh9O/SJr8fE8qANi1VotBphQwupGm9BeddIDoL4KUDVBfo+RwOv/Vwm2unNCrT7FqmiaX1hC0jaODRPnr2rglxOUYeX52kbm+6nSCDoRME48YnVM3uJS3yHholfT2BQoOlC2X3Ky0vKQmOLzJ5YOGh04Skw9DMGi+aMJVcKNcmXH7l0ut9PDfXrWXvfjnz+WEl1yHljfDA1i3mPe9eF3TWHjEb1O4Yexeful83bHDm5lYt/vcOM2woYksfjOq2JaKDjTODB+j7FOQFrQNP3UMOqQO9z0YJnl1UHvXvSIA1jmb5NioM6JomVNVlroGVXomFIq+ngkUzGOoMJ+/Ln72jO88FjQI+RRFwMnrqldSdH3CUlugjgfYmX2vIQrz4rrzHkDPikrsjYNZlXokFHe2u6DCCpQjpdNbo20wkFdGT848wHkHW8OtnlQm15pQDJu1SyquJKTtUtKvF5ot93g== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM4PR11MB6502.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(366004)(136003)(376002)(396003)(346002)(39860400002)(451199021)(2906002)(41300700001)(5660300002)(8936002)(8676002)(15650500001)(36756003)(86362001)(31696002)(186003)(2616005)(31686004)(82960400001)(478600001)(26005)(6512007)(6506007)(6666004)(53546011)(6486002)(316002)(4326008)(66476007)(66556008)(66946007)(38100700002)(83380400001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OWZUVlhkVHZ4TTduSnllODdKcWN1dWJCeEh4VUEycGFpcXlOTkVha3VzcjR4?= =?utf-8?B?SzREcTNrYW9yK2wxQVJLc2J1QTg2bEZPQTRSTStHNGpIbC9sQ3NPaTUyckRm?= =?utf-8?B?M3RBRzFweWFvaG5ZTldyY0UyYi9MRlZNajRzWkUreVdhMUdSYndiSVhnZU5J?= =?utf-8?B?eVp1ZW5lZHd5WE00TlRjOUZHdEs0eEU1NkduVXdmbUV0cDJ1d2RDczduQThw?= =?utf-8?B?ZUdsYTk1TE9yNlNCd1FlZU1QWHdOci9odm9HTUYxVVJkcThlalN3Q3laQjF3?= =?utf-8?B?aWQ3Mzd2NlJhdnRDNE0wKzU2RWZyS20wYzMreGE0VldvTnNtdUZjSmw1MjJ5?= =?utf-8?B?d0tnMC9uaXR5VjJXRGl1T2pyenVJdkJSWitFTDVPTmtjeWZMcUFqcWJaRG1p?= =?utf-8?B?aU1CWUhYVUd1dVF5Y0NxWlNIdU1xdFQrMjh0aXhRdDZuclpML0c2VnFrMXAv?= =?utf-8?B?ZEhZQktCMGIvR0k3YlplV09kNWp2UmkzMHBYMlplNE5MY2M4Sm55VXU5NFlo?= =?utf-8?B?bEJMNzVZdTZ2dWpCY0tnVU9KK2U3TjNTZitpL3Q4YWlMdmtZSjI2RzBkRElP?= =?utf-8?B?NGFyYVVDcHlrTm9PU1pEYWlwQWY2QUhoZmc1TmJOZCtPTG50VFJhTWt3VURa?= =?utf-8?B?eVlLeGNmUzhIWG5ndTRmUzB5Q2hKbHM0ck90bFdaMzRaTjNxRU5GOWhwdmF0?= =?utf-8?B?SWo3N1FOYlYvenhOWVJtQ0dvUDNqOEdLQWhTMElKdFhqN0RWZ21xZmgrWUtK?= =?utf-8?B?ZUR3OXVnb28ydVVGc2NRemdDT3BiYnRZUWtIUmJ6YmgrdXZXYSsyK3JTNlBt?= =?utf-8?B?RlE2WkF6SDBuTmlPRks5cTA5YmpTbUZpMUFOVTl6TldLTWl1L01Qd2ROeDdR?= =?utf-8?B?Ti9GWnh5SFRaWTlESWlWZ3JOL1dqNEJEN1I1ekV4Uk9TV0RTVi9BdWdZNU4r?= =?utf-8?B?bXhxMXFlR2hGWU5RSG9saHZIb08yYXJRTlF0dUVjVXFlRTZadkZYdGg3cTYr?= =?utf-8?B?bkhHbU9oVVdXV2Irb2FsMGNSWjcwdkFiV1dGenpmWFQvSE9seWpieEROd1Az?= =?utf-8?B?RnpwL3pnY0YvN1NCWkFpc1hjbGFqWmNMdVZEVVZPSXJ6b3FraUFTNFR0OXRa?= =?utf-8?B?ajBtTmtsODhPa3V1QWJJMGpqOWQxL2h1SDRyQnhka1ZyN2hzN1o4dWZoZjVS?= =?utf-8?B?aHFIT2UxaCtiNmZkS21ZUWxQNkJOcStrRllOYy9HWWtFRVZQL2FLeThZYTNT?= =?utf-8?B?akNRNUZtM2RKM092eTZFZjRtM2t4aGdsNk1uYzJtK0hwUkJzaU1Bd0ZOY2kr?= =?utf-8?B?VzkyLzI4TTVNc01EbXlSZ3N1eGY1cUg2alkyY1NnLzVNaDl4MWNvUWljV1BZ?= =?utf-8?B?VjZpMEIybDd6UXRFUlkxQVJUSVZ1YlR1YzVtZDN1Sm0xNVArUi9jTzhHQ0Uy?= =?utf-8?B?MUx5bFkwU3JlamJSaDhCeGlvelp6MGhWNnM5blVFSUw0LzNSVGY1WDNNc0pi?= =?utf-8?B?MG5DTE9kK09haEFaWEZhbjA2Uy9pZS9UUHhXYVVPOXVjSld4K0lGTlN4SVpC?= =?utf-8?B?SHhmVHJsS29rVWJIK1J5ZkRvUE9LeC9vL2ZGdXJTeWMwU1M0S3MwV3BGc29t?= =?utf-8?B?Mk53NkZhUHZuOWNDYlY4bE0rWHlJVkxJM2I2Q3M0YUl0dG9ldWxEcUREWFZZ?= =?utf-8?B?RTZCSnRNUVBVYzZBSTdHa2c0a2Mxa1JEWGdWNnhSK2ZrK3F1MTNEbmFoZTFi?= =?utf-8?B?K0ZjVURRRnI2M0JJckVwdXRLRE1EZFBIWnZMNzVHbElVUzRGQXg2WG5rcVdt?= =?utf-8?B?bFl6azMwTDFlOFhKZnNxN3VodmRCU2pzKy81R2RuQS9Sc3RSandRVkg5SXJt?= =?utf-8?B?NFhvS0gwN2VLTzV4UkhwYUVPV3ZxSHdqU1Q4aXBwNldabEZIR1BSOUhXZ0hH?= =?utf-8?B?Y3gydmxxeXNoWEZDTmtUSVJVSUlMcmpiQUpOaE5yaTZsSlNqcTgrY0QvY01D?= =?utf-8?B?Mm5tMHhnOVNrbExkVy83L3RFUkN3RGpCOTh1UVdzN2pCVjJONnVHeTlEZFZI?= =?utf-8?B?R3JYK2dKMnI4NVlsNStjYmpTTFBxZVh2ZkxzNTF2bEwyZ2NYR2JkeXphcW1j?= =?utf-8?B?V1FLc1hDL1ZpV2QxdTMvL2FEVXZNNi91aHppelNZTmNiRC9oNGZBWk9keG1P?= =?utf-8?B?WlE9PQ==?= X-MS-Exchange-CrossTenant-Network-Message-Id: 20b8c3de-0a4c-462b-ab9b-08db7bb0a794 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6502.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2023 10:31:26.1039 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: EHqTQTXTg9UI+5025c6k0GTJV9Krod48W+Z6FptOjdFdeNSvokoIFrpzHONh6Hc6C/o5tiXZ6b9tw+J6HdXkG2iwP95TkKGeB/968OIV3nI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5657 X-OriginatorOrg: intel.com X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On 6/28/2023 1:19 PM, Viacheslav Ovsiienko wrote: > The sendmsg()/recvmsg() API is used to establish communication between > the DPDK processes. The API supposes inter-process file descriptors > sending and conversion, the recipient sees the resulting descriptors > in the received message - the operating systems creates ones in the > right context. > > The message receiving is performed by EAL in the dedicated thread > and it might happen the message is received by EAL and not handled > by addressed PMD or application due to some reasons (timeouts, race > condition, etc). EAL just dropped unhandled messages causing the > file descriptor leakage if these ones were presented in the message. > > The patch closes the descriptors (if any) in unhandled messages. > > Fixes: 783b6e54971 ("eal: add synchronous multi-process communication") > Cc: stable@dpdk.org > > Signed-off-by: Viacheslav Ovsiienko > --- Acked-by: Anatoly Burakov -- Thanks, Anatoly