From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6599EA0547 for ; Mon, 22 Feb 2021 13:39:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 541131CC4D6; Mon, 22 Feb 2021 13:39:59 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 8788E4003C; Mon, 22 Feb 2021 13:39:56 +0100 (CET) IronPort-SDR: f1HjLFm7q0LTs/DW8N0WtbggX0MLEmKioYnCP5e+8UBMUBHjr82AH1jiuBAyWJ/13Mvz8WbP2h yQmYk27pG4+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9902"; a="269362546" X-IronPort-AV: E=Sophos;i="5.81,197,1610438400"; d="scan'208";a="269362546" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2021 04:39:55 -0800 IronPort-SDR: hyY0ZIj72Fk7EZm7ilEJlwMv2fHzhcTYnbLIOtBdMxPIAR2mKGRGlhOQg9QcbgUqefytEl65M/ kfnBedJ7LSYw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,197,1610438400"; d="scan'208";a="379995863" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga002.jf.intel.com with ESMTP; 22 Feb 2021 04:39:55 -0800 Received: from shsmsx606.ccr.corp.intel.com (10.109.6.216) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 22 Feb 2021 04:39:54 -0800 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX606.ccr.corp.intel.com (10.109.6.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Mon, 22 Feb 2021 20:39:52 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.2106.002; Mon, 22 Feb 2021 20:39:52 +0800 From: "Zhang, Qi Z" To: "Huang, ZhiminX" , "Zhang, AlvinX" CC: "dev@dpdk.org" , "Zhang, AlvinX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] net/ice: fix VLAN filter with PF Thread-Index: AQHXBn0ob/FEmKyEA0K4r8Dy19R07apeaOgAgABBA4CABXicMA== Date: Mon, 22 Feb 2021 12:39:52 +0000 Message-ID: <26d6917370594a63b0497f4265e16169@intel.com> References: <20210219050736.12632-1-alvinx.zhang@intel.com> <20210219051346.12992-1-alvinx.zhang@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice: fix VLAN filter with PF X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Huang, ZhiminX > Sent: Friday, February 19, 2021 5:06 PM > To: Zhang, AlvinX ; Zhang, Qi Z > > Cc: dev@dpdk.org; Zhang, AlvinX ; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] net/ice: fix VLAN filter with PF >=20 > Tested-by: Huang, ZhiminX >=20 > Regards, > HuangZhiMin >=20 >=20 > > -----Original Message----- > > From: dev On Behalf Of Alvin Zhang > > Sent: Friday, February 19, 2021 1:14 PM > > To: Zhang, Qi Z > > Cc: dev@dpdk.org; Zhang, AlvinX ; > > stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/ice: fix VLAN filter with PF > > > > The macro flag DEV_RX_OFFLOAD_VLAN_FILTER is used to enable/disable Rx > > VLAN filter, but not Tx VLAN filter. Therefore, Tx VLAN filter should > > not be enabled/disabled in function ice_vsi_config_vlan_filter called > > after checking DEV_RX_OFFLOAD_VLAN_FILTER flag. > > > > In addition, the kernel driver doesn't enable/disable the TX VLAN > > filter in the similar function ice_cfg_vlan_pruning. > > > > This patch removes the setting about the TX VLAN filter in function > > ice_vsi_config_vlan_filter. > > > > Fixes: e0dcf94a0d7f ("net/ice: support VLAN ops") > > Cc: stable@dpdk.org > > > > Signed-off-by: Alvin Zhang Acked-by: Qi Zhang Applied to dpdk-next-net-intel. Thanks Qi