patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: stable@dpdk.org, dev@dpdk.org, david.marchand@redhat.com,
	stable@dpdk.org, Ray Kinsella <mdr@ashroe.eu>,
	Neil Horman <nhorman@tuxdriver.com>,
	Kevin Laatz <kevin.laatz@intel.com>
Subject: Re: [dpdk-stable] [PATCH] eal: fix querying DPDK version at runtime
Date: Tue, 09 Feb 2021 13:34:40 +0100
Message-ID: <2748803.ThAVpoFO8R@thomas> (raw)
In-Reply-To: <20210205212606.GA1479@bricha3-MOBL.ger.corp.intel.com>

05/02/2021 22:26, Bruce Richardson:
> On Fri, Feb 05, 2021 at 09:05:43PM +0100, Thomas Monjalon wrote:
> > 05/02/2021 20:39, Bruce Richardson:
> > > For using a DPDK application, such as OVS, which is dynamically linked, the
> > > DPDK version in use should always report the actual version, not the
> > > version used at build time. This incorrect behaviour can be seen by
> > > building OVS against one version of DPDK and running it against a later
> > > one. Using "ovs-vsctl list Open_vSwitch" to query basic info, the
> > > dpdk_version returned will be the build version not the currently running
> > > one - which can be verified using the DPDK telemetry library client.
> > > 
> > >   $ sudo ovs-vsctl list Open_vSwitch | grep dpdk_version
> > >   dpdk_version        : "DPDK 20.11.0-rc4"
> > > 
> > >   $ echo quit | sudo dpdk-telemetry.py
> > >   Connecting to /var/run/dpdk/rte/dpdk_telemetry.v2
> > >   {"version": "DPDK 21.02.0-rc2", "pid": 405659, "max_output_len": 16384}
> > 
> > Nice demonstration.
> > 
> > >  __rte_experimental
> > >  int
> > > -rte_telemetry_init(const char *runtime_dir, rte_cpuset_t *cpuset,
> > > +rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset,
> > >  		const char **err_str);
> > 
> > It is changing the API.
> > As it is experimental, you just need to mention it in the release notes.
> 
> I don't think I actually need to mention it there, because this API is more
> "INTERNAL" than "EXPERIMENTAL". It's called automatically from
> rte_eal_init(). I've done up patch http://patches.dpdk.org/patch/87806/
> to correct this, including a RN addition. That should remove the need for a
> doc update for this patch.
> 
> > 
> > It is the fix. Do you think it should be merged quickly?
> > Or wait for 21.05?
> > 
> 
> I'm not sure either way to be honest. Given the bug has been around so
> long, it's not exactly urgent. On the other hand, to get the fix the user
> needs to rebuild their app, so having it sooner is nicer, and will mean it
> would make the next LTS point release. Overall, though, I'm fine whichever
> you decide.


There is not much help available to close 21.02, so I won't take any risk.
I'll merge this fix in 21.05.



  reply	other threads:[~2021-02-09 12:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-05 19:39 Bruce Richardson
2021-02-05 20:05 ` Thomas Monjalon
2021-02-05 21:26   ` Bruce Richardson
2021-02-09 12:34     ` Thomas Monjalon [this message]
2021-02-09 12:36       ` Bruce Richardson
2021-02-16 15:13 ` [dpdk-stable] [PATCH v2] " Bruce Richardson
2021-03-15 22:24   ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2021-03-17  8:40   ` [dpdk-stable] " David Marchand
2021-03-17  9:33     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2748803.ThAVpoFO8R@thomas \
    --to=thomas@monjalon.net \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=kevin.laatz@intel.com \
    --cc=mdr@ashroe.eu \
    --cc=nhorman@tuxdriver.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git