From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0202BA04DB for ; Sun, 22 Nov 2020 15:06:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BCC12C8F2; Sun, 22 Nov 2020 15:06:47 +0100 (CET) Received: from wout5-smtp.messagingengine.com (wout5-smtp.messagingengine.com [64.147.123.21]) by dpdk.org (Postfix) with ESMTP id 854C76CC6; Sun, 22 Nov 2020 15:06:43 +0100 (CET) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.west.internal (Postfix) with ESMTP id 39CFC6BF; Sun, 22 Nov 2020 09:06:42 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 22 Nov 2020 09:06:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= FDE2c7mWUUwi1GVhAy1nJgUfU+Kcq8jfofy09+Ai4fk=; b=smCMe71L5Tc6opON vePYO/kxLP6ftLNhTYWme0NZkb2ycuU1cF7AWoQjrPZdCHQMOIRXVKsspmS3xJiB 0gYYQjL6KQXdPM0wjdttN8ChuvpXdZFmHW9Npe2km1lDYQ8szyDhOKRNM3aBQIkk nmDXE8gVxrsT0dceF/Y6InjbGGFGeFmNJwrMji26PZqh8F0IpjYl+lBScf9Ai5Ih Q5Cv9rBzWEOrn4EFu4Qqzju5Q7+DOQuaX2RP18TjHXtPUgSf+WdwIetA/i0J68Yp i+RbJo8GJFtL6Cgn2ricnIgdinrU9nY54CLHTgYhewjH8BSIEVi+MFas0um2Q+8U CsdjUw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=FDE2c7mWUUwi1GVhAy1nJgUfU+Kcq8jfofy09+Ai4 fk=; b=bzsWa83HGpeyPP6qN15zeHkjVvwqz04OecFXt2mt5oPhU9z1i0ymaR9SR sEvnGtZBtG2I8Nc/ZtPBCPPUG+9KnAf9FXe3j3D9lOrlTCEeFpctOdaSS2TzoUmo cz8MCl3yECzQXL99sanezaPuXyqF462dTj22FqjC4hZBJ1imSMqc8g2qaAeVXAFr 2GKuSXgjgqgHrz/7r04GvBkmgtFMuXdJXxbvNqtCsaIVWhHTw4ZE8VfhQ7Yt8MCY I+sBJejyxPtVMoB4eO6GyFRC/s9MuGfbsEWIV0m7JkoKKRpm/WwtawkibMe98E59 OUa3YYKO+imtJL6asNE1EJl2YLEKQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrudeggedgiedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg ftrfgrthhtvghrnhepudeggfdvfeduffdtfeeglefghfeukefgfffhueejtdetuedtjeeu ieeivdffgeehnecukfhppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghruf hiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghl ohhnrdhnvght X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id DABA23064AA7; Sun, 22 Nov 2020 09:06:40 -0500 (EST) From: Thomas Monjalon To: Michael Baum Cc: dev@dpdk.org, stable@dpdk.org, Matan Azrad , Raslan Darawsheh , Viacheslav Ovsiienko , orika@nvidia.com Date: Sun, 22 Nov 2020 15:06:39 +0100 Message-ID: <2836795.3MCMvtSeAW@thomas> In-Reply-To: <1605718811-18652-1-git-send-email-michaelba@nvidia.com> References: <1605718811-18652-1-git-send-email-michaelba@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-stable] [PATCH 1/7] regex/mlx5: fix jump to the wrong label X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" 18/11/2020 18:00, Michael Baum: > The mlx5_regex_pci_probe function allocates a mlx5_regex_priv structure > using rte_zmalloc. > > If the allocation fails, the function jumps to the dev_error label in > order to release previously allocated resources in the function. > However, in the dev_error label it attempts to refer to the internal > fields of the priv structure and if its allocation fails (as in this > case) it is actually dereferencing to NULL. > > Replace the jump with an error label. > > Fixes: 1db6ebd4ef58 ("regex/mlx5: fix crash on initialization failure") > Cc: stable@dpdk.org > > Signed-off-by: Michael Baum > Acked-by: Ori Kam Series applied, thanks