From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17221A04B6 for ; Fri, 2 Oct 2020 14:18:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DEAF71D625; Fri, 2 Oct 2020 14:18:05 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 24A881D558 for ; Fri, 2 Oct 2020 14:18:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601641081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=3TzyagCrgbrIT89tPIkP9EMnHu897DJcCRplgge114I=; b=USTTHGFsgsjRzju7nwjz9z+GAhpfMaaS5svwGpfHRqTjk21Qlf8i2eoBiNakCnZf299pgu Ir/Aymj3V0y2gCOSZl7MZR9ltykvSs1H1agYMvLDBVEfrrX2e9YrU0Ir8/YSn8ZeS0hhHQ A8SWq48ez+pUWd231dgZlsRLZQsnEmg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-223-JCxZg3-6OOijcryqO4CAag-1; Fri, 02 Oct 2020 08:17:57 -0400 X-MC-Unique: JCxZg3-6OOijcryqO4CAag-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7FFA5427CA; Fri, 2 Oct 2020 12:17:56 +0000 (UTC) Received: from [10.36.110.36] (unknown [10.36.110.36]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6155E10013BD; Fri, 2 Oct 2020 12:17:54 +0000 (UTC) To: Fan Zhang , dev@dpdk.org Cc: chenbo.xia@intel.com, changpeng.liu@intel.com, ferruh.yigit@intel.com, stable@dpdk.org References: <20201002083615.45470-1-roy.fan.zhang@intel.com> From: Maxime Coquelin Autocrypt: addr=maxime.coquelin@redhat.com; keydata= mQINBFOEQQIBEADjNLYZZqghYuWv1nlLisptPJp+TSxE/KuP7x47e1Gr5/oMDJ1OKNG8rlNg kLgBQUki3voWhUbMb69ybqdMUHOl21DGCj0BTU3lXwapYXOAnsh8q6RRM+deUpasyT+Jvf3a gU35dgZcomRh5HPmKMU4KfeA38cVUebsFec1HuJAWzOb/UdtQkYyZR4rbzw8SbsOemtMtwOx YdXodneQD7KuRU9IhJKiEfipwqk2pufm2VSGl570l5ANyWMA/XADNhcEXhpkZ1Iwj3TWO7XR uH4xfvPl8nBsLo/EbEI7fbuUULcAnHfowQslPUm6/yaGv6cT5160SPXT1t8U9QDO6aTSo59N jH519JS8oeKZB1n1eLDslCfBpIpWkW8ZElGkOGWAN0vmpLfdyiqBNNyS3eGAfMkJ6b1A24un /TKc6j2QxM0QK4yZGfAxDxtvDv9LFXec8ENJYsbiR6WHRHq7wXl/n8guyh5AuBNQ3LIK44x0 KjGXP1FJkUhUuruGyZsMrDLBRHYi+hhDAgRjqHgoXi5XGETA1PAiNBNnQwMf5aubt+mE2Q5r qLNTgwSo2dpTU3+mJ3y3KlsIfoaxYI7XNsPRXGnZi4hbxmeb2NSXgdCXhX3nELUNYm4ArKBP LugOIT/zRwk0H0+RVwL2zHdMO1Tht1UOFGfOZpvuBF60jhMzbQARAQABtCxNYXhpbWUgQ29x dWVsaW4gPG1heGltZS5jb3F1ZWxpbkByZWRoYXQuY29tPokCOAQTAQIAIgUCV3u/5QIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQyjiNKEaHD4ma2g/+P+Hg9WkONPaY1J4AR7Uf kBneosS4NO3CRy0x4WYmUSLYMLx1I3VH6SVjqZ6uBoYy6Fs6TbF6SHNc7QbB6Qjo3neqnQR1 71Ua1MFvIob8vUEl3jAR/+oaE1UJKrxjWztpppQTukIk4oJOmXbL0nj3d8dA2QgHdTyttZ1H xzZJWWz6vqxCrUqHU7RSH9iWg9R2iuTzii4/vk1oi4Qz7y/q8ONOq6ffOy/t5xSZOMtZCspu Mll2Szzpc/trFO0pLH4LZZfz/nXh2uuUbk8qRIJBIjZH3ZQfACffgfNefLe2PxMqJZ8mFJXc RQO0ONZvwoOoHL6CcnFZp2i0P5ddduzwPdGsPq1bnIXnZqJSl3dUfh3xG5ArkliZ/++zGF1O wvpGvpIuOgLqjyCNNRoR7cP7y8F24gWE/HqJBXs1qzdj/5Hr68NVPV1Tu/l2D1KMOcL5sOrz 2jLXauqDWn1Okk9hkXAP7+0Cmi6QwAPuBT3i6t2e8UdtMtCE4sLesWS/XohnSFFscZR6Vaf3 gKdWiJ/fW64L6b9gjkWtHd4jAJBAIAx1JM6xcA1xMbAFsD8gA2oDBWogHGYcScY/4riDNKXi lw92d6IEHnSf6y7KJCKq8F+Jrj2BwRJiFKTJ6ChbOpyyR6nGTckzsLgday2KxBIyuh4w+hMq TGDSp2rmWGJjASq5Ag0EVPSbkwEQAMkaNc084Qvql+XW+wcUIY+Dn9A2D1gMr2BVwdSfVDN7 0ZYxo9PvSkzh6eQmnZNQtl8WSHl3VG3IEDQzsMQ2ftZn2sxjcCadexrQQv3Lu60Tgj7YVYRM H+fLYt9W5YuWduJ+FPLbjIKynBf6JCRMWr75QAOhhhaI0tsie3eDsKQBA0w7WCuPiZiheJaL 4MDe9hcH4rM3ybnRW7K2dLszWNhHVoYSFlZGYh+MGpuODeQKDS035+4H2rEWgg+iaOwqD7bg CQXwTZ1kSrm8NxIRVD3MBtzp9SZdUHLfmBl/tLVwDSZvHZhhvJHC6Lj6VL4jPXF5K2+Nn/Su CQmEBisOmwnXZhhu8ulAZ7S2tcl94DCo60ReheDoPBU8PR2TLg8rS5f9w6mLYarvQWL7cDtT d2eX3Z6TggfNINr/RTFrrAd7NHl5h3OnlXj7PQ1f0kfufduOeCQddJN4gsQfxo/qvWVB7PaE 1WTIggPmWS+Xxijk7xG6x9McTdmGhYaPZBpAxewK8ypl5+yubVsE9yOOhKMVo9DoVCjh5To5 aph7CQWfQsV7cd9PfSJjI2lXI0dhEXhQ7lRCFpf3V3mD6CyrhpcJpV6XVGjxJvGUale7+IOp sQIbPKUHpB2F+ZUPWds9yyVxGwDxD8WLqKKy0WLIjkkSsOb9UBNzgRyzrEC9lgQ/ABEBAAGJ Ah8EGAECAAkFAlT0m5MCGwwACgkQyjiNKEaHD4nU8hAAtt0xFJAy0sOWqSmyxTc7FUcX+pbD KVyPlpl6urKKMk1XtVMUPuae/+UwvIt0urk1mXi6DnrAN50TmQqvdjcPTQ6uoZ8zjgGeASZg jj0/bJGhgUr9U7oG7Hh2F8vzpOqZrdd65MRkxmc7bWj1k81tOU2woR/Gy8xLzi0k0KUa8ueB iYOcZcIGTcs9CssVwQjYaXRoeT65LJnTxYZif2pfNxfINFzCGw42s3EtZFteczClKcVSJ1+L +QUY/J24x0/ocQX/M1PwtZbB4c/2Pg/t5FS+s6UB1Ce08xsJDcwyOPIH6O3tccZuriHgvqKP yKz/Ble76+NFlTK1mpUlfM7PVhD5XzrDUEHWRTeTJSvJ8TIPL4uyfzhjHhlkCU0mw7Pscyxn DE8G0UYMEaNgaZap8dcGMYH/96EfE5s/nTX0M6MXV0yots7U2BDb4soLCxLOJz4tAFDtNFtA wLBhXRSvWhdBJZiig/9CG3dXmKfi2H+wdUCSvEFHRpgo7GK8/Kh3vGhgKmnnxhl8ACBaGy9n fxjSxjSO6rj4/MeenmlJw1yebzkX8ZmaSi8BHe+n6jTGEFNrbiOdWpJgc5yHIZZnwXaW54QT UhhSjDL1rV2B4F28w30jYmlRmm2RdN7iCZfbyP3dvFQTzQ4ySquuPkIGcOOHrvZzxbRjzMx1 Mwqu3GQ= Message-ID: <28378483-f252-2482-19f0-ff7dc21dcb06@redhat.com> Date: Fri, 2 Oct 2020 14:17:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201002083615.45470-1-roy.fan.zhang@intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-stable] [dpdk-dev] vhost/crypto: fix initialization. X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi Fan, Thanks for working on this. The commit message should not contain dot, please remove it in v2. On 10/2/20 10:36 AM, Fan Zhang wrote: > This patch fixes the problem that vhost crypto cannot be > initialized due to the different requirement between > built-in virtio-net and virtio-crypto. The fix includes > the following change: > > - Added new internal enum type virtio_backend_type to > distinguish virtio-net, virtio-crypto, and external > device types. > - Added new API rte_vhost_crypto_driver_start to > distinguish between virtio-net and virtio-crypto built-in > drivers initialization. > - Added new internal function for the vhost library > to use different feature flags when initializing > virtio-crypto. This last one should be part of a dedicated patch. > Fixes: 2ab58f20db51 ("vhost: refactor virtio ready check") Please remove that Fixes tag. Looking in this patch, we can see it worked by luck. Thanks to the v20.08 refactoring, we spotted that Vhost crypto was broken. > Cc: maxime.coquelin@redhat.com > > Signed-off-by: Fan Zhang > --- > examples/vhost_crypto/main.c | 3 +- > lib/librte_vhost/rte_vhost_crypto.h | 12 +++++++ > lib/librte_vhost/rte_vhost_version.map | 1 + > lib/librte_vhost/socket.c | 44 +++++++++++++++++++++----- > lib/librte_vhost/vhost.h | 1 - > lib/librte_vhost/vhost_crypto.c | 35 ++++++++++++-------- > lib/librte_vhost/vhost_user.h | 12 +++++++ > 7 files changed, 84 insertions(+), 24 deletions(-) > > diff --git a/examples/vhost_crypto/main.c b/examples/vhost_crypto/main.c > index 11b022e81..ef64e96de 100644 > --- a/examples/vhost_crypto/main.c > +++ b/examples/vhost_crypto/main.c > @@ -598,7 +598,8 @@ main(int argc, char *argv[]) > rte_vhost_driver_callback_register(lo->socket_files[j], > &virtio_crypto_device_ops); > > - ret = rte_vhost_driver_start(lo->socket_files[j]); > + ret = rte_vhost_crypto_driver_start( > + lo->socket_files[j]); > if (ret < 0) { > RTE_LOG(ERR, USER1, "failed to start vhost.\n"); > goto error_exit; > diff --git a/lib/librte_vhost/rte_vhost_crypto.h b/lib/librte_vhost/rte_vhost_crypto.h > index b54d61db6..c809c46a2 100644 > --- a/lib/librte_vhost/rte_vhost_crypto.h > +++ b/lib/librte_vhost/rte_vhost_crypto.h > @@ -20,6 +20,18 @@ enum rte_vhost_crypto_zero_copy { > RTE_VHOST_CRYPTO_MAX_ZERO_COPY_OPTIONS > }; > > +/** > + * Start vhost crypto driver > + * > + * @param path > + * The vhost-user socket file path > + * @return > + * 0 on success, -1 on failure > + */ > +__rte_experimental > +int > +rte_vhost_crypto_driver_start(const char *path); > + > /** > * Create Vhost-crypto instance > * > diff --git a/lib/librte_vhost/rte_vhost_version.map b/lib/librte_vhost/rte_vhost_version.map > index 20b4abcb4..a454d5f41 100644 > --- a/lib/librte_vhost/rte_vhost_version.map > +++ b/lib/librte_vhost/rte_vhost_version.map > @@ -48,6 +48,7 @@ EXPERIMENTAL { > rte_vhost_get_vring_base; > rte_vhost_set_vring_base; > rte_vhost_crypto_create; > + rte_vhost_crypto_driver_start; > rte_vhost_crypto_free; > rte_vhost_crypto_fetch_requests; > rte_vhost_crypto_finalize_requests; > diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c > index 73e1dca95..3de2da836 100644 > --- a/lib/librte_vhost/socket.c > +++ b/lib/librte_vhost/socket.c > @@ -39,7 +39,7 @@ struct vhost_user_socket { > bool reconnect; > bool dequeue_zero_copy; > bool iommu_support; > - bool use_builtin_virtio_net; > + enum virtio_backend_type backend_type; > bool extbuf; > bool linearbuf; > bool async_copy; > @@ -225,7 +225,15 @@ vhost_user_add_connection(int fd, struct vhost_user_socket *vsocket) > size = strnlen(vsocket->path, PATH_MAX); > vhost_set_ifname(vid, vsocket->path, size); > > - vhost_set_builtin_virtio_net(vid, vsocket->use_builtin_virtio_net); > + vhost_set_builtin_virtio_net(vid, > + vsocket->backend_type == VIRTIO_DEV_BUILTIN_NET ? > + true : false); > + > + if (vsocket->backend_type == VIRTIO_DEV_BUILTIN_CRYPTO) { > + vhost_crypto_set_feature_flags(&vsocket->supported_features, > + &vsocket->protocol_features); It should not be done like that, we have API for that. We don't want to call vhost_crypto API in socket.c Features supported by the application/backend have to be set between rte_vhost_driver_register() and rte_vhost_driver_start() calls. It think it can be done in rte_vhost_crypto_driver_start() function, please see below. > + vsocket->features = vsocket->supported_features; > + } > > vhost_attach_vdpa_device(vid, vsocket->vdpa_dev); > > @@ -636,7 +644,7 @@ rte_vhost_driver_disable_features(const char *path, uint64_t features) > pthread_mutex_lock(&vhost_user.mutex); > vsocket = find_vhost_user_socket(path); > > - /* Note that use_builtin_virtio_net is not affected by this function > + /* Note that backend type is not affected by this function > * since callers may want to selectively disable features of the > * built-in vhost net device backend. > */ > @@ -685,7 +693,7 @@ rte_vhost_driver_set_features(const char *path, uint64_t features) > /* Anyone setting feature bits is implementing their own vhost > * device backend. > */ > - vsocket->use_builtin_virtio_net = false; > + vsocket->backend_type = VIRTIO_DEV_UNKNOWN; > } > pthread_mutex_unlock(&vhost_user.mutex); > > @@ -913,7 +921,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags) > * rte_vhost_driver_set_features(), which will overwrite following > * two values. > */ > - vsocket->use_builtin_virtio_net = true; > + vsocket->backend_type = VIRTIO_DEV_BUILTIN_NET; > vsocket->supported_features = VIRTIO_NET_SUPPORTED_FEATURES; > vsocket->features = VIRTIO_NET_SUPPORTED_FEATURES; > vsocket->protocol_features = VHOST_USER_PROTOCOL_FEATURES; > @@ -1164,10 +1172,17 @@ vhost_driver_callback_get(const char *path) > } > > int > -rte_vhost_driver_start(const char *path) > +vhost_driver_start(const char *path, enum virtio_backend_type backend_type) > { > struct vhost_user_socket *vsocket; > static pthread_t fdset_tid; > + int ret; > + > + if (backend_type <= VIRTIO_DEV_UNKNOWN || > + backend_type > VIRTIO_DEV_BUILTIN_CRYPTO) { > + VHOST_LOG_CONFIG(ERR, "Wrong backend type\n"); > + return -1; > + } > > pthread_mutex_lock(&vhost_user.mutex); > vsocket = find_vhost_user_socket(path); > @@ -1200,7 +1215,20 @@ rte_vhost_driver_start(const char *path) > } > > if (vsocket->is_server) > - return vhost_user_start_server(vsocket); > + ret = vhost_user_start_server(vsocket); > else > - return vhost_user_start_client(vsocket); > + ret = vhost_user_start_client(vsocket); > + > + if (ret < 0) > + return ret; > + > + vsocket->backend_type = backend_type; > + > + return 0; > +} > + > +int > +rte_vhost_driver_start(const char *path) > +{ > + return vhost_driver_start(path, VIRTIO_DEV_BUILTIN_NET); > } > diff --git a/lib/librte_vhost/vhost.h b/lib/librte_vhost/vhost.h > index 73a1ed889..1da9ed871 100644 > --- a/lib/librte_vhost/vhost.h > +++ b/lib/librte_vhost/vhost.h > @@ -352,7 +352,6 @@ struct vring_packed_desc_event { > (1ULL << VIRTIO_F_IOMMU_PLATFORM) | \ > (1ULL << VIRTIO_F_RING_PACKED)) > > - > struct guest_page { > uint64_t guest_phys_addr; > uint64_t host_phys_addr; > diff --git a/lib/librte_vhost/vhost_crypto.c b/lib/librte_vhost/vhost_crypto.c > index e08f9c6d7..e9c6702c2 100644 > --- a/lib/librte_vhost/vhost_crypto.c > +++ b/lib/librte_vhost/vhost_crypto.c > @@ -35,13 +35,13 @@ > #define VC_LOG_DBG(fmt, args...) > #endif > > -#define VIRTIO_CRYPTO_FEATURES ((1 << VIRTIO_F_NOTIFY_ON_EMPTY) | \ > - (1 << VIRTIO_RING_F_INDIRECT_DESC) | \ > - (1 << VIRTIO_RING_F_EVENT_IDX) | \ > - (1 << VIRTIO_CRYPTO_SERVICE_CIPHER) | \ > - (1 << VIRTIO_CRYPTO_SERVICE_MAC) | \ The two above lines are not Virtio features, how can it have possibly work in the past? > - (1 << VIRTIO_NET_F_CTRL_VQ) | \ > - (1 << VHOST_USER_PROTOCOL_F_CONFIG)) > +#define VIRTIO_CRYPTO_FEATURES ((1ULL << VIRTIO_F_NOTIFY_ON_EMPTY) | \ > + (1ULL << VIRTIO_RING_F_INDIRECT_DESC) | \ > + (1ULL << VIRTIO_RING_F_EVENT_IDX) | \ > + (1ULL << VIRTIO_NET_F_CTRL_VQ) | \ > + (1ULL << VIRTIO_F_VERSION_1) | \ > + (1ULL << VHOST_USER_PROTOCOL_F_CONFIG) | \ Ouch, VHOST_USER_PROTOCOL_F_CONFIG is not a Virtio feature, but a Vhost- user protocol feature. Please remove that in a dedicated patch. > + (1ULL << VHOST_USER_F_PROTOCOL_FEATURES)) Why is this now necessary? I don't see the link with the purpose of the patch. I think I understand now! I bet that it just means that previously, VHOST_USER_GET_FEATURES was sent before Vhost-crypto would call rte_vhost_driver_set_features(), which makes a lot of sense as I said when I was surprised .new_device() was called without features not being negotiated. It was really working by luck. > > #define IOVA_TO_VVA(t, r, a, l, p) \ > ((t)(uintptr_t)vhost_iova_to_vva(r->dev, r->vq, a, l, p)) > @@ -1400,6 +1400,20 @@ vhost_crypto_complete_one_vm_requests(struct rte_crypto_op **ops, > return processed; > } > > +void > +vhost_crypto_set_feature_flags(uint64_t *feature_flags, > + uint64_t *protocol_feature_flags) > +{ > + *feature_flags = VIRTIO_CRYPTO_FEATURES; > + *protocol_feature_flags |= (1ULL << VHOST_USER_PROTOCOL_F_CONFIG); > +} So above function can be removed. > +int > +rte_vhost_crypto_driver_start(const char *path) > +{ Here we set supported Virtio and Vhost-usuer protocol features: int ret; ret = rte_vhost_driver_set_features(path, VIRTIO_CRYPTO_FEATURES); if (ret) return -1; ret = rte_vhost_driver_get_protocol_features(path, &protocol_features); if (ret) return -1; protocol_features |= VHOST_USER_PROTOCOL_F_CONFIG; ret = rte_vhost_driver_set_protocol_features(path, protocol_features); if (ret) return -1; > + return vhost_driver_start(path, VIRTIO_DEV_BUILTIN_CRYPTO); > +} > + > int > rte_vhost_crypto_create(int vid, uint8_t cryptodev_id, > struct rte_mempool *sess_pool, > @@ -1417,13 +1431,6 @@ rte_vhost_crypto_create(int vid, uint8_t cryptodev_id, > return -EINVAL; > } > > - ret = rte_vhost_driver_set_features(dev->ifname, > - VIRTIO_CRYPTO_FEATURES); > - if (ret < 0) { > - VC_LOG_ERR("Error setting features"); > - return -1; > - } > - > vcrypto = rte_zmalloc_socket(NULL, sizeof(*vcrypto), > RTE_CACHE_LINE_SIZE, socket_id); > if (!vcrypto) { > diff --git a/lib/librte_vhost/vhost_user.h b/lib/librte_vhost/vhost_user.h > index 16fe03f88..d28da17dd 100644 > --- a/lib/librte_vhost/vhost_user.h > +++ b/lib/librte_vhost/vhost_user.h > @@ -158,6 +158,12 @@ typedef struct VhostUserMsg { > /* The version of the protocol we support */ > #define VHOST_USER_VERSION 0x1 > > +/* virtio backend types */ > +enum virtio_backend_type { > + VIRTIO_DEV_UNKNOWN = 0, /* Likely external */ > + VIRTIO_DEV_BUILTIN_NET, /* Virtio-net device */ > + VIRTIO_DEV_BUILTIN_CRYPTO, /* Virtio-crypto device */ > +}; > > /* vhost_user.c */ > int vhost_user_msg_handler(int vid, int fd); > @@ -167,5 +173,11 @@ int vhost_user_iotlb_miss(struct virtio_net *dev, uint64_t iova, uint8_t perm); > int read_fd_message(int sockfd, char *buf, int buflen, int *fds, int max_fds, > int *fd_num); > int send_fd_message(int sockfd, char *buf, int buflen, int *fds, int fd_num); > +int vhost_driver_start(const char *path, > + enum virtio_backend_type backend_type); > + > +/* vhost_crypto.c */ > +void vhost_crypto_set_feature_flags(uint64_t *feature_flags, > + uint64_t *protocol_feature_flags); > > #endif >