patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <>
To: David Hunt <>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v4] lib/power: remove set env deprecation notice
Date: Tue, 03 Nov 2020 21:46:05 +0100	[thread overview]
Message-ID: <2897228.yid56MYTPc@thomas> (raw)
In-Reply-To: <>

27/10/2020 14:24, David Hunt:
> Remove notice announcing an already-implemented change.
> In 19.05, rte_power_set_env was changed to return -1 in cases where
> the envorinment was already set up, and for the same release, a
> deprecation notice was added for the following commit:
> 'commit 5a5f3178d4a8 ("power: return error when environment already set")'
> This patch removes that notice.
> The API change was tested by calling rte_power_set_env twice. The first
> call succeeded, and the second call failed, as expected.
> Signed-off-by: David Hunt <>
> ---
> v1 initial version (with typo in the title)
> v2 fix typo but forgot --in-reply-to
> v3 add -in-reply-to
> v4 add in version info, and cc stable in case it needs to be backported
> Note: CC'ing stable in case the deprecation notice should also be removed
> from 19.11. It looks to me like the patch making the change and the patch
> adding the notice were both added in 19.11, so the notice is no longer
> needed in that verion. I didn't add a Fixes line to this patch as I believe
> the notice was correct, just adding both fix and notice in the same version
> was not strictly the right thing to have done at the time.

The Fixes: line must reference the commit which did the API change
without removing the notice.

Cc: must be below the Fixes line.

  reply	other threads:[~2020-11-03 20:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <>
2020-10-27 13:24 ` [dpdk-stable] " David Hunt
2020-11-03 20:46   ` Thomas Monjalon [this message]
2020-11-04  9:28   ` [dpdk-stable] [PATCH v5] " David Hunt
2020-11-04 20:10     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2897228.yid56MYTPc@thomas \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).