patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org, rasland@nvidia.com,
	matan@nvidia.com, asafp@nvidia.com, david.marchand@redhat.com
Subject: Re: [dpdk-stable] [PATCH 1/4] common/mlx5: share UAR allocation routine
Date: Sat, 14 Nov 2020 11:01:04 +0100
Message-ID: <2912116.G3pJfsNsrf@thomas> (raw)
In-Reply-To: <1605024259-18318-1-git-send-email-viacheslavo@nvidia.com>

10/11/2020 17:04, Viacheslav Ovsiienko:
> +void *
> +mlx5_devx_alloc_uar(void *ctx, int mapping)
> +{
> +	void *uar;
> +	uint32_t retry, uar_mapping;
> +	void *base_addr;
> +
> +	for (retry = 0; retry < MLX5_ALLOC_UAR_RETRY; ++retry) {
> +#ifdef MLX5DV_UAR_ALLOC_TYPE_NC
> +		/* Control the mapping type according to the settings. */
> +		uar_mapping = (mapping < 0) ?
> +			      MLX5DV_UAR_ALLOC_TYPE_NC : mapping;
> +#else
> +		/*
> +		 * It seems we have no way to control the memory mapping type
> +		 * for the UAR, the default "Write-Combining" type is supposed.
> +		 */
> +		uar_mapping = 0;
> +#endif

A failure was reported by the CI:
	error: unused parameter ‘mapping’
It is fixed while merging by adding the below in the #else case:
	RTE_SET_USED(mapping);

Please take care of CI results!



      parent reply	other threads:[~2020-11-14 10:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-10 16:04 Viacheslav Ovsiienko
2020-11-10 16:04 ` [dpdk-stable] [PATCH 2/4] regex/mlx5: fix UAR allocation Viacheslav Ovsiienko
2020-11-10 16:04 ` [dpdk-stable] [PATCH 3/4] vdpa/mlx5: " Viacheslav Ovsiienko
2020-11-14  8:36 ` [dpdk-stable] [PATCH 1/4] common/mlx5: share UAR allocation routine Thomas Monjalon
2020-11-14 10:01 ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2912116.G3pJfsNsrf@thomas \
    --to=thomas@monjalon.net \
    --cc=asafp@nvidia.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=rasland@nvidia.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git