* [dpdk-stable] [PATCH 17.11] net/mlx5: fix return value when deleting fdir filter
@ 2018-08-16 18:59 Yongseok Koh
2018-08-16 19:01 ` Yongseok Koh
0 siblings, 1 reply; 2+ messages in thread
From: Yongseok Koh @ 2018-08-16 18:59 UTC (permalink / raw)
To: shahafs; +Cc: stable, Yongseok Koh
rte_errno may have garbage value if there's no error.
Fixes: 7075f007b361 ("net/mlx5: standardize on negative errno values")
Fixes: 8e47ba2b073a ("net/mlx5: fix error number handling")
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
---
drivers/net/mlx5/mlx5_flow.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 7e4b84292..7e69f6aba 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -3001,9 +3001,11 @@ mlx5_fdir_filter_delete(struct rte_eth_dev *dev,
if (parser.queue[i].ibv_attr)
rte_free(parser.queue[i].ibv_attr);
}
- if (ret)
+ if (ret) {
rte_errno = ret; /* Restore rte_errno. */
- return -rte_errno;
+ return -rte_errno;
+ }
+ return 0;
}
/**
--
2.11.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH 17.11] net/mlx5: fix return value when deleting fdir filter
2018-08-16 18:59 [dpdk-stable] [PATCH 17.11] net/mlx5: fix return value when deleting fdir filter Yongseok Koh
@ 2018-08-16 19:01 ` Yongseok Koh
0 siblings, 0 replies; 2+ messages in thread
From: Yongseok Koh @ 2018-08-16 19:01 UTC (permalink / raw)
To: Shahaf Shuler; +Cc: stable
> On Aug 16, 2018, at 11:59 AM, Yongseok Koh <yskoh@mellanox.com> wrote:
>
> rte_errno may have garbage value if there's no error.
>
> Fixes: 7075f007b361 ("net/mlx5: standardize on negative errno values")
> Fixes: 8e47ba2b073a ("net/mlx5: fix error number handling")
>
> Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
> ---
applied to stable/17.11
Thanks,
Yongseok
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-16 19:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-16 18:59 [dpdk-stable] [PATCH 17.11] net/mlx5: fix return value when deleting fdir filter Yongseok Koh
2018-08-16 19:01 ` Yongseok Koh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).