From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org
Cc: Piotr Pietruszewski <piotr.pietruszewski@intel.com>,
vladimir.medvedkin@intel.com, bruce.richardson@intel.com,
stable@dpdk.org, Skajewski@dpdk.org,
PiotrX <piotrx.skajewski@intel.com>,
Marek Mical <marekx.mical@intel.com>,
Kirsher@dpdk.org, Jeffrey T <jeffrey.t.kirsher@intel.com>,
Michael@dpdk.org, Alice <alice.michael@intel.com>
Subject: [PATCH v1 01/22] net/ixgbe/base: revert remove default advertising for x550 2.5G/5G
Date: Wed, 24 Apr 2024 14:21:35 +0100 [thread overview]
Message-ID: <2accdfc6a96ea61acb30ef431e17c380dc538eba.1713964708.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <cover.1713964707.git.anatoly.burakov@intel.com>
From: Piotr Pietruszewski <piotr.pietruszewski@intel.com>
This reverts the following commit:
13de2444449e ("net/ixgbe/base: remove default advertising for x550 2.5G/5G")
The commit removing advertising 2.5G and 5G speeds from
ixgbe_get_copper_speeds_supported() was supposed to disable 2.5G and 5G
during the autonegotiation with default settings. However, that change
prevented OS-specific part of the driver from forcing these speeds at
user request.
This change reverts the commit and adds 2.5G and 5G as speeds supported
by the X550.
Cc: stable@dpdk.org
Signed-off-by: Piotr Pietruszewski <piotr.pietruszewski@intel.com>
Reviewed-by: Skajewski, PiotrX <piotrx.skajewski@intel.com>
Reviewed-by: Marek Mical <marekx.mical@intel.com>
Reviewed-by: Kirsher, Jeffrey T <jeffrey.t.kirsher@intel.com>
Reviewed-by: Michael, Alice <alice.michael@intel.com>
---
drivers/net/ixgbe/base/ixgbe_phy.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ixgbe/base/ixgbe_phy.c b/drivers/net/ixgbe/base/ixgbe_phy.c
index 74c5db16fa..3a8e603472 100644
--- a/drivers/net/ixgbe/base/ixgbe_phy.c
+++ b/drivers/net/ixgbe/base/ixgbe_phy.c
@@ -915,6 +915,10 @@ static s32 ixgbe_get_copper_speeds_supported(struct ixgbe_hw *hw)
hw->phy.speeds_supported |= IXGBE_LINK_SPEED_100_FULL;
switch (hw->mac.type) {
+ case ixgbe_mac_X550:
+ hw->phy.speeds_supported |= IXGBE_LINK_SPEED_2_5GB_FULL;
+ hw->phy.speeds_supported |= IXGBE_LINK_SPEED_5GB_FULL;
+ break;
case ixgbe_mac_X550EM_x:
case ixgbe_mac_X550EM_a:
hw->phy.speeds_supported &= ~IXGBE_LINK_SPEED_100_FULL;
--
2.43.0
next parent reply other threads:[~2024-04-24 13:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1713964707.git.anatoly.burakov@intel.com>
2024-04-24 13:21 ` Anatoly Burakov [this message]
2024-04-24 13:21 ` [PATCH v1 02/22] net/ixgbe/base: fix wrong 5G link speed reported on VF Anatoly Burakov
2024-04-24 13:21 ` [PATCH v1 03/22] net/ixgbe/base: fix PHY ID for X550 Anatoly Burakov
[not found] ` <cover.1714744628.git.anatoly.burakov@intel.com>
2024-05-03 13:57 ` [PATCH v2 01/27] net/ixgbe/base: revert remove default advertising for x550 2.5G/5G Anatoly Burakov
2024-05-03 13:57 ` [PATCH v2 02/27] net/ixgbe/base: fix wrong 5G link speed reported on VF Anatoly Burakov
2024-05-03 13:57 ` [PATCH v2 03/27] net/ixgbe/base: fix PHY ID for X550 Anatoly Burakov
[not found] ` <cover.1717067518.git.anatoly.burakov@intel.com>
2024-05-30 11:13 ` [PATCH v3 01/30] net/ixgbe/base: revert remove default advertising for x550 2.5G/5G Anatoly Burakov
2024-05-30 11:13 ` [PATCH v3 02/30] net/ixgbe/base: fix wrong 5G link speed reported on VF Anatoly Burakov
2024-05-30 11:13 ` [PATCH v3 03/30] net/ixgbe/base: fix PHY ID for X550 Anatoly Burakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2accdfc6a96ea61acb30ef431e17c380dc538eba.1713964708.git.anatoly.burakov@intel.com \
--to=anatoly.burakov@intel.com \
--cc=Kirsher@dpdk.org \
--cc=Michael@dpdk.org \
--cc=Skajewski@dpdk.org \
--cc=alice.michael@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=marekx.mical@intel.com \
--cc=piotr.pietruszewski@intel.com \
--cc=piotrx.skajewski@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).