From: oulijun <oulijun@huawei.com>
To: Luca Boccassi <bluca@debian.org>, <stable@dpdk.org>
Cc: <linuxarm@huawei.com>
Subject: Re: [dpdk-stable] [PATCH 19.11.6 00/13] backport for 19.11.6
Date: Tue, 24 Nov 2020 22:27:50 +0800 [thread overview]
Message-ID: <2b8e45e6-5764-8ec6-bf71-37644ea2193b@huawei.com> (raw)
In-Reply-To: <18a6430d79fd41752f54ec79d73404b9c69d0914.camel@debian.org>
在 2020/11/23 23:52, Luca Boccassi 写道:
> On Fri, 2020-11-13 at 21:36 +0800, Lijun Ou wrote:
>> Hi, Luca Boccassi
>> His series are backport for 19.11.6 about hns3 PMD driver
>> I also noticed that you gave Hu Wei a suggestion on the 19.11.4
>> backport. You did not recommend adding new features. I reselected
>> the TSO and some performance optimization patch request backports.
>> The reason I do this is that I think TSO is also a performance
>> optimization point, including other fixes. In addition, if TSO
>> is not integrated, the bug fixes of the cksum may not be integrated,
>> which will cause the stability of the cksum function.
>>
>> Chengchang Tang (5):
>> net/hns3: support promiscuous and allmulticast mode for VF
>> net/hns3: decrease non-nearby memory access in Rx
>> net/hns3: cleanup duplicated code on processing TSO in Tx
>> net/hns3: fix Tx checksum outer header prepare
>> net/hns3: fix Tx checksum with fixed header length
>>
>> Hongbo Zheng (1):
>> net/hns3: check TSO segment size during Tx
>>
>> Lijun Ou (2):
>> net/hns3: support TSO
>> net/hns3: report Tx descriptor segment limitations
>>
>> Wei Hu (Xavier) (5):
>> net/hns3: fix reassembling multiple segment packets in Tx
>> net/hns3: fix inserted VLAN tag position in Tx
>> net/hns3: report Rx drop packets enable configuration
>> net/hns3: report Rx free threshold
>> net/hns3: reduce address calculation in Rx
>>
>> doc/guides/nics/features/hns3.ini | 1 +
>> doc/guides/nics/features/hns3_vf.ini | 3 +
>> doc/guides/nics/hns3.rst | 1 +
>> drivers/net/hns3/hns3_ethdev.c | 38 +-
>> drivers/net/hns3/hns3_ethdev.h | 37 +-
>> drivers/net/hns3/hns3_ethdev_vf.c | 134 ++++++-
>> drivers/net/hns3/hns3_mbx.c | 23 ++
>> drivers/net/hns3/hns3_mbx.h | 2 +
>> drivers/net/hns3/hns3_rxtx.c | 666 ++++++++++++++++++++++++-----------
>> drivers/net/hns3/hns3_rxtx.h | 31 +-
>> 10 files changed, 720 insertions(+), 216 deletions(-)
>
> Hi,
>
> I discussed this proposal with other maintainers, and I'm afraid the
> original answer still stands - we feel backporting an entire new
> offload is too much for the scope of an LTS release.
>
> While sometimes we do allow for some featurettes to be backported, in
> the form of a new #define or such small changes, there was consensus
> that a 936 lines diff is too much churn for what is expected from a
> stable release, which is stability. The risk of introducing new bugs,
> especially in face of the fact that we never had regression tests
> coverage for the hns3 PMD for LTSes before, is too high.
>
> The 20.05/20.08 releases are ABI compatible with 19.11, so if there's
> an urgent need for this feature in users of the hns3 PMD, one of those
> can be used instead. Some other companies also maintain downstream
> trees of the LTSes with invasive changes to their PMDs, that are deemed
> too risky for the upstream tree, so that's another option available to
> you.
>
> Sorry!
>
I see. Can I re-split the bugfix of the TSO part based on the patch and
return it to you?
Thanks
Lijun Ou
next prev parent reply other threads:[~2020-11-24 14:28 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 13:36 Lijun Ou
2020-11-13 13:36 ` [dpdk-stable] [PATCH 19.11.6 01/13] net/hns3: support TSO Lijun Ou
2020-11-13 13:36 ` [dpdk-stable] [PATCH 19.11.6 02/13] net/hns3: check TSO segment size during Tx Lijun Ou
2020-11-13 13:37 ` [dpdk-stable] [PATCH 19.11.6 03/13] net/hns3: fix reassembling multiple segment packets in Tx Lijun Ou
2020-11-13 13:37 ` [dpdk-stable] [PATCH 19.11.6 04/13] net/hns3: support promiscuous and allmulticast mode for VF Lijun Ou
2020-11-13 13:37 ` [dpdk-stable] [PATCH 19.11.6 05/13] net/hns3: decrease non-nearby memory access in Rx Lijun Ou
2020-11-13 13:37 ` [dpdk-stable] [PATCH 19.11.6 06/13] net/hns3: cleanup duplicated code on processing TSO in Tx Lijun Ou
2020-11-13 13:37 ` [dpdk-stable] [PATCH 19.11.6 07/13] net/hns3: fix inserted VLAN tag position " Lijun Ou
2020-11-13 13:37 ` [dpdk-stable] [PATCH 19.11.6 08/13] net/hns3: report Tx descriptor segment limitations Lijun Ou
2020-11-13 13:37 ` [dpdk-stable] [PATCH 19.11.6 09/13] net/hns3: report Rx drop packets enable configuration Lijun Ou
2020-11-13 13:37 ` [dpdk-stable] [PATCH 19.11.6 10/13] net/hns3: report Rx free threshold Lijun Ou
2020-11-13 13:37 ` [dpdk-stable] [PATCH 19.11.6 11/13] net/hns3: reduce address calculation in Rx Lijun Ou
2020-11-13 13:37 ` [dpdk-stable] [PATCH 19.11.6 12/13] net/hns3: fix Tx checksum outer header prepare Lijun Ou
2020-11-13 13:37 ` [dpdk-stable] [PATCH 19.11.6 13/13] net/hns3: fix Tx checksum with fixed header length Lijun Ou
2020-11-23 15:52 ` [dpdk-stable] [PATCH 19.11.6 00/13] backport for 19.11.6 Luca Boccassi
2020-11-24 14:27 ` oulijun [this message]
2020-11-24 15:35 ` Luca Boccassi
2020-11-25 3:24 ` [dpdk-stable] [PATCH v2 19.11.6 0/7] " Lijun Ou
2020-11-25 3:24 ` [dpdk-stable] [PATCH v2 19.11.6 1/7] net/hns3: fix reassembling multiple segment packets in Tx Lijun Ou
2020-11-25 3:24 ` [dpdk-stable] [PATCH v2 19.11.6 2/7] net/hns3: decrease non-nearby memory access in Rx Lijun Ou
2020-11-25 3:24 ` [dpdk-stable] [PATCH v2 19.11.6 3/7] net/hns3: report Tx descriptor segment limitations Lijun Ou
2020-11-25 9:16 ` Luca Boccassi
2020-11-25 10:59 ` oulijun
2020-11-25 3:24 ` [dpdk-stable] [PATCH v2 19.11.6 4/7] net/hns3: report Rx drop packets enable configuration Lijun Ou
2020-11-25 3:24 ` [dpdk-stable] [PATCH v2 19.11.6 5/7] net/hns3: report Rx free threshold Lijun Ou
2020-11-25 3:24 ` [dpdk-stable] [PATCH v2 19.11.6 6/7] net/hns3: reduce address calculation in Rx Lijun Ou
2020-11-25 3:24 ` [dpdk-stable] [PATCH v2 19.11.6 7/7] net/hns3: fix TX checksum with fix header length Lijun Ou
2020-11-25 10:58 ` [dpdk-stable] [PATCH v3 19.11.6 0/6] backport for 19.11.6 Lijun Ou
2020-11-25 10:58 ` [dpdk-stable] [PATCH v3 19.11.6 1/6] net/hns3: fix reassembling multiple segment packets in Tx Lijun Ou
2020-11-25 10:58 ` [dpdk-stable] [PATCH v3 19.11.6 2/6] net/hns3: decrease non-nearby memory access in Rx Lijun Ou
2020-11-25 10:58 ` [dpdk-stable] [PATCH v3 19.11.6 3/6] net/hns3: report Rx drop packets enable configuration Lijun Ou
2020-11-25 10:58 ` [dpdk-stable] [PATCH v3 19.11.6 4/6] net/hns3: report Rx free threshold Lijun Ou
2020-11-25 10:58 ` [dpdk-stable] [PATCH v3 19.11.6 5/6] net/hns3: reduce address calculation in Rx Lijun Ou
2020-11-25 10:58 ` [dpdk-stable] [PATCH v3 19.11.6 6/6] net/hns3: fix TX checksum with fix header length Lijun Ou
2020-11-25 11:15 ` [dpdk-stable] [PATCH v4 19.11.6 0/6] backport for 19.11.6 Lijun Ou
2020-11-25 11:15 ` [dpdk-stable] [PATCH v4 19.11.6 1/6] net/hns3: fix reassembling multiple segment packets in Tx Lijun Ou
2020-11-25 11:15 ` [dpdk-stable] [PATCH v4 19.11.6 2/6] net/hns3: decrease non-nearby memory access in Rx Lijun Ou
2020-11-25 11:15 ` [dpdk-stable] [PATCH v4 19.11.6 3/6] net/hns3: report Rx drop packets enable configuration Lijun Ou
2020-11-25 11:15 ` [dpdk-stable] [PATCH v4 19.11.6 4/6] net/hns3: report Rx free threshold Lijun Ou
2020-11-25 11:15 ` [dpdk-stable] [PATCH v4 19.11.6 5/6] net/hns3: reduce address calculation in Rx Lijun Ou
2020-11-25 11:15 ` [dpdk-stable] [PATCH v4 19.11.6 6/6] net/hns3: fix TX checksum with fix header length Lijun Ou
2020-11-26 9:21 ` [dpdk-stable] [PATCH v4 19.11.6 0/6] backport for 19.11.6 Luca Boccassi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2b8e45e6-5764-8ec6-bf71-37644ea2193b@huawei.com \
--to=oulijun@huawei.com \
--cc=bluca@debian.org \
--cc=linuxarm@huawei.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).