From: Tom Rix <trix@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
dev@dpdk.org, stable@dpdk.org, nicolas.chautru@intel.com
Subject: Re: [dpdk-stable] [PATCH 0/2] baseband: fix segfault in Intel drivers
Date: Tue, 6 Oct 2020 09:05:04 -0700 [thread overview]
Message-ID: <2d9f26e9-41d9-d104-6010-821373222b24@redhat.com> (raw)
In-Reply-To: <20201006100421.72210-1-maxime.coquelin@redhat.com>
This change looks fine.
Reviewed-by: Tom Rix <trix@redhat.com>
In looking at the surrounding code i see the is-pf bool being found by checking the driver name.
That is a fairly expensive check.
Is there a better way to do that ?
Tom
On 10/6/20 3:04 AM, Maxime Coquelin wrote:
> This series fixes segfaults in fpga_5gnr_fec and fpga_lte_fec
> drivers when bbdev debug is enabled.
>
> Maxime Coquelin (2):
> baseband/fpga_5gnr_fec: fix segfaults with debug
> baseband/fpga_lte_fec: fix segfaults with debug
>
> drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 4 ++--
> drivers/baseband/fpga_lte_fec/fpga_lte_fec.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
next prev parent reply other threads:[~2020-10-06 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-06 10:04 Maxime Coquelin
2020-10-06 10:04 ` [dpdk-stable] [PATCH 1/2] baseband/fpga_5gnr_fec: fix segfaults with debug Maxime Coquelin
2020-10-06 16:14 ` Chautru, Nicolas
2020-10-06 16:34 ` Maxime Coquelin
2020-10-06 17:41 ` Chautru, Nicolas
2020-10-06 10:04 ` [dpdk-stable] [PATCH 2/2] baseband/fpga_lte_fec: " Maxime Coquelin
2020-10-06 16:05 ` Tom Rix [this message]
2020-10-06 21:07 ` [dpdk-stable] [dpdk-dev] [PATCH 0/2] baseband: fix segfault in Intel drivers Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d9f26e9-41d9-d104-6010-821373222b24@redhat.com \
--to=trix@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=nicolas.chautru@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).