patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: Slava Ovsiienko <viacheslavo@nvidia.com>,
	"stable@dpdk.org" <stable@dpdk.org>
Cc: "mohsinshaikh@niometrics.com" <mohsinshaikh@niometrics.com>
Subject: Re: [dpdk-stable] [PATCH] [18.11] net/mlx5: use open/read/close for ib stats query
Date: Tue, 8 Dec 2020 12:52:53 +0000
Message-ID: <300b1000-3404-c2fb-e80f-96ee1d5896b3@redhat.com> (raw)
In-Reply-To: <MWHPR12MB150108F7140E648A57BA965DDFCD0@MWHPR12MB1501.namprd12.prod.outlook.com>

On 08/12/2020 12:41, Slava Ovsiienko wrote:
> OK, so, should I resend v2 with:
> - no From: tag
> - add [ upstream commit 00437823cb80b8fa87dbe61becc07bd42ee98549 ]
> 

Got it, thanks.

> With best regards, Slava
> 
>> -----Original Message-----
>> From: Kevin Traynor <ktraynor@redhat.com>
>> Sent: Tuesday, December 8, 2020 14:07
>> To: Slava Ovsiienko <viacheslavo@nvidia.com>; stable@dpdk.org
>> Cc: mohsinshaikh@niometrics.com
>> Subject: Re: [PATCH] [18.11] net/mlx5: use open/read/close for ib stats query
>>
>> On 08/12/2020 11:34, Viacheslav Ovsiienko wrote:
>>> From: Mohsin Shaikh <mohsinshaikh@niometrics.com>
>>>
>>> From: Mohsin Shaikh <mohsinshaikh@niometrics.com>
>>>
>> Hi Slava, your patches are putting in duplicate From: tags ^ and missing
>> upstream commit ids. Please add upstream commit ids so I don't have to find it
>> for every patch. i.e.
>>
>> [ upstream commit 00437823cb80b8fa87dbe61becc07bd42ee98549 ]
>>
>>> fgets(3)/fread(3)/fscanf(3) etc. use mmap(2)/munmap(2) which leads to
>>> TLB shutdown interrupts to all DPDK app cores including RX cores.
>>> This can cause packet drops. Use read(2)/write(2) instead.
>>>
>>> Bugzilla ID: 440
>>> Cc: stable@dpdk.org
>>>
>> We can drop the stable tag as it's targetted to LTS branch anyway
>>
>>> Signed-off-by: Mohsin Shaikh <mohsinshaikh@niometrics.com>
>>> Reviewed-by: Alexander Kozyrev <akozyrev@mellanox.com>
>>> Acked-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
>>> ---
>>>  drivers/net/mlx5/mlx5_stats.c | 21 ++++++++++++++-------
>>>  1 file changed, 14 insertions(+), 7 deletions(-)


  reply	other threads:[~2020-12-08 12:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-08 11:34 Viacheslav Ovsiienko
2020-12-08 12:06 ` Kevin Traynor
2020-12-08 12:41   ` Slava Ovsiienko
2020-12-08 12:52     ` Kevin Traynor [this message]
  -- strict thread matches above, loose matches on Subject: below --
2020-06-17  7:18 [dpdk-stable] [PATCH 18.11] " Mohsin Shaikh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=300b1000-3404-c2fb-e80f-96ee1d5896b3@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=mohsinshaikh@niometrics.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

patches for DPDK stable branches

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ https://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git