From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>,
Christophe Fontaine <cfontain@redhat.com>,
Robin Jarry <rjarry@redhat.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH dpdk v2] net: ipv6 link local compliance with rfc 4291
Date: Wed, 19 Nov 2025 01:07:30 +0100 [thread overview]
Message-ID: <3249247.iZASKD2KPV@thomas> (raw)
In-Reply-To: <20251118174526.321856-1-rjarry@redhat.com>
18/11/2025 18:45, Robin Jarry:
> From: Christophe Fontaine <cfontain@redhat.com>
> > Modified EUI-64 format interface identifiers are formed by inverting
> > the "u" bit (universal/local bit in IEEE EUI-64 terminology) when
> > forming the interface identifier from IEEE EUI-64 identifiers.
[...]
> - ip->a[8] = mac->addr_bytes[0];
> + ip->a[8] = mac->addr_bytes[0] ^ RTE_ETHER_LOCAL_ADMIN_ADDR;
In all other places, we use the operator OR, so I'm not sure about this XOR.
Also, rte_is_universal_ether_addr() and rte_is_local_admin_ether_addr()
are comparing this bit with 0.
Is this bit always 0 by default in MAC addresses?
next prev parent reply other threads:[~2025-11-19 0:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 10:57 [PATCH dpdk] " Robin Jarry
2025-11-14 16:05 ` Stephen Hemminger
2025-11-14 16:08 ` Robin Jarry
2025-11-14 16:14 ` Morten Brørup
2025-11-14 16:46 ` Robin Jarry
2025-11-14 17:03 ` Stephen Hemminger
2025-11-15 17:57 ` Robin Jarry
2025-11-14 16:48 ` Stephen Hemminger
2025-11-14 16:08 ` Stephen Hemminger
2025-11-18 17:45 ` [PATCH dpdk v2] " Robin Jarry
2025-11-19 0:07 ` Thomas Monjalon [this message]
2025-11-19 0:27 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3249247.iZASKD2KPV@thomas \
--to=thomas@monjalon.net \
--cc=cfontain@redhat.com \
--cc=dev@dpdk.org \
--cc=rjarry@redhat.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).