From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 34A0F48B45 for ; Wed, 19 Nov 2025 01:07:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F1D0402DC; Wed, 19 Nov 2025 01:07:38 +0100 (CET) Received: from fout-b7-smtp.messagingengine.com (fout-b7-smtp.messagingengine.com [202.12.124.150]) by mails.dpdk.org (Postfix) with ESMTP id 282544027A; Wed, 19 Nov 2025 01:07:35 +0100 (CET) Received: from phl-compute-02.internal (phl-compute-02.internal [10.202.2.42]) by mailfout.stl.internal (Postfix) with ESMTP id 3BC0D1D0018D; Tue, 18 Nov 2025 19:07:34 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-02.internal (MEProxy); Tue, 18 Nov 2025 19:07:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1763510854; x=1763597254; bh=Wi/VUKR4+GEEoCfHlg9e6sKXGLA4wQpgw3Ze3vV+b6Y=; b= rNmj3J+JvY//YWnvC57eO462oJ1f+zLhJikkGZjYRsHOarQSUyFPm7jtJPIAGOMv C6SldYFlCchMX8vQ/q5m8sbtlKwibQFSZUv+SnxQqNesSmo5awevDaN7HyShdDjZ 1zob+QF9jpFAZGQkL1gwVKm1SRH7Acrt3UZkeFWmHQ9tmLAm8DclCSU76WZJuA0b RghmXUza/jw6OoVywXywcVDgHD8QB2wnGzmYdbk3QpPWugL6nxE8z8ydYp5VJ5// DMwGTbbUD91rH2BfpkGHPYEwpjXlcI5+mvjDdrFiWR0s8KihBsJlBTeHGsAyczl2 u/eNZG7f58gA+1LmJ3uptw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1763510854; x= 1763597254; bh=Wi/VUKR4+GEEoCfHlg9e6sKXGLA4wQpgw3Ze3vV+b6Y=; b=M ThA0hNvZ96QJwtsBy2RXWcdLA6gThYi7CScocKNPkiv4VbhVNgypIzub4rF+k9FI aii/j4bRLQnMEPtkPpTclf3NcjSH+7Fn7mqanH+mJ3XJDbxqW6tBcdXidwxydaKo pZdr1+VZz4fwdUXztmgeGdX5y73VKBxAsD7KGlpeXpSLNGW/dD7+JUzMCtsjFfCs qHGZyJr6ec1nCv7LZ+YZaZFXtFdY9OwmRJSq3IS1Q7Lu/OyIb4RGpwkivFQPc1PY XjQzMw1AN6CcfzjuHc2Txjb9cOgLo1HPTZ0XKSsConUUbXTrVYg0FvDJAkCBfCNn Yvux69AXgqHuaqn/9D6aw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdeggddvvddvjedvucetufdoteggodetrf dotffvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceu rghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujf gurhephffvvefufffkjghfggfgtgesthfuredttddtjeenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpeejudevheeiveduuddtveffgfdtgeekueevjeffjeegtdeggeekgfdv uefgfeekjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhroh hmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtpdhnsggprhgtphhtthhopeehpdhm ohguvgepshhmthhpohhuthdprhgtphhtthhopehsthgvphhhvghnsehnvghtfihorhhkph hluhhmsggvrhdrohhrghdprhgtphhtthhopegtfhhonhhtrghinhesrhgvughhrghtrdgt ohhmpdhrtghpthhtoheprhhjrghrrhihsehrvgguhhgrthdrtghomhdprhgtphhtthhope guvghvseguphgukhdrohhrghdprhgtphhtthhopehsthgrsghlvgesughpughkrdhorhhg X-ME-Proxy: Feedback-ID: i47234305:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 18 Nov 2025 19:07:32 -0500 (EST) From: Thomas Monjalon To: Stephen Hemminger , Christophe Fontaine , Robin Jarry Cc: dev@dpdk.org, stable@dpdk.org Subject: Re: [PATCH dpdk v2] net: ipv6 link local compliance with rfc 4291 Date: Wed, 19 Nov 2025 01:07:30 +0100 Message-ID: <3249247.iZASKD2KPV@thomas> In-Reply-To: <20251118174526.321856-1-rjarry@redhat.com> References: <20251114105751.54802-3-rjarry@redhat.com> <20251118174526.321856-1-rjarry@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org 18/11/2025 18:45, Robin Jarry: > From: Christophe Fontaine > > Modified EUI-64 format interface identifiers are formed by inverting > > the "u" bit (universal/local bit in IEEE EUI-64 terminology) when > > forming the interface identifier from IEEE EUI-64 identifiers. [...] > - ip->a[8] = mac->addr_bytes[0]; > + ip->a[8] = mac->addr_bytes[0] ^ RTE_ETHER_LOCAL_ADMIN_ADDR; In all other places, we use the operator OR, so I'm not sure about this XOR. Also, rte_is_universal_ether_addr() and rte_is_local_admin_ether_addr() are comparing this bit with 0. Is this bit always 0 by default in MAC addresses?