From: Kevin Traynor <ktraynor@redhat.com>
To: Jasvinder Singh <jasvinder.singh@intel.com>
Cc: Thomas Monjalon <thomas@monjalon.net>,
dev@dpdk.org, cristian.dumitrescu@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix wrong value of tc ov weight
Date: Wed, 4 Sep 2019 18:26:04 +0100 [thread overview]
Message-ID: <33062748-95a6-a9d5-ae32-3b792117b4f9@redhat.com> (raw)
In-Reply-To: <3667816.tTLe76bmax@xps>
On 06/08/2019 14:26, Thomas Monjalon wrote:
> 06/08/2019 13:49, Jasvinder Singh:
>> The sched library checks the subport tc ov weight value regardless
>> of whether RTE_SCHED_SUBPORT_TC_OV flag is enabled or not.
>>
>> This fix allows application to always set valid tc ov weight value.
>>
>> Fixes: 25961ff3bcb9 ("examples/ip_pipeline: add traffic manager object")
>>
FYI, tc_ov_weight is not visible without the RTE_SCHED_SUBPORT_TC_OV until
Fixes: ca4d5915b877 ("sched: add config flexibility to TC queue sizes")
so this will not build on 18.11 stable.
>> error log
>> SCHED: pipe_profile_check: Incorrect value for tc ov weight
>> SCHED: rte_sched_port_check_params: Pipe profile check failed(-22)
>> Command "tmgr" failed.
>>
>> Signed-off-by: Jasvinder Singh <jasvinder.singh@intel.com>
>> Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
>> ---
>> v2:
>> - add fix line
>> - change title
>
> "tc ov" is not that obvious.
> I changed the title to "examples/ip_pipeline: fix TC oversubscription weight"
>
> +Add Cc stable
>
> Applied, thanks
>
>
prev parent reply other threads:[~2019-09-04 17:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190731113322.135053-1-jasvinder.singh@intel.com>
[not found] ` <20190806114951.62131-1-jasvinder.singh@intel.com>
2019-08-06 13:26 ` Thomas Monjalon
2019-09-04 17:26 ` Kevin Traynor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33062748-95a6-a9d5-ae32-3b792117b4f9@redhat.com \
--to=ktraynor@redhat.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).