From: David Christensen <drc@linux.vnet.ibm.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"Xing, Beilei" <beilei.xing@intel.com>
Cc: "stable@dpdk.org" <stable@dpdk.org>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/i40e: fix gcc 11 build warning on POWER architecture
Date: Tue, 9 Nov 2021 14:46:19 -0800 [thread overview]
Message-ID: <336ae629-679e-0c18-58c4-a3efa302de9a@linux.vnet.ibm.com> (raw)
In-Reply-To: <6b454551353a409b8c5c661462b7d329@intel.com>
> Not sure if below patch also help to solve the issue you met on power arch,
> Looks like the error is same: "writing 1 byte into a region of size 0"
> would you help to check?
>
> commit 1b0f3a18145468c309bb5a8cb98a8aa29af059e7
> Author: Ferruh Yigit <ferruh.yigit@intel.com>
> Date: Fri Oct 29 11:37:01 2021 +0100
>
> net/i40e: fix build for 32-bit
>
> Got error with: gcc 11.2.1 "cc (GCC) 11.2.1 20210728 (Red Hat 11.2.1-1)"
>
> Build error:
> In function 'i40e_flow_parse_fdir_pattern',
> inlined from 'i40e_flow_parse_fdir_filter'
> at ../drivers/net/i40e/i40e_flow.c:3274:8:
> ../drivers/net/i40e/i40e_flow.c:3052:69:
> error: writing 1 byte into a region of size 0
> [-Werror=stringop-overflow=]
> 3052 | filter->input.flow_ext.flexbytes[j] =
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
> 3053 | raw_spec->pattern[i];
> | ~~~~~~~~~~~~~~~~~~~~
> In file included from ../drivers/net/i40e/i40e_flow.c:25:
> ../drivers/net/i40e/i40e_flow.c:
> In function 'i40e_flow_parse_fdir_filter':
> ../drivers/net/i40e/i40e_ethdev.h:638:17:
> note: at offset 16 into destination object 'flexbytes' of size 16
> 638 | uint8_t flexbytes[RTE_ETH_FDIR_MAX_FLEXLEN];
> | ^~~~~~~~~
>
> Fixing by adding range checks.
>
> Fixes: 6ced3dd72f5f ("net/i40e: support flexible payload parsing for FDIR")
> Cc: stable@dpdk.org
Yep, definitely fixed it for POWER as well with the latest GCC compiler
(Advanced Toolchain 15.0 in my case). I'll withdraw by other patch.
Thanks for the heads up.
Dave
prev parent reply other threads:[~2021-11-09 22:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-14 19:05 [dpdk-stable] " David Christensen
2021-11-05 0:50 ` [dpdk-stable] [dpdk-dev] " Zhang, Qi Z
2021-11-09 22:46 ` David Christensen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=336ae629-679e-0c18-58c4-a3efa302de9a@linux.vnet.ibm.com \
--to=drc@linux.vnet.ibm.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).