* [dpdk-stable] [PATCH 18.11] app/testpmd: fix xstats clear
@ 2020-09-16 9:58 Kevin Traynor
2020-09-16 21:13 ` Kevin Traynor
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Traynor @ 2020-09-16 9:58 UTC (permalink / raw)
To: stable; +Cc: Kevin Traynor, Wei Hu
rte_eth_xstats_reset() was mistakenly removed from
nic_xstats_clear() in fixed commit during rebasing.
This caused the xstats not be be cleared when
'clear port xstats all' was executed from the testpmd
command line.
Fix by adding back rte_eth_xstats_reset().
Fixes: 3e64dd9f527d ("app/testpmd: fix stats error message")
Cc: Wei Hu (Xavier) <xavier.huwei@huawei.com>
Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
app/test-pmd/config.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index 3b588e2042..3d854099d2 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -319,4 +319,5 @@ nic_xstats_clear(portid_t port_id)
return;
}
+ rte_eth_xstats_reset(port_id);
ret = rte_eth_stats_get(port_id, &ports[port_id].stats);
--
2.26.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [PATCH 18.11] app/testpmd: fix xstats clear
2020-09-16 9:58 [dpdk-stable] [PATCH 18.11] app/testpmd: fix xstats clear Kevin Traynor
@ 2020-09-16 21:13 ` Kevin Traynor
0 siblings, 0 replies; 2+ messages in thread
From: Kevin Traynor @ 2020-09-16 21:13 UTC (permalink / raw)
To: stable; +Cc: Wei Hu, Chen, BoX C
On 16/09/2020 10:58, Kevin Traynor wrote:
> rte_eth_xstats_reset() was mistakenly removed from
> nic_xstats_clear() in fixed commit during rebasing.
>
> This caused the xstats not be be cleared when
> 'clear port xstats all' was executed from the testpmd
> command line.
>
> Fix by adding back rte_eth_xstats_reset().
>
> Fixes: 3e64dd9f527d ("app/testpmd: fix stats error message")
>
> Cc: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
> app/test-pmd/config.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index 3b588e2042..3d854099d2 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -319,4 +319,5 @@ nic_xstats_clear(portid_t port_id)
> return;
> }
> + rte_eth_xstats_reset(port_id);
>
> ret = rte_eth_stats_get(port_id, &ports[port_id].stats);
>
Tested and applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-16 21:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-16 9:58 [dpdk-stable] [PATCH 18.11] app/testpmd: fix xstats clear Kevin Traynor
2020-09-16 21:13 ` Kevin Traynor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).