* [PATCH] devtools: fix null test for NUMA systems
@ 2022-04-13 11:19 David Marchand
2022-06-01 10:49 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: David Marchand @ 2022-04-13 11:19 UTC (permalink / raw)
To: dev; +Cc: thomas, stable
On NUMA systems, default cores (0 and 1) might be on different memory
nodes. Double the amount of memory.
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/test-null.sh | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/devtools/test-null.sh b/devtools/test-null.sh
index 4ba57a6829..6cd34f64f1 100755
--- a/devtools/test-null.sh
+++ b/devtools/test-null.sh
@@ -27,6 +27,7 @@ else
fi
(sleep 1 && echo stop) |
-$testpmd -c $coremask --no-huge -m 20 \
+# testpmd only needs 20M, make it x2 (default number of cores) for NUMA systems
+$testpmd -c $coremask --no-huge -m 40 \
$libs -a 0:0.0 --vdev net_null1 --vdev net_null2 $eal_options -- \
--no-mlockall --total-num-mbufs=2048 $testpmd_options -ia
--
2.23.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] devtools: fix null test for NUMA systems
2022-04-13 11:19 [PATCH] devtools: fix null test for NUMA systems David Marchand
@ 2022-06-01 10:49 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2022-06-01 10:49 UTC (permalink / raw)
To: David Marchand; +Cc: dev, stable
13/04/2022 13:19, David Marchand:
> On NUMA systems, default cores (0 and 1) might be on different memory
> nodes. Double the amount of memory.
>
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Fixes: 9e6b36c34ce9 ("app/testpmd: reduce memory consumption")
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-01 10:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13 11:19 [PATCH] devtools: fix null test for NUMA systems David Marchand
2022-06-01 10:49 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).