From: Thomas Monjalon <thomas@monjalon.net>
To: Matan Azrad <matan@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 0/3] mlx: fix build with -fno-common (gcc 10)
Date: Tue, 07 Apr 2020 02:19:32 +0200 [thread overview]
Message-ID: <3457836.1USP3dqvjW@thomas> (raw)
In-Reply-To: <AM0PR0502MB401926F72A8C41B49ED91296D2F60@AM0PR0502MB4019.eurprd05.prod.outlook.com>
17/03/2020 09:34, Matan Azrad:
> From: Thomas Monjalon
> > In GCC 10, -fno-common will be the default.
> > There are 2 ways of solving issues:
> > - add -fcommon
> > - stop allocating variables in .h files
> >
> > In this patchset, the variables are declared extern, because it is cleaner
> > anyway.
>
> Series-acked-by: Matan Azrad <matan@mellanox.com>
>
> > Thomas Monjalon (3):
> > common/mlx5: split glue initialization
> > common/mlx5: fix build with -fno-common
> > net/mlx4: fix build with -fno-common
It seems these patches are also fixing usage of glue dlopen
with PMD as shared library.
We should add Cc: stable@dpdk.org and identify a root cause.
next parent reply other threads:[~2020-04-07 0:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200210103216.1168439-1-thomas@monjalon.net>
[not found] ` <AM0PR0502MB401926F72A8C41B49ED91296D2F60@AM0PR0502MB4019.eurprd05.prod.outlook.com>
2020-04-07 0:19 ` Thomas Monjalon [this message]
[not found] ` <20200407230647.59478-1-thomas@monjalon.net>
2020-04-07 23:06 ` [dpdk-stable] [PATCH v2 2/3] common/mlx5: fix build with -fno-common Thomas Monjalon
2020-04-07 23:06 ` [dpdk-stable] [PATCH v2 3/3] net/mlx4: " Thomas Monjalon
[not found] ` <20200408000900.61896-1-thomas@monjalon.net>
2020-04-08 0:08 ` [dpdk-stable] [PATCH v3 2/3] common/mlx5: " Thomas Monjalon
2020-04-08 0:09 ` [dpdk-stable] [PATCH v3 3/3] net/mlx4: " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3457836.1USP3dqvjW@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=matan@mellanox.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).