From: Thomas Monjalon <thomas@monjalon.net>
To: Nick Connolly <nick.connolly@mayadata.io>
Cc: stable@dpdk.org, Ranjit Menon <ranjit.menon@intel.com>,
dev@dpdk.org, dmitry.kozliuk@gmail.com,
navasile@linux.microsoft.com, dmitrym@microsoft.com,
pallavi.kadam@intel.com,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-stable] [PATCH v3] build: fix symlink of drivers for Windows
Date: Fri, 09 Jul 2021 17:05:50 +0200 [thread overview]
Message-ID: <3483457.HQZ5InbKmW@thomas> (raw)
In-Reply-To: <YLCnehBh4ovz8T+s@bricha3-MOBL.ger.corp.intel.com>
28/05/2021 10:19, Bruce Richardson:
> On Mon, Apr 26, 2021 at 11:07:32AM +0100, Nick Connolly wrote:
> > The symlink-drivers-solibs.sh script was disabled as part of 'install'
> > for Windows because there is no support for shell scripts. However,
> > this means that driver related DLLs are not present in the installed
> > 'libdir' directory. Add a python script to perform the install and use
> > it for Windows if the version of meson supports using an external
> > program with add_install_script (>= 0.55.0).
> >
> > On Windows, symbolic links are somewhat problematic since the
> > SeCreateSymbolicLinkPrivilege is required to be able to create them.
> > In addition, different cross-compilation environments handle symbolic
> > links differently, e.g. WSL, Msys2, Cygwin. Rather than trying to
> > distinguish these scenarios, the python script will perform a file copy
> > for any Windows specific names.
> >
> > On Windows, the shared library outputs have different names depending
> > upon which toolset has been used to build them. The script currently
> > handles Clang and GCC.
> >
> > On Linux the functionality is unchanged, but could be replaced with the
> > python script once the required minimum version of meson is >= 0.55.0.
> >
> > Fixes: 5c7d86948764 ("build: fix install on Windows")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
> > Tested-by: Narcisa Vasile <navasile@linux.microsoft.com>
> > Acked-by: Narcisa Vasile <navasile@linux.microsoft.com>
> > ---
> Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
Added the new file in MAINTAINERS.
Applied, thanks.
prev parent reply other threads:[~2021-07-09 15:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-01 12:27 [dpdk-stable] [PATCH] " Nick Connolly
2021-04-04 0:00 ` Dmitry Kozlyuk
2021-04-06 10:24 ` Nick Connolly
2021-04-10 8:01 ` [dpdk-stable] [PATCH v2] " Nick Connolly
2021-04-24 0:53 ` Narcisa Ana Maria Vasile
2021-04-26 10:07 ` [dpdk-stable] [PATCH v3] " Nick Connolly
2021-05-27 17:37 ` Nick Connolly
2021-05-28 8:19 ` Bruce Richardson
2021-05-28 10:50 ` Nick Connolly
2021-05-28 8:19 ` Bruce Richardson
2021-07-09 15:05 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3483457.HQZ5InbKmW@thomas \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=nick.connolly@mayadata.io \
--cc=pallavi.kadam@intel.com \
--cc=ranjit.menon@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).