From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E639A04A2 for ; Mon, 11 May 2020 04:13:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 18FC21D159; Mon, 11 May 2020 04:13:27 +0200 (CEST) Received: from huawei.com (szxga01-in.huawei.com [45.249.212.187]) by dpdk.org (Postfix) with ESMTP id 7AC101C1AB; Mon, 11 May 2020 04:13:23 +0200 (CEST) Received: from DGGEMM406-HUB.china.huawei.com (unknown [172.30.72.57]) by Forcepoint Email with ESMTP id 76492ADFF4E2562F8AD6; Mon, 11 May 2020 10:13:21 +0800 (CST) Received: from DGGEMM533-MBX.china.huawei.com ([169.254.5.111]) by DGGEMM406-HUB.china.huawei.com ([10.3.20.214]) with mapi id 14.03.0487.000; Mon, 11 May 2020 10:13:14 +0800 From: wangyunjian To: Gagandeep Singh , "dev@dpdk.org" , "Akhil Goyal" CC: Hemant Agrawal , "Lilijun (Jerry)" , xudingke , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong check of fd Thread-Index: AQHWG8q/uagB2K//Jk6/cpz94Krmf6iflTCAgADLyYCAAdpD4A== Date: Mon, 11 May 2020 02:13:12 +0000 Message-ID: <34EFBCA9F01B0748BEB6B629CE643AE60CFD617C@DGGEMM533-MBX.china.huawei.com> References: <1587906052-1548-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: Accept-Language: en-US Content-Language: zh-CN X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.173.251.152] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong check of fd X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" > -----Original Message----- > From: Gagandeep Singh [mailto:G.Singh@nxp.com] > Sent: Sunday, May 10, 2020 1:54 PM > To: wangyunjian ; dev@dpdk.org; Akhil Goyal > > Cc: Hemant Agrawal ; Lilijun (Jerry) > ; xudingke ; > stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong check of fd >=20 > Hi Yunjian, >=20 > > -----Original Message----- > > From: Gagandeep Singh > > Sent: Saturday, May 9, 2020 11:14 PM > > To: wangyunjian ; dev@dpdk.org; Akhil Goyal > > > > Cc: Hemant Agrawal ; > jerry.lilijun@huawei.com; > > xudingke@huawei.com; stable@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong check of fd > > > > > > > > > -----Original Message----- > > > From: wangyunjian > > > Sent: Sunday, April 26, 2020 6:31 PM > > > To: dev@dpdk.org > > > Cc: Gagandeep Singh ; Hemant Agrawal > > > ; jerry.lilijun@huawei.com; > > > xudingke@huawei.com; Yunjian Wang ; > > > stable@dpdk.org > > > Subject: [dpdk-dev] [PATCH] crypto/caam_jr: fix wrong check of fd > > > > > > From: Yunjian Wang > > > > > > Zero is a valid fd. It will fail to check the fd if the fd is zero. > > > > > > Fixes: e7a45f3cc245 ("crypto/caam_jr: add UIO specific operations") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Yunjian Wang > > > --- > > > drivers/crypto/caam_jr/caam_jr_uio.c | 6 +++--- > > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/crypto/caam_jr/caam_jr_uio.c > > > b/drivers/crypto/caam_jr/caam_jr_uio.c > > > index b1bb44ca4..658de5460 100644 > > > --- a/drivers/crypto/caam_jr/caam_jr_uio.c > > > +++ b/drivers/crypto/caam_jr/caam_jr_uio.c > > > @@ -145,7 +145,7 @@ file_read_first_line(const char root[], const > > > char subdir[], > > > "%s/%s/%s", root, subdir, filename); > > > > > > fd =3D open(absolute_file_name, O_RDONLY); > > > - SEC_ASSERT(fd > 0, fd, "Error opening file %s", > > > + SEC_ASSERT(fd >=3D 0, fd, "Error opening file %s", > > > absolute_file_name); > > > > > > /* read UIO device name from first line in file */ @@ -389,7 > > > +389,7 @@ uio_job_ring *config_job_ring(void) > > > > > > /* Open device file */ > > > job_ring->uio_fd =3D open(uio_device_file_name, O_RDWR); > > > - SEC_ASSERT(job_ring->uio_fd > 0, NULL, > > > + SEC_ASSERT(job_ring->uio_fd >=3D 0, NULL, > > > "Failed to open UIO device file for job ring %d", > > > job_ring->jr_id); > > > > > > @@ -488,7 +488,7 @@ sec_cleanup(void) > > > /* I need to close the fd after shutdown UIO commands need to > be > > > * sent using the fd > > > */ > > > - if (job_ring->uio_fd !=3D 0) { > > > + if (job_ring->uio_fd >=3D 0) { > > > CAAM_JR_INFO( > > > "Closed device file for job ring %d , fd =3D %d", > > > job_ring->jr_id, job_ring->uio_fd); > > > -- > > > 2.19.1 > > > > > > > > > Reviewed-by: Gagandeep Singh > > >=20 > "job_ring->uio_fd" is currently defined as uint32_t, so your patch will c= reate the > compilation issue. Please change it to int. Thanks, I will fix it in next version.