From: wangyunjian <wangyunjian@huawei.com>
To: "dev@dpdk.org" <dev@dpdk.org>
Cc: "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"sachin.saxena@nxp.com" <sachin.saxena@nxp.com>,
"anatoly.burakov@intel.com" <anatoly.burakov@intel.com>,
"Lilijun (Jerry)" <jerry.lilijun@huawei.com>,
xudingke <xudingke@huawei.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH 2/2] bus/fslmc: fix check for vfio_group_fd
Date: Thu, 17 Sep 2020 12:43:47 +0000 [thread overview]
Message-ID: <34EFBCA9F01B0748BEB6B629CE643AE60DA5142D@DGGEMM533-MBX.china.huawei.com> (raw)
In-Reply-To: <1589859732-5008-1-git-send-email-wangyunjian@huawei.com>
Friendly ping
> -----Original Message-----
> From: wangyunjian
> Sent: Tuesday, May 19, 2020 11:42 AM
> To: dev@dpdk.org
> Cc: anatoly.burakov@intel.com; hemant.agrawal@nxp.com;
> sachin.saxena@nxp.com; Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke
> <xudingke@huawei.com>; wangyunjian <wangyunjian@huawei.com>;
> stable@dpdk.org
> Subject: [dpdk-dev] [PATCH 2/2] bus/fslmc: fix check for vfio_group_fd
>
> From: Yunjian Wang <wangyunjian@huawei.com>
>
> The issue is that a file descriptor at 0 is a valid one. Currently the file not found,
> the return value will be set to 0. As a result, it is impossible to distinguish
> between a correct descriptor and a failed return value. Fix it to return -ENOENT
> instead of 0.
>
> Fixes: a69f79300262 ("bus/fslmc: support multi VFIO group")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---
> drivers/bus/fslmc/fslmc_vfio.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/bus/fslmc/fslmc_vfio.c b/drivers/bus/fslmc/fslmc_vfio.c index
> 970969d2b..04ccf4af6 100644
> --- a/drivers/bus/fslmc/fslmc_vfio.c
> +++ b/drivers/bus/fslmc/fslmc_vfio.c
> @@ -448,11 +448,14 @@ fslmc_vfio_setup_device(const char *sysfs_base,
> const char *dev_addr,
>
> /* get the actual group fd */
> vfio_group_fd = rte_vfio_get_group_fd(iommu_group_no);
> - if (vfio_group_fd < 0)
> + if (vfio_group_fd < 0 && vfio_group_fd != -ENOENT)
> return -1;
>
> - /* if group_fd == 0, that means the device isn't managed by VFIO */
> - if (vfio_group_fd == 0) {
> + /*
> + * if vfio_group_fd == -ENOENT, that means the device
> + * isn't managed by VFIO
> + */
> + if (vfio_group_fd == -ENOENT) {
> RTE_LOG(WARNING, EAL, " %s not managed by VFIO driver,
> skipping\n",
> dev_addr);
> return 1;
> --
> 2.23.0
>
next prev parent reply other threads:[~2020-09-17 12:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-19 3:42 wangyunjian
2020-09-17 12:43 ` wangyunjian [this message]
2020-09-17 12:56 ` Burakov, Anatoly
2020-09-17 13:34 ` wangyunjian
2020-09-17 14:41 ` Burakov, Anatoly
2020-09-17 15:38 ` Hemant Agrawal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34EFBCA9F01B0748BEB6B629CE643AE60DA5142D@DGGEMM533-MBX.china.huawei.com \
--to=wangyunjian@huawei.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=jerry.lilijun@huawei.com \
--cc=sachin.saxena@nxp.com \
--cc=stable@dpdk.org \
--cc=xudingke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).