* [dpdk-stable] [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event @ 2020-07-15 2:40 wangyunjian 2020-08-26 10:55 ` wangyunjian ` (2 more replies) 0 siblings, 3 replies; 10+ messages in thread From: wangyunjian @ 2020-07-15 2:40 UTC (permalink / raw) To: dev, hkalra; +Cc: jerry.lilijun, xudingke, Yunjian Wang, stable From: Yunjian Wang <wangyunjian@huawei.com> The "rev->epdata.event" assigned to "events.epdata.event" directly, which was wrong in case of epoll events. It should be set to the "evs.events". Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> --- lib/librte_eal/linux/eal_interrupts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linux/eal_interrupts.c b/lib/librte_eal/linux/eal_interrupts.c index 13db5c4e8..8a3c95cec 100644 --- a/lib/librte_eal/linux/eal_interrupts.c +++ b/lib/librte_eal/linux/eal_interrupts.c @@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event *evs, unsigned int n, events[count].status = RTE_EPOLL_VALID; events[count].fd = rev->fd; events[count].epfd = rev->epfd; - events[count].epdata.event = rev->epdata.event; + events[count].epdata.event = evs[i].events; events[count].epdata.data = rev->epdata.data; if (rev->epdata.cb_fun) rev->epdata.cb_fun(rev->fd, -- 2.23.0 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event 2020-07-15 2:40 [dpdk-stable] [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event wangyunjian @ 2020-08-26 10:55 ` wangyunjian 2020-09-19 10:42 ` wangyunjian 2021-01-11 14:40 ` [dpdk-stable] " David Marchand 2 siblings, 0 replies; 10+ messages in thread From: wangyunjian @ 2020-08-26 10:55 UTC (permalink / raw) To: dev, hkalra, david.marchand Cc: ferruh.yigit, Thomas Monjalon, Lilijun (Jerry), xudingke, stable Ping for review, please. > -----Original Message----- > From: wangyunjian > Sent: Wednesday, July 15, 2020 10:40 AM > To: dev@dpdk.org; hkalra@marvell.com > Cc: Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke > <xudingke@huawei.com>; wangyunjian <wangyunjian@huawei.com>; > stable@dpdk.org > Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event > > From: Yunjian Wang <wangyunjian@huawei.com> > > The "rev->epdata.event" assigned to "events.epdata.event" directly, which > was wrong in case of epoll events. It should be set to the "evs.events". > > Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> > --- > lib/librte_eal/linux/eal_interrupts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > b/lib/librte_eal/linux/eal_interrupts.c > index 13db5c4e8..8a3c95cec 100644 > --- a/lib/librte_eal/linux/eal_interrupts.c > +++ b/lib/librte_eal/linux/eal_interrupts.c > @@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event *evs, > unsigned int n, > events[count].status = RTE_EPOLL_VALID; > events[count].fd = rev->fd; > events[count].epfd = rev->epfd; > - events[count].epdata.event = rev->epdata.event; > + events[count].epdata.event = evs[i].events; > events[count].epdata.data = rev->epdata.data; > if (rev->epdata.cb_fun) > rev->epdata.cb_fun(rev->fd, > -- > 2.23.0 > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event 2020-07-15 2:40 [dpdk-stable] [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event wangyunjian 2020-08-26 10:55 ` wangyunjian @ 2020-09-19 10:42 ` wangyunjian 2020-09-21 8:04 ` David Marchand 2020-09-22 10:31 ` [dpdk-stable] [EXT] " Harman Kalra 2021-01-11 14:40 ` [dpdk-stable] " David Marchand 2 siblings, 2 replies; 10+ messages in thread From: wangyunjian @ 2020-09-19 10:42 UTC (permalink / raw) To: dev, hkalra, david.marchand Cc: ferruh.yigit, Thomas Monjalon, Lilijun (Jerry), xudingke, stable Friendly ping. > -----Original Message----- > From: wangyunjian > Sent: Wednesday, August 26, 2020 6:56 PM > To: dev@dpdk.org; hkalra@marvell.com; david.marchand@redhat.com > Cc: 'ferruh.yigit@intel.com' <ferruh.yigit@intel.com>; 'Thomas Monjalon' > <thomas@monjalon.net>; Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke > <xudingke@huawei.com>; stable@dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for > rte_epoll_event > > Ping for review, please. > > > -----Original Message----- > > From: wangyunjian > > Sent: Wednesday, July 15, 2020 10:40 AM > > To: dev@dpdk.org; hkalra@marvell.com > > Cc: Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke > > <xudingke@huawei.com>; wangyunjian <wangyunjian@huawei.com>; > > stable@dpdk.org > > Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for > > rte_epoll_event > > > > From: Yunjian Wang <wangyunjian@huawei.com> > > > > The "rev->epdata.event" assigned to "events.epdata.event" directly, > > which was wrong in case of epoll events. It should be set to the "evs.events". > > > > Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") > > Cc: stable@dpdk.org > > > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> > > --- > > lib/librte_eal/linux/eal_interrupts.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > > b/lib/librte_eal/linux/eal_interrupts.c > > index 13db5c4e8..8a3c95cec 100644 > > --- a/lib/librte_eal/linux/eal_interrupts.c > > +++ b/lib/librte_eal/linux/eal_interrupts.c > > @@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event *evs, > > unsigned int n, > > events[count].status = RTE_EPOLL_VALID; > > events[count].fd = rev->fd; > > events[count].epfd = rev->epfd; > > - events[count].epdata.event = rev->epdata.event; > > + events[count].epdata.event = evs[i].events; > > events[count].epdata.data = rev->epdata.data; > > if (rev->epdata.cb_fun) > > rev->epdata.cb_fun(rev->fd, > > -- > > 2.23.0 > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event 2020-09-19 10:42 ` wangyunjian @ 2020-09-21 8:04 ` David Marchand 2020-09-21 13:17 ` wangyunjian 2020-09-22 10:31 ` [dpdk-stable] [EXT] " Harman Kalra 1 sibling, 1 reply; 10+ messages in thread From: David Marchand @ 2020-09-21 8:04 UTC (permalink / raw) To: wangyunjian Cc: dev, hkalra, ferruh.yigit, Thomas Monjalon, Lilijun (Jerry), xudingke, stable On Sat, Sep 19, 2020 at 12:42 PM wangyunjian <wangyunjian@huawei.com> wrote: > > Friendly ping. It is fair to ask for reviews but please do contribute by reviewing other patches on the mailing list. Thanks. -- David Marchand ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event 2020-09-21 8:04 ` David Marchand @ 2020-09-21 13:17 ` wangyunjian 0 siblings, 0 replies; 10+ messages in thread From: wangyunjian @ 2020-09-21 13:17 UTC (permalink / raw) To: David Marchand Cc: dev, hkalra, ferruh.yigit, Thomas Monjalon, Lilijun (Jerry), xudingke, stable > -----Original Message----- > From: David Marchand [mailto:david.marchand@redhat.com] > Sent: Monday, September 21, 2020 4:05 PM > To: wangyunjian <wangyunjian@huawei.com> > Cc: dev@dpdk.org; hkalra@marvell.com; ferruh.yigit@intel.com; Thomas > Monjalon <thomas@monjalon.net>; Lilijun (Jerry) <jerry.lilijun@huawei.com>; > xudingke <xudingke@huawei.com>; stable@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for > rte_epoll_event > > On Sat, Sep 19, 2020 at 12:42 PM wangyunjian <wangyunjian@huawei.com> > wrote: > > > > Friendly ping. > > It is fair to ask for reviews but please do contribute by reviewing other patches > on the mailing list. > Thanks. Do you mean I need to review other patches on the mailing list? If so, I'm glad to do it. I will review patches in my field of expertise. Thanks, Yunjian > > > -- > David Marchand ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event 2020-09-19 10:42 ` wangyunjian 2020-09-21 8:04 ` David Marchand @ 2020-09-22 10:31 ` Harman Kalra 2020-09-22 12:05 ` wangyunjian 2020-11-02 2:15 ` wangyunjian 1 sibling, 2 replies; 10+ messages in thread From: Harman Kalra @ 2020-09-22 10:31 UTC (permalink / raw) To: wangyunjian Cc: dev, david.marchand, ferruh.yigit, Thomas Monjalon, Lilijun (Jerry), xudingke, stable On Sat, Sep 19, 2020 at 10:42:30AM +0000, wangyunjian wrote: > External Email > > ---------------------------------------------------------------------- > Friendly ping. Hi Wang, I am sorry for the delay in review, I will surely complete the review by end of this week. Can you please elaborate on the specific case/scenario which caused failure i.e. which lead you to this change. Thanks Harman > > > -----Original Message----- > > From: wangyunjian > > Sent: Wednesday, August 26, 2020 6:56 PM > > To: dev@dpdk.org; hkalra@marvell.com; david.marchand@redhat.com > > Cc: 'ferruh.yigit@intel.com' <ferruh.yigit@intel.com>; 'Thomas Monjalon' > > <thomas@monjalon.net>; Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke > > <xudingke@huawei.com>; stable@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for > > rte_epoll_event > > > > Ping for review, please. > > > > > -----Original Message----- > > > From: wangyunjian > > > Sent: Wednesday, July 15, 2020 10:40 AM > > > To: dev@dpdk.org; hkalra@marvell.com > > > Cc: Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke > > > <xudingke@huawei.com>; wangyunjian <wangyunjian@huawei.com>; > > > stable@dpdk.org > > > Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for > > > rte_epoll_event > > > > > > From: Yunjian Wang <wangyunjian@huawei.com> > > > > > > The "rev->epdata.event" assigned to "events.epdata.event" directly, > > > which was wrong in case of epoll events. It should be set to the "evs.events". > > > > > > Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> > > > --- > > > lib/librte_eal/linux/eal_interrupts.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > > > b/lib/librte_eal/linux/eal_interrupts.c > > > index 13db5c4e8..8a3c95cec 100644 > > > --- a/lib/librte_eal/linux/eal_interrupts.c > > > +++ b/lib/librte_eal/linux/eal_interrupts.c > > > @@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event *evs, > > > unsigned int n, > > > events[count].status = RTE_EPOLL_VALID; > > > events[count].fd = rev->fd; > > > events[count].epfd = rev->epfd; > > > - events[count].epdata.event = rev->epdata.event; > > > + events[count].epdata.event = evs[i].events; > > > events[count].epdata.data = rev->epdata.data; > > > if (rev->epdata.cb_fun) > > > rev->epdata.cb_fun(rev->fd, > > > -- > > > 2.23.0 > > > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event 2020-09-22 10:31 ` [dpdk-stable] [EXT] " Harman Kalra @ 2020-09-22 12:05 ` wangyunjian 2020-11-02 2:15 ` wangyunjian 1 sibling, 0 replies; 10+ messages in thread From: wangyunjian @ 2020-09-22 12:05 UTC (permalink / raw) To: Harman Kalra Cc: dev, david.marchand, ferruh.yigit, Thomas Monjalon, Lilijun (Jerry), xudingke, stable > -----Original Message----- > From: Harman Kalra [mailto:hkalra@marvell.com] > Sent: Tuesday, September 22, 2020 6:32 PM > To: wangyunjian <wangyunjian@huawei.com> > Cc: dev@dpdk.org; david.marchand@redhat.com; ferruh.yigit@intel.com; > Thomas Monjalon <thomas@monjalon.net>; Lilijun (Jerry) > <jerry.lilijun@huawei.com>; xudingke <xudingke@huawei.com>; > stable@dpdk.org > Subject: Re: [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for > rte_epoll_event > > On Sat, Sep 19, 2020 at 10:42:30AM +0000, wangyunjian wrote: > > External Email > > > > ---------------------------------------------------------------------- > > Friendly ping. > > Hi Wang, > > I am sorry for the delay in review, I will surely complete the review > by end of this week. > Can you please elaborate on the specific case/scenario which caused > failure i.e. which lead you to this change. EPOLLERR event will be triggered when an exception occurs. This event will be set in 'evs.events', we should use 'evs.events' instead of 'rev->epdata.event' to assign to 'events.epdata.event'. Otherwise, the EPOLLERR event will lost. Thanks, Yunjian > > Thanks > Harman > > > > > > -----Original Message----- > > > From: wangyunjian > > > Sent: Wednesday, August 26, 2020 6:56 PM > > > To: dev@dpdk.org; hkalra@marvell.com; david.marchand@redhat.com > > > Cc: 'ferruh.yigit@intel.com' <ferruh.yigit@intel.com>; 'Thomas Monjalon' > > > <thomas@monjalon.net>; Lilijun (Jerry) <jerry.lilijun@huawei.com>; > > > xudingke <xudingke@huawei.com>; stable@dpdk.org > > > Subject: RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error > > > for rte_epoll_event > > > > > > Ping for review, please. > > > > > > > -----Original Message----- > > > > From: wangyunjian > > > > Sent: Wednesday, July 15, 2020 10:40 AM > > > > To: dev@dpdk.org; hkalra@marvell.com > > > > Cc: Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke > > > > <xudingke@huawei.com>; wangyunjian <wangyunjian@huawei.com>; > > > > stable@dpdk.org > > > > Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for > > > > rte_epoll_event > > > > > > > > From: Yunjian Wang <wangyunjian@huawei.com> > > > > > > > > The "rev->epdata.event" assigned to "events.epdata.event" > > > > directly, which was wrong in case of epoll events. It should be set to the > "evs.events". > > > > > > > > Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> > > > > --- > > > > lib/librte_eal/linux/eal_interrupts.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > > > > b/lib/librte_eal/linux/eal_interrupts.c > > > > index 13db5c4e8..8a3c95cec 100644 > > > > --- a/lib/librte_eal/linux/eal_interrupts.c > > > > +++ b/lib/librte_eal/linux/eal_interrupts.c > > > > @@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event > > > > *evs, unsigned int n, > > > > events[count].status = RTE_EPOLL_VALID; > > > > events[count].fd = rev->fd; > > > > events[count].epfd = rev->epfd; > > > > - events[count].epdata.event = rev->epdata.event; > > > > + events[count].epdata.event = evs[i].events; > > > > events[count].epdata.data = rev->epdata.data; > > > > if (rev->epdata.cb_fun) > > > > rev->epdata.cb_fun(rev->fd, > > > > -- > > > > 2.23.0 > > > > > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event 2020-09-22 10:31 ` [dpdk-stable] [EXT] " Harman Kalra 2020-09-22 12:05 ` wangyunjian @ 2020-11-02 2:15 ` wangyunjian 2020-12-21 14:38 ` Harman Kalra 1 sibling, 1 reply; 10+ messages in thread From: wangyunjian @ 2020-11-02 2:15 UTC (permalink / raw) To: Harman Kalra Cc: dev, david.marchand, ferruh.yigit, Thomas Monjalon, Lilijun (Jerry), xudingke, stable > -----Original Message----- > From: wangyunjian > Sent: Tuesday, September 22, 2020 8:06 PM > To: 'Harman Kalra' <hkalra@marvell.com> > Cc: dev@dpdk.org; david.marchand@redhat.com; ferruh.yigit@intel.com; > Thomas Monjalon <thomas@monjalon.net>; Lilijun (Jerry) > <jerry.lilijun@huawei.com>; xudingke <xudingke@huawei.com>; > stable@dpdk.org > Subject: RE: [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for > rte_epoll_event > > > -----Original Message----- > > From: Harman Kalra [mailto:hkalra@marvell.com] > > Sent: Tuesday, September 22, 2020 6:32 PM > > To: wangyunjian <wangyunjian@huawei.com> > > Cc: dev@dpdk.org; david.marchand@redhat.com; ferruh.yigit@intel.com; > > Thomas Monjalon <thomas@monjalon.net>; Lilijun (Jerry) > > <jerry.lilijun@huawei.com>; xudingke <xudingke@huawei.com>; > > stable@dpdk.org > > Subject: Re: [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set > > error for rte_epoll_event > > > > On Sat, Sep 19, 2020 at 10:42:30AM +0000, wangyunjian wrote: > > > External Email > > > > > > -------------------------------------------------------------------- > > > -- > > > Friendly ping. > > > > Hi Wang, > > > > I am sorry for the delay in review, I will surely complete the review > > by end of this week. > > Can you please elaborate on the specific case/scenario which caused > > failure i.e. which lead you to this change. > > EPOLLERR event will be triggered when an exception occurs. This event will be > set in 'evs.events', we should use 'evs.events' instead of 'rev->epdata.event' to > assign to 'events.epdata.event'. Otherwise, the EPOLLERR event will lost. > > Thanks, > Yunjian Hi Harman, Is there any ideas on this issue? > > > > > Thanks > > Harman > > > > > > > > > -----Original Message----- > > > > From: wangyunjian > > > > Sent: Wednesday, August 26, 2020 6:56 PM > > > > To: dev@dpdk.org; hkalra@marvell.com; david.marchand@redhat.com > > > > Cc: 'ferruh.yigit@intel.com' <ferruh.yigit@intel.com>; 'Thomas Monjalon' > > > > <thomas@monjalon.net>; Lilijun (Jerry) <jerry.lilijun@huawei.com>; > > > > xudingke <xudingke@huawei.com>; stable@dpdk.org > > > > Subject: RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error > > > > for rte_epoll_event > > > > > > > > Ping for review, please. > > > > > > > > > -----Original Message----- > > > > > From: wangyunjian > > > > > Sent: Wednesday, July 15, 2020 10:40 AM > > > > > To: dev@dpdk.org; hkalra@marvell.com > > > > > Cc: Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke > > > > > <xudingke@huawei.com>; wangyunjian <wangyunjian@huawei.com>; > > > > > stable@dpdk.org > > > > > Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error > > > > > for rte_epoll_event > > > > > > > > > > From: Yunjian Wang <wangyunjian@huawei.com> > > > > > > > > > > The "rev->epdata.event" assigned to "events.epdata.event" > > > > > directly, which was wrong in case of epoll events. It should be > > > > > set to the > > "evs.events". > > > > > > > > > > Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") > > > > > Cc: stable@dpdk.org > > > > > > > > > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> > > > > > --- > > > > > lib/librte_eal/linux/eal_interrupts.c | 2 +- > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > > > > > b/lib/librte_eal/linux/eal_interrupts.c > > > > > index 13db5c4e8..8a3c95cec 100644 > > > > > --- a/lib/librte_eal/linux/eal_interrupts.c > > > > > +++ b/lib/librte_eal/linux/eal_interrupts.c > > > > > @@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event > > > > > *evs, unsigned int n, > > > > > events[count].status = RTE_EPOLL_VALID; > > > > > events[count].fd = rev->fd; > > > > > events[count].epfd = rev->epfd; > > > > > - events[count].epdata.event = rev->epdata.event; > > > > > + events[count].epdata.event = evs[i].events; > > > > > events[count].epdata.data = rev->epdata.data; > > > > > if (rev->epdata.cb_fun) > > > > > rev->epdata.cb_fun(rev->fd, > > > > > -- > > > > > 2.23.0 > > > > > > > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event 2020-11-02 2:15 ` wangyunjian @ 2020-12-21 14:38 ` Harman Kalra 0 siblings, 0 replies; 10+ messages in thread From: Harman Kalra @ 2020-12-21 14:38 UTC (permalink / raw) To: wangyunjian Cc: dev, david.marchand, ferruh.yigit, Thomas Monjalon, Lilijun (Jerry), xudingke, stable On Mon, Nov 02, 2020 at 02:15:01AM +0000, wangyunjian wrote: > > -----Original Message----- > > From: wangyunjian > > Sent: Tuesday, September 22, 2020 8:06 PM > > To: 'Harman Kalra' <hkalra@marvell.com> > > Cc: dev@dpdk.org; david.marchand@redhat.com; ferruh.yigit@intel.com; > > Thomas Monjalon <thomas@monjalon.net>; Lilijun (Jerry) > > <jerry.lilijun@huawei.com>; xudingke <xudingke@huawei.com>; > > stable@dpdk.org > > Subject: RE: [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for > > rte_epoll_event > > > > > -----Original Message----- > > > From: Harman Kalra [mailto:hkalra@marvell.com] > > > Sent: Tuesday, September 22, 2020 6:32 PM > > > To: wangyunjian <wangyunjian@huawei.com> > > > Cc: dev@dpdk.org; david.marchand@redhat.com; ferruh.yigit@intel.com; > > > Thomas Monjalon <thomas@monjalon.net>; Lilijun (Jerry) > > > <jerry.lilijun@huawei.com>; xudingke <xudingke@huawei.com>; > > > stable@dpdk.org > > > Subject: Re: [EXT] RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set > > > error for rte_epoll_event > > > > > > On Sat, Sep 19, 2020 at 10:42:30AM +0000, wangyunjian wrote: > > > > External Email > > > > > > > > -------------------------------------------------------------------- > > > > -- > > > > Friendly ping. > > > > > > Hi Wang, > > > > > > I am sorry for the delay in review, I will surely complete the review > > > by end of this week. > > > Can you please elaborate on the specific case/scenario which caused > > > failure i.e. which lead you to this change. > > > > EPOLLERR event will be triggered when an exception occurs. This event will be > > set in 'evs.events', we should use 'evs.events' instead of 'rev->epdata.event' to > > assign to 'events.epdata.event'. Otherwise, the EPOLLERR event will lost. > > > > Thanks, > > Yunjian > > Hi Harman, > > Is there any ideas on this issue? Hi Yunjian Fix looks good, apologies for the delay in review. Acked-by: Harman Kalra <hkalra@marvell.com> > > > > > > > > > Thanks > > > Harman > > > > > > > > > > > > -----Original Message----- > > > > > From: wangyunjian > > > > > Sent: Wednesday, August 26, 2020 6:56 PM > > > > > To: dev@dpdk.org; hkalra@marvell.com; david.marchand@redhat.com > > > > > Cc: 'ferruh.yigit@intel.com' <ferruh.yigit@intel.com>; 'Thomas Monjalon' > > > > > <thomas@monjalon.net>; Lilijun (Jerry) <jerry.lilijun@huawei.com>; > > > > > xudingke <xudingke@huawei.com>; stable@dpdk.org > > > > > Subject: RE: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error > > > > > for rte_epoll_event > > > > > > > > > > Ping for review, please. > > > > > > > > > > > -----Original Message----- > > > > > > From: wangyunjian > > > > > > Sent: Wednesday, July 15, 2020 10:40 AM > > > > > > To: dev@dpdk.org; hkalra@marvell.com > > > > > > Cc: Lilijun (Jerry) <jerry.lilijun@huawei.com>; xudingke > > > > > > <xudingke@huawei.com>; wangyunjian <wangyunjian@huawei.com>; > > > > > > stable@dpdk.org > > > > > > Subject: [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error > > > > > > for rte_epoll_event > > > > > > > > > > > > From: Yunjian Wang <wangyunjian@huawei.com> > > > > > > > > > > > > The "rev->epdata.event" assigned to "events.epdata.event" > > > > > > directly, which was wrong in case of epoll events. It should be > > > > > > set to the > > > "evs.events". > > > > > > > > > > > > Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") > > > > > > Cc: stable@dpdk.org > > > > > > > > > > > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> > > > > > > --- > > > > > > lib/librte_eal/linux/eal_interrupts.c | 2 +- > > > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/lib/librte_eal/linux/eal_interrupts.c > > > > > > b/lib/librte_eal/linux/eal_interrupts.c > > > > > > index 13db5c4e8..8a3c95cec 100644 > > > > > > --- a/lib/librte_eal/linux/eal_interrupts.c > > > > > > +++ b/lib/librte_eal/linux/eal_interrupts.c > > > > > > @@ -1237,7 +1237,7 @@ eal_epoll_process_event(struct epoll_event > > > > > > *evs, unsigned int n, > > > > > > events[count].status = RTE_EPOLL_VALID; > > > > > > events[count].fd = rev->fd; > > > > > > events[count].epfd = rev->epfd; > > > > > > - events[count].epdata.event = rev->epdata.event; > > > > > > + events[count].epdata.event = evs[i].events; > > > > > > events[count].epdata.data = rev->epdata.data; > > > > > > if (rev->epdata.cb_fun) > > > > > > rev->epdata.cb_fun(rev->fd, > > > > > > -- > > > > > > 2.23.0 > > > > > > > > > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event 2020-07-15 2:40 [dpdk-stable] [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event wangyunjian 2020-08-26 10:55 ` wangyunjian 2020-09-19 10:42 ` wangyunjian @ 2021-01-11 14:40 ` David Marchand 2 siblings, 0 replies; 10+ messages in thread From: David Marchand @ 2021-01-11 14:40 UTC (permalink / raw) To: wangyunjian; +Cc: dev, Harman Kalra, Lilijun (Jerry), xudingke, dpdk stable On Wed, Jul 15, 2020 at 4:48 AM wangyunjian <wangyunjian@huawei.com> wrote: > > From: Yunjian Wang <wangyunjian@huawei.com> > > The "rev->epdata.event" assigned to "events.epdata.event" directly, which > was wrong in case of epoll events. It should be set to the "evs.events". > > Fixes: 9efe9c6cdcac ("eal/linux: add epoll wrappers") > Cc: stable@dpdk.org > > Signed-off-by: Yunjian Wang <wangyunjian@huawei.com> Acked-by: Harman Kalra <hkalra@marvell.com> Applied, thanks. -- David Marchand ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2021-01-11 14:41 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-15 2:40 [dpdk-stable] [dpdk-dev] [PATCH 1/1] eal/linux: fix event set error for rte_epoll_event wangyunjian 2020-08-26 10:55 ` wangyunjian 2020-09-19 10:42 ` wangyunjian 2020-09-21 8:04 ` David Marchand 2020-09-21 13:17 ` wangyunjian 2020-09-22 10:31 ` [dpdk-stable] [EXT] " Harman Kalra 2020-09-22 12:05 ` wangyunjian 2020-11-02 2:15 ` wangyunjian 2020-12-21 14:38 ` Harman Kalra 2021-01-11 14:40 ` [dpdk-stable] " David Marchand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).